From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f34.google.com (mail-wr2-f34.google.com [74.125.225.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0736F3A9605 for ; Tue, 29 Sep 2026 17:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790701501; cv=none; b=gTW7iKd8Pf8P//yQLjzg0VwIoD64AfF4AJKrpQoRLdpAIP1Okj0hO8NJfs5w+9P3d6iPYkJtHbmg2KeRW8O3PpJ63H0dyaCdBHLCtEf1cbGMnBlI7gH6W6nX/GQKYqEcqZF2HjmaywQI5YVf7befX3ODa6GMQh+KDpkWmTs1+wE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790701501; c=relaxed/simple; bh=lSKhCVe2e9y67BQZBB8N5b0lo4u2NoSTarkPLG+MNOA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tf57fU15rxeVx0P8xAbL6EVvtiqH6rmS2BjRyj3tfRe3Q+KAN5v9hlhwbtZU5j82E5yZ6RreJiqoq/bJFjLJBj721zjiG3OARFxdImlhHkyYoj/Sv8Xs4QX31h+Mi9p17WA6zzYUt5c/jzra4Q/6MKYkhgrGvARu2wT+ELErx/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ndru4r+4; arc=none smtp.client-ip=74.125.225.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ndru4r+4" Received: by mail-wr2-f34.google.com with SMTP id ffacd0b85a97d-48afd5b1678so64430f8f.2 for ; Tue, 29 Sep 2026 10:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790701498; x=1791306298; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=IYlY+0VQmviH8AJ9O1JXprZTbqCcvurlza+Wbwy3a28=; b=ndru4r+45UlLvkt9Jo7mAfA/iJ8v4WnZjZ2imhAPMsweaAyPPZ86ESzXx/y/VZ/SZf eohcQnK1yuWRO7NqWW3sDAXmXDbXSTDfc0/RUjgIz/ZLRRawGplibykllKekjkniJQVJ jqkUe7DBa0wJNANEvipMCBx0kHIJ3FCTtPjFzeilJVc5sJ3HQDUnvyQmIv9C2nRbgb61 wTqXFKnPPq+GIdJAHbQA02EeGfsJLQ95Ar+iMTG3QHl6FRWYivG59GP3LNY+o2WVlHEI 3dJRcUONzTPSGEocddVslU2FhQgobnlJBn9TBtQRgFG2pECH3tT6VYBFIJI4i3HEIPpu VhOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790701498; x=1791306298; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IYlY+0VQmviH8AJ9O1JXprZTbqCcvurlza+Wbwy3a28=; b=NINu65mcTgAUGSAxd19CxiZ0lToP6zEPcGgMrzT5P1fef0cbnXIvjUGYak9WpiidAP +tqBqPCaTb+77b63f4I5VVbKU8XpC+dkeuYkea24TmN53XNFDdGvf+EK2+q0EpahlNkB 88KxF2PelxtZ2BkqiC6PAcnHfzLtuNFfYepo0rixyuOVFF0y9oy5yZEOOuq2rvQIdEoK j5MXFq0OitCr0p8imxb618jA9vfEQX+T4ZlOUhehSBo/TzrngboVFn9foyZYvlqAhT8h rYWJSnK14qam7tGcpPjj5aq16vZ0oJXen8tZF5CFV2to7LGFHHqq976+JtyeDs7e/+4u sP+A== X-Forwarded-Encrypted: i=1; AKwUvBxkwtkIdaFDzSOvWRnVr6JCZAttA3nJLNCpbqXkcg/yEcTBh/GflyN2zOTcbChBGZRB4y3f/68=@vger.kernel.org X-Gm-Message-State: AFq9FYLG1wu/8Eb2CgdCZlImbxO1HJ4JshzTrKEO6PPK0tcS+YOuJhUc w6KFebrhYYHTWB1Aa89PqB/jvvoeqbWC4w4nCXLVF5khAjtISLLhh9yM X-Gm-Gg: AYBFou0AMwimw+BSGnqCscYqbPYYnMXldvgD03ogCXwIGCEjuDxlR663lKPGcht/YzD M23/LqBO8T2/TrvjjLXYtnpJZK/t7qqanNHAiw8SvXA2VXMD6zOLk01OtRLIihTAWiNuJIgWXPX 60ZqnZIMgsFRdUsplg8K1ZJtuP6itKEJIzcyQm/e/yQDkifBTkM3tZnjXScvQrBk2i/drNYggwe GbfmwBQjeCrYDI8G5i3vREp9r2OgeumpXlcwz9OHO+yuKBX9pHk+wZl7wBarFmBHnxUlOXsTe4g c+H24I/Gd6wsZJq4Uc3lg5eCNlq54fwXH7xda49nxOkPVMXoDegqIHHQUsE2T7z8ti+kRjBm395 hoWqy1XVqZ99uKGaVxu7Ac50gO1wCPaRoW/WtVCnhUar4J3GT+IGqRpixGCloogvZWvoP6yllrG kUzUCfPVsQ2QOawIXgti9MXg+32MqbwziUlyWW3p3sLz4R2FfJKm3ZInjtBXrKu977J7Esgfi85 FypjQurErhgH7l+HmGlbdjuwzd5YAhEwuw0Ai6dtTKdNIsz/ealkLY= X-Received: by 2002:a05:6000:2204:b0:487:27f6:a4e5 with SMTP id ffacd0b85a97d-488716bd7ecmr33864013f8f.53.1790701498062; Tue, 29 Sep 2026 10:04:58 -0700 (PDT) Received: from andreayoga.wind3.hub ([31.189.116.68]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48afe698525sm3243f8f.20.2026.09.29.10.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 10:04:56 -0700 (PDT) From: Andrea Parri To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Andrea Parri , Simon Horman , Kuniyuki Iwashima , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net] rtnetlink: wait for RCU readers in rtnl_link_unregister() Date: Tue, 29 Sep 2026 19:04:42 +0200 Message-ID: <20260929170444.218093-1-parri.andrea@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rtnl_link_ops_get() finds ops on link_ops under rcu_read_lock() and only then takes ops->srcu. rtnl_link_unregister() unlinks ops, then calls synchronize_srcu() and cleanup_srcu_struct() without first waiting for RCU readers. A reader that found ops before list_del_rcu() and has not yet taken ops->srcu is not waited for. Such a reader then locks a cleaned-up srcu_struct and keeps using ops after the module that owns it is gone. rtnl_newlink() and rtnl_dump_ifinfo() both look up ops without RTNL, the latter for any user that dumps links filtered by kind. With delays added between the lookup and srcu_read_lock() in rtnl_link_ops_get(), and before rtnl_link_ops_put() in rtnl_dump_ifinfo(), running "ip link show type dummy" alongside "rmmod dummy" on a KASAN kernel gives: BUG: KASAN: vmalloc-out-of-bounds in __srcu_read_unlock+0x57/0x70 Read of size 8 at addr ffffffffc02ff318 by task ip/147 Call Trace: __srcu_read_unlock+0x57/0x70 rtnl_dump_ifinfo.cold+0x30/0x3b rtnl_dumpit+0x7a/0x1b0 netlink_dump+0x486/0x11b0 __netlink_dump_start+0x661/0x910 rtnetlink_rcv_msg+0x611/0x9e0 netlink_rcv_skb+0x126/0x380 netlink_unicast+0x605/0x830 netlink_sendmsg+0x6d0/0xbb0 __sys_sendto+0x335/0x3a0 Call synchronize_rcu() before synchronize_srcu(), as rtnl_af_unregister() already does. This should be enough because rtnl_link_ops_get() is the only RCU walker of link_ops, and it takes ops->srcu before rcu_read_unlock(), so every reader that found ops is covered by synchronize_srcu() once the RCU grace period ends. The extra grace period only costs time at module unload. Readers and the writer were serialized by RTNL until link_ops got its own mutex, which is why the missing RCU wait did not matter before. Fixes: 6b57ff21a310 ("rtnetlink: Protect link_ops by mutex.") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Andrea Parri --- net/core/rtnetlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index be9d1625bac31..abcd2c4ea2178 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -707,6 +707,7 @@ void rtnl_link_unregister(struct rtnl_link_ops *ops) list_del_rcu(&ops->list); mutex_unlock(&link_ops_mutex); + synchronize_rcu(); synchronize_srcu(&ops->srcu); cleanup_srcu_struct(&ops->srcu); base-commit: 54518e0e827f4ca9229ae657022c60bf60f5c1bf -- 2.53.0