From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92BFF4534A4 for ; Wed, 30 Sep 2026 07:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790752761; cv=none; b=IfadDTjuQLLMqP1DZqKLoQEWYk2YeyU6u6ydddGPY8/BYv2+tluFrJpcV8Tnyl+H3vIfOB/YoVAX7enQz74o0Knrur2r48K/K43hzLcmmf4a+l12xaEG59miIC6DirEjWZu333ikYiuiLSe7R4TKiLY0F3xoYNbgDmivN9ykbWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790752761; c=relaxed/simple; bh=Mk3fSgu7F2inklm698FGg8xtY/UC1g+hSJQWE9hH+Ug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R36LowUZ/UMAs6o53BonKQoMWHfoJ8avSZiimB8QhXsk+OsC1lY91yIkfhgKEW7V9A6JbrPQwxQ8O8vH7wk97HbXoxiKOqxn+UtqegI+6wctFghs3meyZZHW0Q3KY0sV6aZIT8EpR9jjDl4i7sylP5R9jE7t5aX7LSu/828jNH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UzbYtH1d; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UzbYtH1d" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-396ccc02279so2755405a91.1 for ; Wed, 30 Sep 2026 00:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790752758; x=1791357558; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WltmE4hNoTkSsXOgrdp6cz7c6fyzqTtuC0otv1UOPu0=; b=UzbYtH1dZCN/HkS5X3zoEr4N+uW/lLothGzegW2FQPc5f7qcZHPMJz0G51aO6viD6O Z6uO1/E33sCnV7o208ZZvrdx4zFkW+MX7dYryt4ehNESaWmsvYEqmVwk0TLdMPTos2XY U7KSrPPYJ23YOP8uG6UKGMQG6uO2WuIWWsKBySYbqahS4z0YrMfOWtdGWiPXuubl8EBR HsHO+VCCLnAyZUYx6PhCF3JD0NyOukqfn9URb/haP3NUDEksCD1GXVK7tJD5kyI0Rp1i hTs0au9z0QcZYRwSJ8QmyW/MzF7lprhFX9AuqWtaEV8L5h7yZlZq8qPGIuCbRbxqJKLH 1efA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790752758; x=1791357558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=WltmE4hNoTkSsXOgrdp6cz7c6fyzqTtuC0otv1UOPu0=; b=0aviYhL/UCUTKPWP/tak/x+kPD8VnkOkl4NxoNr7Hf4oF2yNxGFy0y6mTUAEoEDEeV vbdeQXUVOZ4TdJestf11H8mWD2v/azE6BIY+k0Ga+gBVIqE9KAo+/Kh6tGDtZ9QgE4eq zS1YWqtRjHRgfz9XmEC4PxOkyC2a0PdajyTgEbhYUUs9EE3Emqqer/DbGa2FyGJNQMDI lPvOrkE2s20uQecXPibmdt2kt1XDB7+mrYy3rebIrFM53u4wN9RVgyBTnxongBxiJ1HA EvBuJQc+pDhQ9Tf62YMliWEN3x3VGm5cCmpgy10ETpzqS/dGRNORR0+TBs3EZmvTp5hj tZEQ== X-Forwarded-Encrypted: i=1; AKwUvBzJkADasK9ddBET+3UTn4fqWl0WtEz1cmfrcn7O59bMFK14wJ3dmV54AS71Wdaurvi9MNUJ6Hw=@vger.kernel.org X-Gm-Message-State: AFq9FYKLYm72qE1xf0gEDg+xh8YknLvEluIt/P+dEjddWTVIPLvC7J7e W+VE7Yj7KP7S1Zg6eGqLZ1W2QPYf0S+F7toCGX4hibjU6pdAO3SxtbcQ X-Gm-Gg: AYBFou1vKHKhbYXTR3x8rc52Mmiu4T8ypz/qsQE5euwVIedZSC8t+zjdI/1QFJb2m/M K4d2rFfpjF9BU4mTkIXSE4RZRGBr/2VTiwxCXTOlmtkVhU1cQrznY57t4esBzvtabdj/fJRjfMX 1PEYas4KhG+DPhxa5Tju7vEKP5uhBJsBpxAjTOfFqDujoPNjfnauTdjHIWgkE3ovUhwlL2JB+bo rQIL3/LohnV3/vikwDJkJA4GuvyO8MCYkP3Q7KryNpbxwar4zJZHOyubOc9iVDexyc382+3Obuv xglAE4biKwFYJZixbScdy71TSVZ/1vFw1oqx/v0Q90uJESCJ6BhUdqgALdZQ+dCqYZAzstJalr8 UBsv/mXYAB4wa33DPlxdeBEC7woGiaTO+Q0wYKQbYGkytQAsPVctP+e9JXbZf4DQvOPuONlUhl5 8Ip6MD5tiUFSzwF+wN5xLDsUFtuXyXCLAy0Ib4+heE9xT9K6AhYvegblTYsAg+KPaM0MILE2+ts +OaeZJVKdhm3f1hdOmwV1nUOj2KFd52q/UJMVU9j6fnyUSyjKRSqk9MCMPsPNOUswHf/14x6gO5 Y+SDvnHcsg== X-Received: by 2002:a17:90b:2c88:b0:39d:f6a6:60d8 with SMTP id 98e67ed59e1d1-3a4d102d649mr439330a91.3.1790752758281; Wed, 30 Sep 2026 00:19:18 -0700 (PDT) Received: from phui-2.c.googlers.com.com (25.187.82.34.bc.googleusercontent.com. [34.82.187.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a4caec0f28sm2256687a91.17.2026.09.30.00.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 00:19:17 -0700 (PDT) From: Hui Peng To: Harry Morris , Alexander Aring , Miquel Raynal , Stefan Schmidt Cc: David Laight , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hui Peng Subject: [PATCH net v3 3/3] ieee802154: ca8210: validate data_ind length upfront in ca8210_skb_rx() Date: Wed, 30 Sep 2026 07:19:14 +0000 Message-ID: <20260930071914.421586-4-benquike@gmail.com> X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog In-Reply-To: <20260930071914.421586-1-benquike@gmail.com> References: <20260930071914.421586-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In ca8210_skb_rx(), data_ind is read at offsets 22 (msdulen), 23 (mpdulinkquality), 29 + msdulen (hdr.sec.level), 30..39 + msdulen (security header), and 29 .. 29 + msdulen (payload) without verifying that the received SPI frame length len covers those offsets, causing an out-of-bounds read when msdulen exceeds len - 30: BUG: KASAN: slab-out-of-bounds in ca8210_skb_rx.constprop.0.isra.0+0x137/0x160 Read of size 64 at addr ffff888006453ddd by task init/1 Call Trace: dump_stack_lvl+0x70/0xa0 print_report+0x153/0x4c6 kasan_report+0xf1/0x120 kasan_check_range+0x125/0x200 __asan_memcpy+0x23/0x60 ca8210_skb_rx.constprop.0.isra.0+0x137/0x160 ca8210_net_rx+0x96/0xc0 ... The buggy address belongs to the object at ffff888006453dc0 which belongs to the cache kmalloc-32 of size 32 The buggy address is located 29 bytes inside of allocated 32-byte region [ffff888006453dc0, ffff888006453de0) Consolidate all length and msdulen validations into a single upfront check at the beginning of ca8210_skb_rx() before allocating the skb. Tested in QEMU with KASAN enabled by passing a short data_ind buffer with msdulen = 64 and len = 30 into ca8210_skb_rx(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v3: - No changes. Changes in v2: - Split out as patch 3/3. - Consolidated all length checks in ca8210_skb_rx() into a single place at the beginning of the function before dev_alloc_skb() and dropped the unrelated hdr.seq assignment as requested by Miquel Raynal. drivers/net/ieee802154/ca8210.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 8aa7ffe..ab245ad 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -1758,19 +1758,15 @@ static int ca8210_skb_rx( u8 *data_ind ) { - struct ieee802154_hdr hdr; + struct ieee802154_hdr hdr = { }; int msdulen; int hlen; - u8 mpdulinkquality = data_ind[23]; + u8 mpdulinkquality; struct sk_buff *skb; struct ca8210_priv *priv = hw->priv; - /* Allocate mtu size buffer for every rx packet */ - skb = dev_alloc_skb(IEEE802154_MTU + sizeof(hdr)); - if (!skb) - return -ENOMEM; - - skb_reserve(skb, sizeof(hdr)); + if (len < 30) + return -EMSGSIZE; msdulen = data_ind[22]; /* msdu_length */ if (msdulen > IEEE802154_MTU) { @@ -1778,9 +1774,25 @@ static int ca8210_skb_rx( &priv->spi->dev, "received erroneously large msdu length!\n" ); - kfree_skb(skb); return -EMSGSIZE; } + + if (len < 30 + msdulen || + (!priv->promiscuous && data_ind[29 + msdulen] > 0 && + len < 29 + msdulen + sizeof(struct secspec))) { + dev_err(&priv->spi->dev, + "received truncated data indication!\n"); + return -EMSGSIZE; + } + + mpdulinkquality = data_ind[23]; + + /* Allocate mtu size buffer for every rx packet */ + skb = dev_alloc_skb(IEEE802154_MTU + sizeof(hdr)); + if (!skb) + return -ENOMEM; + + skb_reserve(skb, sizeof(hdr)); dev_dbg(&priv->spi->dev, "skb buffer length = %d\n", msdulen); if (priv->promiscuous)