From: Jakub Kicinski <kuba@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, "(JC),
Jayachandran" <j-rameshbabu@ti.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Chintan Vankar <c-vankar@ti.com>,
Danish Anwar <danishanwar@ti.com>, Daolin Qiu <d-qiu@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Felix Maurer <fmaurer@redhat.com>,
Neelima Muralidharan <neelima@ti.com>,
Paolo Abeni <pabeni@redhat.com>,
Praneeth Bajjuri <praneeth@ti.com>,
Pratheesh Gangadhar TK <pratheesh@ti.com>,
Richard Cochran <richardcochran@gmail.com>,
Simon Horman <horms@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next v7 3/8] hsr: Add a magic header for sending PTP packets
Date: Thu, 1 Oct 2026 18:44:27 -0700 [thread overview]
Message-ID: <20261001184427.4060c29e@kernel.org> (raw)
In-Reply-To: <20260928-hsr_ptp-v7-3-d55d304d9a7e@linutronix.de>
On Mon, 28 Sep 2026 14:39:37 +0200 Sebastian Andrzej Siewior wrote:
> Sending PTP packets (ETH_P_1588) via the HSR stack is pointless in its
> current shape because the requested PTP timestamp is not routed to the
> sender. It also needs to be distinguished on which port the message
> should be sent and whether or not a HSR header should be attached.
>
> To pass this information, a custom header (struct hsr_inline_header) is
> introduced. This header is expected and mandatory if the ether type is
> ETH_P_1588. To avoid any wrong usage, there is a magic field to ensure
> it really is the header.
>
> The inline header is just prepended containing the port and header
> parameter. After the header, a regular packet follows. It is ensured that
> the inline header and the following ethernet or HSR header is linear
> and can be accessed.
>
> The two retrieved parameters are passed to hsr_forward_skb() and will be
> used later.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
breaks build (admittedly in a weird way, some header check thing?):
In file included from <built-in>:1:
./usr/include/linux/hsr_ptp.h:10:2: error: unknown type name 'uint8_t'
10 | uint8_t tx_port;
| ^
./usr/include/linux/hsr_ptp.h:11:2: error: unknown type name 'uint8_t'
11 | uint8_t hsr_hdr;
| ^
./usr/include/linux/hsr_ptp.h:12:2: error: unknown type name 'uint8_t'
12 | uint8_t __pad0[4];
| ^
./usr/include/linux/hsr_ptp.h:13:2: error: unknown type name '__be32'
13 | __be32 magic;
| ^
./usr/include/linux/hsr_ptp.h:14:2: error: unknown type name 'uint8_t'
14 | uint8_t __pad1[2];
| ^
./usr/include/linux/hsr_ptp.h:15:2: error: unknown type name '__be16'
15 | __be16 eth_type;
| ^
--
pw-bot: cr
next prev parent reply other threads:[~2026-10-02 1:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 12:39 [PATCH net-next v7 0/8] hsr: Add additional info to send/ receive skbs Sebastian Andrzej Siewior
2026-09-28 12:39 ` [PATCH net-next v7 1/8] hsr: Add header_ops::parse_protocol Sebastian Andrzej Siewior
2026-09-28 12:39 ` [PATCH net-next v7 2/8] hsr: Use skb_clone() while adding the HSR header Sebastian Andrzej Siewior
2026-09-28 12:39 ` [PATCH net-next v7 3/8] hsr: Add a magic header for sending PTP packets Sebastian Andrzej Siewior
2026-10-02 1:44 ` Jakub Kicinski [this message]
2026-09-28 12:39 ` [PATCH net-next v7 4/8] hsr: Drop received " Sebastian Andrzej Siewior
2026-09-28 12:39 ` [PATCH net-next v7 5/8] hsr: Use the port and header information in hsr_forward_skb() Sebastian Andrzej Siewior
2026-09-28 12:39 ` [PATCH net-next v7 6/8] hsr: Assign a socket for cloned skbs Sebastian Andrzej Siewior
2026-09-28 12:39 ` [PATCH net-next v7 7/8] hsr: Move struct hsr_ethhdr to a global header Sebastian Andrzej Siewior
2026-09-28 12:39 ` [PATCH net-next v7 8/8] selftests: hsr: Add test for the inline PTP header on HSR Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001184427.4060c29e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=c-vankar@ti.com \
--cc=d-qiu@ti.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=j-rameshbabu@ti.com \
--cc=neelima@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=richardcochran@gmail.com \
--cc=vigneshr@ti.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox