From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D8384E01F6 for ; Thu, 1 Oct 2026 22:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790894462; cv=none; b=rQOUaLGKR7mwFofCV6FALA9n0YtZ+xg97JP/9O0LYTRGVpt+rbsaKX8xcpXeUYedVWBx6OXBWpH83mNb+S0Pw5j4TpOzaxCrrrcMYKViZaRhwEQMfP+a97R5FrHGfwxYnkPBwPrFjDLX4UpITNphYTP7HXCrmH9KjPm3M9kBM8E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790894462; c=relaxed/simple; bh=fjDLJXf1aBRrmidaC6jhH7WSJg2DvCL/+cPSF0ggzWc=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=eDiZvM5ZrxLkgzlPJYSNJ5q4Ah4BhXej4Qquvd38+fH4JpBHAJBkJzQCTppP2S3JdogiE0n/R2kD6uxFnHklYj72fX52R0sFJZS44SWkBWV9ca/QB34q5Ept6bjvCbI0SOZi27kI1Dw71kX3VIvVBcsZB9V5XMXFkDrr4P2V+/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--kaifengw.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=WtVw6cwf; arc=none smtp.client-ip=74.125.82.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--kaifengw.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WtVw6cwf" Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-33c35f5ca6cso5464187eec.1 for ; Thu, 01 Oct 2026 15:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790894460; x=1791499260; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:mime-version:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9IdYN9g8a9lzzHIhtoJFBJ2axTedpkyHbETAT+gfXfQ=; b=WtVw6cwfE/NJY0c742R84MAG/+OZxR0GVUPV9BIEUTfLtdT4jZHV7Ai5+3I+BNKcAe CpCLWLNG8369PsoUfDap5C2N0tQu6Za/WvM+itMioycF2y6Pf7H5nO43YzVPQdJmVwYD Ycf7YCsKAMjqc9f/rOuRoJfrrz/LBOJ7bgjNHUOXDmj7gS+2c4wIweR+XjazUFKWyS/Z qrKswlcMOeG+RbgnwdCyKqg8W0j5FRg+i4fFmIB2a3iqRf4s9ZzmubxMpsSvUYT1t6kv /7Ev5Dcmq0KN/wWG7muMVHsSFGnzZTbhTAS4HqgbRECYM/bqok9QG8g7oLn8uxiGVcIA 619g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790894460; x=1791499260; h=content-type:cc:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9IdYN9g8a9lzzHIhtoJFBJ2axTedpkyHbETAT+gfXfQ=; b=H5zUsVlLOp3I5r3AkM4zaBFacxhHHud+PcA5OaTTiZPGHDGwylu0YbyaGq7yOxlZtf jA6BNumeKw6h0h5s2jdjDR2BBeE6PlQ4dSzp+gQbwOe7NU/37qptpyWUYtk0F5WpPpGD nxWxrErJrQ6beXIcw4pfPrz0b9iJRFjRqufb3YKa72+sE/W1P8rOBcAovh/eN3n9ZGsf ydc3KzAc42sxZbv6T854sElGQ1TE5fxzlJnEpzqYuwPI7fEzc/t6OrCejHo0pEmW2C/X ss9bnH3Y9QVDUFpZEIFRSw+/GZXO5Zs7pqrhZixCeOtpV0igQVlmCsp4cIFFT2IvAFb9 sYIQ== X-Gm-Message-State: AFuF++nwziIPljFIxS91wND92/6HYIEcjqh6kkaWNenwG1jlj7UJ2nLI 0YGLpMrKmH2RdwN4G6e2/DAQxGQEC5IYkj9duPJe1d+kfXtRuw1fy6lOUCipXU0X0LUW1368ne+ GlFijlrzZg4N4te+kgj98AcPlL0q/ViDcC24BiW9CMdgIlAMK1egDf29TcRegx2bbaQYx4+5zb+ HxigXqIhDHmJ6OJsBk87tabc/jO3tMphi9pko1OcwWH/lN90c= X-Received: from dlev27.prod.google.com ([2002:a05:701b:465b:b0:14f:4bfa:b7da]) (user=kaifengw job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7023:88d:b0:144:e246:a0b2 with SMTP id a92af1059eb24-14f5d6b6427mr805233c88.44.1790894459517; Thu, 01 Oct 2026 15:40:59 -0700 (PDT) Date: Thu, 1 Oct 2026 22:40:54 +0000 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog Message-ID: <20261001224054.1525365-1-kaifengw@google.com> Subject: [PATCH net-next v2] net: devmem: use page_pool_put_netmem_bulk From: Kaifeng Wang To: netdev@vger.kernel.org Cc: almasrymina@google.com, edumazet@google.com, kuniyu@google.com, pabeni@redhat.com, willemb@google.com, davem@davemloft.net, kuba@kernel.org, horms@kernel.org, sdf@fomichev.me, linux-kernel@vger.kernel.org, Kaifeng Wang Content-Type: text/plain; charset="UTF-8" Instead of looping over napi_pp_put_page() and repeatedly acquiring the page_pool producer lock in sock_devmem_dontneed(), use page_pool_put_netmem_bulk() to return the netmem references in batches. This reduces the number of lock acquisitions on the page pool ring producer lock when releasing user tokens. Reviewed-by: Mina Almasry Acked-by: Stanislav Fomichev Signed-off-by: Kaifeng Wang --- v1 -> v2: - Rebased on net-next after commit bdea4980182e ("net: page_pool: fix use-after-free in page_pool_recycle_ring_bulk()") was merged. - Collected Acked-by: Stanislav Fomichev. net/core/sock.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/net/core/sock.c b/net/core/sock.c index 972c72c5bcc6..157759e7e362 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -129,6 +129,7 @@ #include #include #include +#include #include #include #include @@ -1086,7 +1087,7 @@ static int sock_reserve_memory(struct sock *sk, int bytes) static noinline_for_stack int sock_devmem_dontneed(struct sock *sk, sockptr_t optval, unsigned int optlen) { - unsigned int num_tokens, i, j, k, netmem_num = 0; + unsigned int num_tokens, i, j, netmem_num = 0; struct dmabuf_token *tokens; int ret = 0, num_frags = 0; netmem_ref netmems[16]; @@ -1123,8 +1124,7 @@ sock_devmem_dontneed(struct sock *sk, sockptr_t optval, unsigned int optlen) netmems[netmem_num++] = netmem; if (netmem_num == ARRAY_SIZE(netmems)) { xa_unlock_bh(&sk->sk_user_frags); - for (k = 0; k < netmem_num; k++) - WARN_ON_ONCE(!napi_pp_put_page(netmems[k])); + page_pool_put_netmem_bulk(netmems, ARRAY_SIZE(netmems)); netmem_num = 0; xa_lock_bh(&sk->sk_user_frags); } @@ -1134,8 +1134,7 @@ sock_devmem_dontneed(struct sock *sk, sockptr_t optval, unsigned int optlen) frag_limit_reached: xa_unlock_bh(&sk->sk_user_frags); - for (k = 0; k < netmem_num; k++) - WARN_ON_ONCE(!napi_pp_put_page(netmems[k])); + page_pool_put_netmem_bulk(netmems, netmem_num); kvfree(tokens); return ret; -- 2.56.0.rc1.315.gc6ed9934b7-goog