From: Simon Horman <horms@kernel.org>
To: Victor Nogueira <victor@mojatatu.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jhs@mojatatu.com, jiri@resnulli.us,
netdev@vger.kernel.org, Eric Dumazet <edumazet@kernel.org>,
hybris <hybris@mojatatu.ai>, Sashiko <sashiko-bot@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net 2/2] selftests: tc-testing: add cls_route no-routing-attribute change tests
Date: Fri, 2 Oct 2026 17:56:59 +0100 [thread overview]
Message-ID: <20261002165659.GK13925@horms.kernel.org> (raw)
In-Reply-To: <QDISC-0JB3.v1.20260923100921@mojatatu.com.2>
On Thu, Oct 01, 2026 at 12:32:01PM -0300, Victor Nogueira wrote:
> Add a boundary pair for route4 change without a routing attribute:
>
> - a classid-only change of a wildcard filter (handle 0xffff8000) is a
> metadata-only update and must succeed;
> - the same change on a non-wildcard handle (0x10001) would rekey the
> filter to the wildcard bucket, leaving the handle userspace stored stale,
> and must be rejected with -EINVAL.
>
> The change of a wildcard filter is the flow iproute2 uses by default
> ("tc filter add ... route classid X:Y" gives handle 0xffff8000).
>
> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Victor Nogueira <victor@mojatatu.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-10-02 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 15:32 [PATCH net 1/2] net/sched: cls_route: reject change with no routing attribute Victor Nogueira
2026-10-01 15:32 ` [PATCH net 2/2] selftests: tc-testing: add cls_route no-routing-attribute change tests Victor Nogueira
2026-10-02 16:56 ` Simon Horman [this message]
2026-10-02 16:56 ` [PATCH net 1/2] net/sched: cls_route: reject change with no routing attribute Simon Horman
2026-10-07 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002165659.GK13925@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=edumazet@kernel.org \
--cc=hybris@mojatatu.ai \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashiko-bot@kernel.org \
--cc=shuah@kernel.org \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox