From: Kuniyuki Iwashima <kuniyu@google.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>
Cc: Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: [PATCH v2 net-next 0/9] neighbour: Add IPv4/IPv6-specific wrappers for neigh_lookup() and friends.
Date: Sat, 3 Oct 2026 21:23:13 +0000 [thread overview]
Message-ID: <20261003212336.1304988-1-kuniyu@google.com> (raw)
syzbot reported that ip6_finish_output2() could pass tbl and dev
from different netns to neigh_create().
When namespacifying neigh_table, I chose to resolve neigh_table
in callers to minimise changes, but it turned out to be error-prone.
This series adds IPv4/IPv6-specific helpers for neigh_lookup()
and neigh_create() that always fetch the netns from dev to fix
the problem.
Along the way, the confusing and now mostly redundant helpers
__neigh_lookup() and __neigh_lookup_errno() are converted and
removed.
Changes:
v2:
* Add Patch 9
* Patch 6 & 7: Convert __teql_resolve()
v1: https://lore.kernel.org/netdev/20260930200326.718459-1-kuniyu@google.com/
Kuniyuki Iwashima (9):
ipv4: Rename ipv4_neigh_lookup() to ipv4_dst_neigh_lookup().
ipv6: Rename ip6_neigh_lookup() to __ip6_dst_neigh_lookup().
ipv4: Add wrappers for neigh_lookup() and neigh_create().
ipv6: Add wrappers for neigh_lookup() and (__)?neigh_create().
mlxsw: spectrum: Resolve neigh_table right before neigh_lookup().
ipv6: Use ipv6_neigh_lookup() and friends.
ipv4: Use ipv4_neigh_lookup() and friends.
neighbour: Remove __neigh_lookup() and __neigh_lookup_errno().
neighbour: Check n->parms->tbl under tbl->lock in ___neigh_create().
.../marvell/prestera/prestera_router.c | 14 ++--
.../mellanox/mlx5/core/en/tc_tun_encap.c | 14 ++--
.../mellanox/mlx5/core/en_accel/ipsec.c | 6 +-
.../ethernet/mellanox/mlxsw/spectrum_router.c | 77 +++++++++++--------
.../ethernet/mellanox/mlxsw/spectrum_span.c | 42 ++++++----
.../netronome/nfp/flower/tunnel_conf.c | 8 +-
drivers/net/ethernet/rocker/rocker_ofdpa.c | 2 +-
drivers/net/ethernet/sfc/tc_counters.c | 11 +--
drivers/net/vrf.c | 4 +-
drivers/net/vxlan/vxlan_core.c | 14 +---
include/net/arp.h | 16 ++++
include/net/ip6_route.h | 6 +-
include/net/ndisc.h | 31 ++++++--
include/net/neighbour.h | 24 ------
net/bridge/br_arp_nd_proxy.c | 4 +-
net/core/neighbour.c | 11 ++-
net/ieee802154/6lowpan/tx.c | 3 +-
net/ipv4/arp.c | 26 ++++---
net/ipv4/fib_semantics.c | 5 +-
net/ipv4/route.c | 18 ++---
net/ipv6/ip6_output.c | 2 +-
net/ipv6/ndisc.c | 48 +++++++-----
net/ipv6/route.c | 23 +++---
net/sched/sch_teql.c | 15 +++-
24 files changed, 234 insertions(+), 190 deletions(-)
--
2.56.0.rc1.315.gc6ed9934b7-goog
next reply other threads:[~2026-10-03 21:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 21:23 Kuniyuki Iwashima [this message]
2026-10-03 21:23 ` [PATCH v2 net-next 1/9] ipv4: Rename ipv4_neigh_lookup() to ipv4_dst_neigh_lookup() Kuniyuki Iwashima
2026-10-03 21:23 ` [PATCH v2 net-next 2/9] ipv6: Rename ip6_neigh_lookup() to __ip6_dst_neigh_lookup() Kuniyuki Iwashima
2026-10-03 21:23 ` [PATCH v2 net-next 3/9] ipv4: Add wrappers for neigh_lookup() and neigh_create() Kuniyuki Iwashima
2026-10-03 21:23 ` [PATCH v2 net-next 4/9] ipv6: Add wrappers for neigh_lookup() and (__)?neigh_create() Kuniyuki Iwashima
2026-10-03 21:23 ` [PATCH v2 net-next 5/9] mlxsw: spectrum: Resolve neigh_table right before neigh_lookup() Kuniyuki Iwashima
2026-10-03 21:23 ` [PATCH v2 net-next 6/9] ipv6: Use ipv6_neigh_lookup() and friends Kuniyuki Iwashima
2026-10-06 17:53 ` Fernando Fernandez Mancera
2026-10-06 18:01 ` Kuniyuki Iwashima
2026-10-06 20:34 ` Fernando Fernandez Mancera
2026-10-03 21:23 ` [PATCH v2 net-next 7/9] ipv4: Use ipv4_neigh_lookup() " Kuniyuki Iwashima
2026-10-03 21:23 ` [PATCH v2 net-next 8/9] neighbour: Remove __neigh_lookup() and __neigh_lookup_errno() Kuniyuki Iwashima
2026-10-03 21:23 ` [PATCH v2 net-next 9/9] neighbour: Check n->parms->tbl under tbl->lock in ___neigh_create() Kuniyuki Iwashima
2026-10-06 20:39 ` [PATCH v2 net-next 0/9] neighbour: Add IPv4/IPv6-specific wrappers for neigh_lookup() and friends Fernando Fernandez Mancera
2026-10-07 16:35 ` Jakub Kicinski
2026-10-07 16:50 ` Ido Schimmel
2026-10-07 18:20 ` Jakub Kicinski
2026-10-07 23:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003212336.1304988-1-kuniyu@google.com \
--to=kuniyu@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox