From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0500D30F526 for ; Mon, 5 Oct 2026 04:38:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791175124; cv=none; b=W4YQ5n6R4NY8NmeR5obQn/x5deVh483pIeUdeFBTWgz91bDNeF7F6BYTc/+z30C5yrZTWT5/9nYLB4IXPuGGFDSfLmxKU2vdjX4JBfpq/QW59EjkW8HpTm8lQe/93I8WxCSyWw3zS4o86B5qe/T4kvBupqRFSgCJFkwqaKRZ2lE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791175124; c=relaxed/simple; bh=tWTj7sa3HSz20eoE7iU48Ov4FXB/O8yPqTq5z9H7G1k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a47/JKV9K64y18YA+hn+djUfQiscuJmvoCBWjz+o5mwGXuzjPHRiUnazMgcPI/guNqTC2iBlaM+RjGKdJVo0hkfdodHeTYiYYYqzMD3MASeacA4QxH7NbbzP1B2sJSsucj6U6bNZvxB1vIjMVBBXvaa9+an8Ljqo5CGaOeX6Gsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XdslmGSS; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XdslmGSS" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-35120d43ecaso1724574eec.1 for ; Sun, 04 Oct 2026 21:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791175121; x=1791779921; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=miahjqq1TAdqXeL2Jl7n/7P9i8eCMUOcl23EpJEiCcg=; b=XdslmGSSApT2rUjiLLE9V2Dk0Uuk/ft4cBuHN8IAjvkOlljmYe/p9ZbaFCc8YmqQ2M kOu02vLIrcy07Zno1yPc5ocb/lOCf8HwHR/aHAFaU9eGe4HZZWfK5NjzUjLu9t161BFA fTO9pKaK32LdHt3OJ+v8DQgI30E0iC8JAV3ujMywBydMFOHapj/7WKqxHCE4DEcLQNiu aRVu0Uafp7HMid2OM5ccxKuwN2k2gAfKT9o4t34fgEvJvqZZCrPDvubNpI1lkJjQZOsr Zav0Xc9GuuRSjnR+yo7XpuPVHQq5yJ+7asEl6bk9TVq2OZ0NIXL8vJejETf53VnnltZd WQrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791175121; x=1791779921; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=miahjqq1TAdqXeL2Jl7n/7P9i8eCMUOcl23EpJEiCcg=; b=KBSnycEpLZUsYTlZ/oLy9fB1bhBZB+PONZfj6QBTrt+9/keYtT6UyiUBUyhE6vX+Da ja0/Q7VhvEIY2SdiZdukcd2v/xGDXNq2G1jf/h7lLDfwNadpU4rmAcVa/S3Z4quEFgmB Gfw8QPEfiVgHh8WDphkJRrgh4ODHU/2Ewks35IMLynMpVZmfwYwPFSegI6i+ahIc0wqi JD9C2wAF3gDY7zUvIPFlMs27yv2ShScv+ZfcPBMyN1QeVE5skzqcuX2GvckQ9k0wlg7G xBxFOBVdYjsSrHIsBHspYICSd8KwnwXLUK+WWFDtetSI3OL8o72ArgPldQGiq6Vi0a+U Pnrw== X-Gm-Message-State: AFuF++nkmmzfR5L/29lRs8BfTOTIMdc+71L3RuNfiOB74tMOvlT42tsu 49oMqqsQgttFW1koHSIY0QntN51bxLhJ/vw57y9VVozcZVWDkd7CE+SEPNYLs/e5 X-Gm-Gg: AYBFou0dkcODUjwhRqZraZ54AKXjQFz9q7S0iQdJC5vb7b57VDoa0OiqKqsQuJNLShe VdPZlH6m0fQKsl9wJVUbqGq3oVxkIiO7Xf88FqJ5TEHkyU/cFzNu2p4u7ssTj8feOblc8Swe0Ww CGiXMS6rL50cOo1wMcoBv+K3KBe4VQ4+h4mtF3uD6doRn/OqP8WjwcZ2bzEq5VPAPk/zhI4J7ao cFYuk3az/fo7b68IjvF7s98sMUJdL2fZL9xK3ht8DDBM+CaVThgZ93fPLys5wkFE+LRMGpoDmay 3dq8AYHJNglzl17U8ySlpng7kDBWaYN8Z9FQQIFUUO2EhyA3fMg+K4M5ilJwy7voVnn6t5Dw7GL iwIMdg8NsFRKwytP4Cto/X522D0/LUpdvWz8RXH8QzXgjghKvWXrqMj4dJRs9ENYxFeKk8t9C3y Qurd0bFOArUeDhV1OWelCbh1P3qFS1qkoioXhwAu4nYyxsa4+wV6hLi2Iw5JSPQbGUcNSC1+sbq y7ZzPc= X-Received: by 2002:a05:7300:f801:b0:34c:b75a:ac1e with SMTP id 5a478bee46e88-3511150f264mr9866587eec.33.1791175121098; Sun, 04 Oct 2026 21:38:41 -0700 (PDT) Received: from vscode-11-19.w453y.xyz ([59.164.88.43]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-35127136b8esm9518581eec.6.2026.10.04.21.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2026 21:38:40 -0700 (PDT) From: Abdul Wasey To: netdev@vger.kernel.org Cc: razor@blackwall.org, idosch@nvidia.com, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, horatiu.vultur@microchip.com, bridge@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 3/3] net: bridge: cfm: notify userspace on CFM config changes Date: Mon, 5 Oct 2026 04:38:22 +0000 Message-ID: <20261005043822.3106580-4-w453y.me@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261005043822.3106580-1-w453y.me@gmail.com> References: <20261005043822.3106580-1-w453y.me@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit CFM status changes are sent to userspace by br_cfm_notify(), but config changes are not. br_afspec() calls br_cfm_parse() without the "changed" pointer, so creating a MEP, adding a peer or starting CCM transmission never sends an RTM_NEWLINK. Today the only way to see these changes is to poll RTM_GETLINK with RTEXT_FILTER_CFM_CONFIG. Send one RTM_NEWLINK with RTEXT_FILTER_CFM_CONFIG from br_cfm_parse() once any group in the request has been applied. If a later group in the same request fails, still send it, since the earlier groups already changed the config. br_ifinfo_notify() is not used because it asks for RTEXT_FILTER_BRVLAN_COMPRESSED, so the message would not carry the CFM attributes. This calls br_info_notify() the same way br_cfm_notify() does for status. Signed-off-by: Abdul Wasey --- net/bridge/br_cfm_netlink.c | 32 +++++++++++++++++++++++--------- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/net/bridge/br_cfm_netlink.c b/net/bridge/br_cfm_netlink.c index 91b9922dc..56309e6f4 100644 --- a/net/bridge/br_cfm_netlink.c +++ b/net/bridge/br_cfm_netlink.c @@ -382,6 +382,7 @@ int br_cfm_parse(struct net_bridge *br, struct net_bridge_port *p, struct nlattr *attr, int cmd, struct netlink_ext_ack *extack) { struct nlattr *tb[IFLA_BRIDGE_CFM_MAX + 1]; + bool changed = false; int err; /* When this function is called for a port then the br pointer is @@ -399,59 +400,72 @@ int br_cfm_parse(struct net_bridge *br, struct net_bridge_port *p, err = br_mep_create_parse(br, tb[IFLA_BRIDGE_CFM_MEP_CREATE], extack); if (err) - return err; + goto out; + changed = true; } if (tb[IFLA_BRIDGE_CFM_MEP_DELETE]) { err = br_mep_delete_parse(br, tb[IFLA_BRIDGE_CFM_MEP_DELETE], extack); if (err) - return err; + goto out; + changed = true; } if (tb[IFLA_BRIDGE_CFM_MEP_CONFIG]) { err = br_mep_config_parse(br, tb[IFLA_BRIDGE_CFM_MEP_CONFIG], extack); if (err) - return err; + goto out; + changed = true; } if (tb[IFLA_BRIDGE_CFM_CC_CONFIG]) { err = br_cc_config_parse(br, tb[IFLA_BRIDGE_CFM_CC_CONFIG], extack); if (err) - return err; + goto out; + changed = true; } if (tb[IFLA_BRIDGE_CFM_CC_PEER_MEP_ADD]) { err = br_cc_peer_mep_add_parse(br, tb[IFLA_BRIDGE_CFM_CC_PEER_MEP_ADD], extack); if (err) - return err; + goto out; + changed = true; } if (tb[IFLA_BRIDGE_CFM_CC_PEER_MEP_REMOVE]) { err = br_cc_peer_mep_remove_parse(br, tb[IFLA_BRIDGE_CFM_CC_PEER_MEP_REMOVE], extack); if (err) - return err; + goto out; + changed = true; } if (tb[IFLA_BRIDGE_CFM_CC_RDI]) { err = br_cc_rdi_parse(br, tb[IFLA_BRIDGE_CFM_CC_RDI], extack); if (err) - return err; + goto out; + changed = true; } if (tb[IFLA_BRIDGE_CFM_CC_CCM_TX]) { err = br_cc_ccm_tx_parse(br, tb[IFLA_BRIDGE_CFM_CC_CCM_TX], extack); if (err) - return err; + goto out; + changed = true; } - return 0; +out: + /* Earlier groups may have been applied even if a later one failed */ + if (changed) + br_info_notify(RTM_NEWLINK, br, NULL, RTEXT_FILTER_CFM_CONFIG); + + return err; } int br_cfm_config_fill_info(struct sk_buff *skb, struct net_bridge *br) -- 2.53.0