From: Jakub Kicinski <kuba@kernel.org>
To: Naman Gulati <namangulati@google.com>
Cc: netdev-bot+sashiko@kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, bigeasy@linutronix.de, kuniyu@google.com,
syzbot+f0661448aa9511ce744a@syzkaller.appspotmail.com
Subject: Re: [PATCH net v2] net: gro_cells: prevent enabling threaded NAPI on gro_cells
Date: Mon, 5 Oct 2026 18:15:32 -0700 [thread overview]
Message-ID: <20261005181532.49d699bd@kernel.org> (raw)
In-Reply-To: <CAMP57yU6Ghd4AG266kETfq1-o0n86ufRA6+ucZtnMO63YGXfog@mail.gmail.com>
On Thu, 1 Oct 2026 18:34:31 -0700 Naman Gulati wrote:
> This and the below finding both stem from not being able to set
> threaded = 0. I missed handling this. Wireguard setting threaded napi
> by default along with NAPI_STATE_NO_BUSY_POLL deffinitely complicates
> this further. It might become an overengineered fix to tighten the
> loose sysfs interface when netlink already provides stricter control.
> It may be a better to just update the gro_cells documentation to state
> that it does not support threaded napis. May respin accordingly if I
> cannot find a clean way to tighten this interface.
Ugh. Alright, thanks for trying, seems we have to return to v1-ish
approach. Please name the flag PERCPU or something like that.
prev parent reply other threads:[~2026-10-06 1:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 1:00 [PATCH net v2] net: gro_cells: prevent enabling threaded NAPI on gro_cells Naman Gulati
2026-10-02 1:03 ` netdev-bot+sashiko
2026-10-02 1:34 ` Naman Gulati
2026-10-06 1:15 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005181532.49d699bd@kernel.org \
--to=kuba@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=namangulati@google.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+f0661448aa9511ce744a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox