From: Jakub Kicinski <kuba@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: netdev-bot+sinfo@kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, edumazet@kernel.org, davem@davemloft.net,
andrew+netdev@lunn.ch, bcm-kernel-feedback-list@broadcom.com,
nb@tipi-net.de, florian.fainelli@broadcom.com, opendmb@gmail.com
Subject: Re: [PATCH net v2] net: bcmgenet: if UMAC was suspended in SW_RESET, restore it to SW_RESET
Date: Mon, 5 Oct 2026 18:27:21 -0700 [thread overview]
Message-ID: <20261005182721.776af8b8@kernel.org> (raw)
In-Reply-To: <897ffc5a-48ad-4516-89f2-0cdac082d7a8@broadcom.com>
On Fri, 2 Oct 2026 09:16:15 -0700 Justin Chen wrote:
> On 10/1/2026 6:41 PM, Jakub Kicinski wrote:
> > On Wed, 30 Sep 2026 23:08:43 +0000 netdev-bot+sinfo@kernel.org wrote:
> >> Hi!
> >>
> >> This is an automated message. This series looks like a fix, but its
> >> commit messages seem to be missing some information:
> >>
> >> - How the issue was discovered, e.g. hit in production, hit during
> >> development, syzbot report, manual code inspection, LLM or static
> >> analysis tool scan.
> >>
> >> - Whether the issue was actually triggered, or is only theoretical
> >> (e.g. found by code inspection). If it was triggered please include
> >> the symptoms, like the stack trace or error messages.
> >>
> >> - What hardware the change was tested on. For driver fixes please
> >> mention the device (and if relevant firmware version) used for
> >> testing, or say that the change was not tested on real hardware.
> >>
> >> Please do not repost the series just to address the above. Instead,
> >> reply to this email with the missing information, so that reviewers
> >> can take it into account. If the series needs another revision for
> >> other reasons, please include the information in the commit messages
> >> then.
> >>
> >> The evaluation is done by an LLM so it may be wrong, if you think
> >> that is the case please reply and explain.
> >
> > please respond to this
>
> The issue was hit in production and I verified the sequence keeps the TX
> disabled in my standalone test. I tested on an internal development
> board with bcm77122, but should be reproducible on any genet HW that
> supports power management.
I obviously meant that you should respond to all the fix info requests.
Not just this one in particular.
next prev parent reply other threads:[~2026-10-06 1:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 23:06 [PATCH net v2] net: bcmgenet: if UMAC was suspended in SW_RESET, restore it to SW_RESET Justin Chen
2026-09-30 23:08 ` netdev-bot+sinfo
2026-10-02 1:41 ` Jakub Kicinski
2026-10-02 16:16 ` Justin Chen
2026-10-06 1:27 ` Jakub Kicinski [this message]
2026-10-06 22:29 ` Justin Chen
2026-10-06 22:44 ` Jakub Kicinski
2026-10-06 23:05 ` Justin Chen
2026-10-07 1:38 ` Jakub Kicinski
2026-10-07 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005182721.776af8b8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=nb@tipi-net.de \
--cc=netdev-bot+sinfo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox