From: Igor Velkov <iav@iav.lv>
To: netdev-bot+sashiko@kernel.org
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: stmmac: mask the MAC interrupt while resume resets the MAC
Date: Wed, 7 Oct 2026 06:15:19 +0300 [thread overview]
Message-ID: <20261007031520.3183462-1-iav@iav.lv> (raw)
In-Reply-To: <179126208779.434549.13501536895517522673@kernel.org>
All three are right. v3 disables the line only around stmmac_hw_setup(),
under rtnl_lock() and priv->lock: the reset task takes rtnl too, so it
cannot run between the disable and the enable, and no sharer is held off
through rtnl or the glue resume. If stmmac_hw_setup() fails, v3 masks the
core interrupts before enabling the line. A GMAC_INT_MASK dump on
Helios64 (dwmac-rk) and ODROID-HC4 (dwmac-meson8b) showed the glue resume
leaves the mask intact, so the narrow window is enough there.
pw-bot: cr
prev parent reply other threads:[~2026-10-07 3:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 4:35 [PATCH net v2] net: stmmac: mask the MAC interrupt while resume resets the MAC Igor Velkov
2026-10-02 17:24 ` Igor Velkov
2026-10-06 4:48 ` netdev-bot+sashiko
2026-10-07 3:15 ` Igor Velkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007031520.3183462-1-iav@iav.lv \
--to=iav@iav.lv \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox