From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0CB849250C for ; Wed, 7 Oct 2026 10:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791370164; cv=none; b=JS7irHFamZCytxGy7Oy2TafA/NJwk+QwBUNz/4+0BTnlI+7MdGU1EV9EPPn19CxOJtF/EDw8qZmi2fCqlWckIr4gwdxRQ/irRq9l9vd/6GFThr+cKSdDB6tVxjOdPNjSeZrWC5acOSQnxwnPuHNCBVutdh5a7P+XB7mmVC4IPKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791370164; c=relaxed/simple; bh=RJfVcwb+Mf1Et5d6No58/KYOhnUt758OCcEXbSo1KjI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=p2pGuYKQ/33sa7b2kXMdMHJ2HHjHM7IEd5IJDeMaTi4MwekGYFYb3DsnLmgep6CCKD5Xn7tYRBeNosVr7mKKuPUWd82TiZY2/0Tbf8TN4mmrgvqxVea5ByEPEE049Kb4fIsDen745o/6jpDDDM3mKKm1iXQEBgm0naSaBfLkY3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=reksktsL; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="reksktsL" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-383b4a3755fso2753402a91.3 for ; Wed, 07 Oct 2026 03:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791370108; x=1791974908; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=s10B/UJVDcBcMsipOeAzukFpqn1WWC4fSZ9WIZPc2KU=; b=reksktsLDB6xOyjbBCytV8P+qzZhM7w44a1SiUPC3P5GI0P5AqWCM/iCXUSdNSA8dc Fm9i/W98A70YxDGJYqTQ6XBp2jX5YOtJR3/1NS5IfmU0vUaTc7FfZzd28xbW5f6C1smv O3p87CTZz5erAwsxqzuUahsZ97UL/6HCn+nUaM+jWAZfU3WTK/UugA0QuytQv4CSjE/Q 2C7tuOMnCCF3c/SOWyE2XDkO7+pgkmWXbeDU5xFzmYB5fqovfiwNTU9ct0mAMF59Dk6C EjsaAvNQx09QvMkOiBJOjs421X5xr4aawlCsWOhwkewfwZjMct3Uv0w/DVJBwc6MN+dH lJ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791370108; x=1791974908; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s10B/UJVDcBcMsipOeAzukFpqn1WWC4fSZ9WIZPc2KU=; b=b/0r9hZWMHxcVRGivQ/ldFc5L4xYA2XJrNCIeQYVeDwLq/I+3erEeCv2NGdZ94Wrde tFWyeqZngkLsnIYZ7PyUob5pQot579lWx1Q3grZgiwNX2zuGr5+7gh3MGSCguuesS0xm HBWEPTk7FsI01S6Q7x1e6H/6pi5mH/g3wQaYQcQtK5C+PSHgt1NfFCa3GOKQwzLjHjIK 6rQZlmlvs/Z+PH1Zgn16A2uEwzkOtvIQWaw/oYicq095DOlwkd3+nq27mtGopQFM6bZ3 O3vw5DdOJQZwnNAmmwc2b/pLLLPgjMzUf4BYPkctVa0HtgfiydYjRFmnp7O5r28E7Ywi Wc8g== X-Forwarded-Encrypted: i=1; AKwUvBwh47N+FLPgtIvdSC7s9YUSySgRczoGWYU7E4ZIV/wpqdI2MZNUTAxWErkP6d83pQ4n2lyKhqI=@vger.kernel.org X-Gm-Message-State: AFq9FYJTtZ5mEX5XxpCBZEvQcL+xcF9e9i0cKTEaTOmEfqdUqLlBFIaB JtbXmvayGL2v4wZePe4R27tRgrQ1fHdcSAAQXxGLRQTQDRhsmpFrvTg0 X-Gm-Gg: AYBFou1iiCbC2m1SSsqbbQ/zqVS7eZMhJUdRYhl3DUwBaieR1UyYXlxkmRrg5JCmtWP R99foNavNV/IbPdnwJEuXoJGhrlRa+u0T40prYOwaFy1ZcgXRkmWCyYNxpjDQf9zMvc1hiyulbq GmO5J7MStW6Y/oQO5XJp2OBGF153RxOP9Hbv4EKamNtOYYGhA95oq8eyqaO643yJniIIU1Wl/uN TTGYRGAyvFkcsVOagCTxQlwdwjekIr/WYX527RlXbO84VeD3vqW1cg4SFgwaE+Ms1qeUVb+cBLQ VXmTB9kUljboHofiakk2nUCmPWHH2+uQ48OT6zyth4GyjIdrtmeFFOHZmlWIoPQoR3dQX0fPWkc Hx0kD3gAA5aiho0MdGrB3hmIHy+Fg2T7LCuycJP/Kv3pG2TNrXCX1/DlPrlc4xQeYkWONm5Ru+g 4N8daCgUlv4ZOiad0R986c5Fj4dImcILB/Dw02AX287SN/cJJN/kw6TEsfKKKsiB8EtwnigN4D4 LB7cMQGOua7a0DPb26bojZgun17FnVmsUOlsVOOVEnZ0iwznPhY0uMeZM2DtRA1Cmg65G0ZZZwJ qcroDsv1ST3xlQ== X-Received: by 2002:a17:90b:2f83:b0:3a4:b6c2:b159 with SMTP id 98e67ed59e1d1-3a8a1ab8d70mr1631105a91.34.1791370108028; Wed, 07 Oct 2026 03:48:28 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a8543e8478sm11046540a91.17.2026.10.07.03.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 03:48:27 -0700 (PDT) From: phucduc.bui@gmail.com To: Steve Glendinning , Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: bui duc phuc Subject: [PATCH net-next] smsc911x: propagate reset GPIO errors Date: Wed, 7 Oct 2026 17:47:31 +0700 Message-ID: <20261007104731.507647-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc devm_gpiod_get_optional() may return -EPROBE_DEFER or other errors, but smsc911x_request_resources() currently does not handle them. Check the return value and propagate errors from the reset GPIO lookup. Release the regulators if they were successfully acquired before the GPIO lookup failed. Signed-off-by: bui duc phuc --- drivers/net/ethernet/smsc/smsc911x.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c index 3ebd0664c697..41423baaf0af 100644 --- a/drivers/net/ethernet/smsc/smsc911x.c +++ b/drivers/net/ethernet/smsc/smsc911x.c @@ -439,6 +439,13 @@ static int smsc911x_request_resources(struct platform_device *pdev) pdata->reset_gpiod = devm_gpiod_get_optional(&pdev->dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(pdata->reset_gpiod)) { + if (!ret) + regulator_bulk_free(ARRAY_SIZE(pdata->supplies), + pdata->supplies); + return dev_err_probe(&pdev->dev, PTR_ERR(pdata->reset_gpiod), + "failed to get reset gpio\n"); + } /* Request clock */ pdata->clk = clk_get(&pdev->dev, NULL); -- 2.43.0