From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59A694DD3AA for ; Wed, 7 Oct 2026 18:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791396791; cv=none; b=pirOmAF4KQ/H5UKVxnKtrDIBkUhWb6jhWrbIg0nCzUcJzkxF+7aVx0oWFqMw7LN2FeqKUUP/thL9mTaxmuCeF+RwX6h6kwsBDD82qOw4uK56KU++SufZicyEK9YqLDZZWacHoTrZr+jD1YT5Vyi0CTnuKYKtl9LuxzYeT2rOOuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791396791; c=relaxed/simple; bh=x/T2DqdlBD5F/UfxU/ovY6/23a6DBA3cvr6xy3855h0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NisUNY4ZnB4m7k5gmTq7aIlX0LX/sONAi50chdZqKqRT4FxnsWULFHl+pmrF4RSVbTg95BwtGz7KGD4Ndfr5oRPY9nDp7NkpGcD9oVyUC09UKqt9T5i1z9Nc0qoFoGnI6iTEzSHnE3V5bNuWQCGLojkwKmqdjI7ezlOUIaLXlhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g4F31zQ2; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g4F31zQ2" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-3a777d4f321so18768571fa.0 for ; Wed, 07 Oct 2026 11:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791396788; x=1792001588; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=y3ZlJwU7ID9cKcEPq14oLFUHhVFnuy1r4lGgSU64Z7I=; b=g4F31zQ2I25+P/7fmXo1uenCMkIX0zINLUtY1mxbkeNa6CRSyn+dSVo74M3Skpse+a few+HfnqAAQQCqRFWxYHi+7mbDKYlb9xzMwOm5FUrfkcIgaQRQ/qEITHD6RcmFGHo9DQ OhuWeXN8dE32xeRIXdo18PhWGsZ5h82e6t5GoWjjOFcwANwB6oQM2V7Xmuk6s49OVb14 BScFT6vJ+GJsfs04jN+/ANnwHEa/S8+balW+Q6xKmoFVjv+BYla/oUBO8gq0aCh9De6c MhKahMxbvhy5plWTmk2s4YnUW7dc+1Pxwwa7rhreIdFfHb2vqWFYMdOprrQc4l3aruwZ cJrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791396788; x=1792001588; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=y3ZlJwU7ID9cKcEPq14oLFUHhVFnuy1r4lGgSU64Z7I=; b=lblMyQvZqk3e6cYFq5KSgfInO1v86352sp9fhNtnBdcM0QHdxQwQ7uAApcARBpxzsI 1n1btRcqCf0WWQid+zJjuF9kRjRAZh3CAVtezG2pnGjeM7JDc1YYibrU+KMBuGhHfYVA ZDbkeXhjDt2OHZ9otqWqE9Pnjzn90j/rMfziHjoX0Ds2KaNVu16heRjmxGUgc69B7Csv 9wF1eZrzicBBM7BABrAu/u6jYnuZJK0x/2mdIom6b6p4m7lGbvNy7j76U6Bcuzk1VLVg RD6bgAkvAwwf3l7fW2s9wP7a39kh57k4rbVG6U3UG1bRyiHfUrD34PXyMIKRz7uCnHCV IHyw== X-Forwarded-Encrypted: i=1; AKwUvBylrgF2vkLP3B2FvKtTnsUT5tCII7LdDixHZRWszEUUDVdp0KtWsimVeqxOlNDTxWJaxX28nmg=@vger.kernel.org X-Gm-Message-State: AFq9FYIxg3s1T7FzLrDyNRPQFjQIFKu0iAIw70+UbQeYNHqYcbdVWQck +xfLNpxcB2u/Nl1CZUbqAU3viIwNEZMZCa3SeUlwz5Z+kTeUChEPw/YY X-Gm-Gg: AYBFou0z48NaN7J9JU/NjoBRFN69c1lIBWmeRp+6qoVr2xkkJxsg3SigUwVLVGCyzmd /mMHO7lSUkHtaMHYJe/RWuxvmYweajdhPYBavIGUpfSz2jwAfw+GSgEdTR9tolN+jZBweSYF+jY UtoIfAKAMT5e3LevohiBQCikrP9XQPTzZsYvtKKFWMufuLMWjq1LkwprIH1+mC3PSm2kYlIdDrh 44j9gZHIrokZO87DPSrQuLXs4NbpZ+49zuat2Q31x+PgN5lAdlsWpXKKkI9H0auVIHsIPMDVA4a AaFIMG0RHaK3H0AMiC+iOVjwD4HSWj4THiO4DeakXDmjvILTt7FATHsNoC99/8leM8Hhtsj8zgQ kC4MuTVWuV9r6uDQCJtocv7hKaTrzcGHFY5NL61M7Wa6bWAx2ySULYRI8FICwStTSjTsJTawLY3 ZWIWXZ2gueBjK+A3XuvUThyRozLw4ca1q0ttaTxL/pDs9bdaOSnk3v4X8Uwz3HT/0vVVyGYzvhV 5uzsXZ99uMcR3iQfhvHDLjPgTCNXS5YUqtb9byMSR4abMkor3bO X-Received: by 2002:a05:651c:3134:b0:3a6:66ee:1179 with SMTP id 38308e7fff4ca-3a9a2cd18a0mr8684231fa.27.1791396788031; Wed, 07 Oct 2026 11:13:08 -0700 (PDT) Received: from localhost.localdomain (95-24-167-79.broadband.corbina.ru. [95.24.167.79]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a9a1d59661sm9000041fa.18.2026.10.07.11.13.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 11:13:06 -0700 (PDT) From: Maxim Skokov To: bpf@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, memxor@gmail.com, emil@etsalapatis.com, ihor.solodrai@linux.dev, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, vadim.fedorenko@linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Maxim Skokov Subject: [PATCH bpf 0/2] bpf: test_run: Fix false -EBADMSG with BPF_F_TEST_SKB_CHECKSUM_COMPLETE Date: Wed, 7 Oct 2026 21:12:40 +0300 Message-ID: <20261007181249.352831-1-skokovmaksimevg@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit BPF_PROG_TEST_RUN with BPF_F_TEST_SKB_CHECKSUM_COMPLETE returns -EBADMSG for correct tc programs that call bpf_skb_change_tail(). The helper moves the skb to CHECKSUM_NONE and leaves skb->csum stale, but the post-run check added by commit a3cfe84cca28 ("bpf: Add CHECKSUM_COMPLETE to bpf test progs") still compares against it. Patch 1 only does the check while the skb is still CHECKSUM_COMPLETE. Patch 2 adds selftests for a trim, a grow followed by a write, and a negative case that keeps the skb CHECKSUM_COMPLETE with a stale skb->csum. Tested in a VM on bpf, with two kernels that differ only by patch 1 (subtest results): without patch 1 with patch 1 change_tail_trim FAIL (-EBADMSG) OK change_tail_grow_write FAIL (-EBADMSG) OK store_no_recompute OK OK test_skb_pkt_end OK OK Maxim Skokov (2): bpf: test_run: Fix false -EBADMSG after skb leaves CHECKSUM_COMPLETE selftests/bpf: Cover test_run csum validation after bpf_skb_change_tail() net/bpf/test_run.c | 7 ++- .../bpf/prog_tests/skb_csum_complete.c | 39 ++++++++++++++++ .../selftests/bpf/progs/skb_csum_complete.c | 44 +++++++++++++++++++ 3 files changed, 89 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/skb_csum_complete.c create mode 100644 tools/testing/selftests/bpf/progs/skb_csum_complete.c base-commit: ff47652a4b66c067c765a7ad464d930b5a9367cc -- 2.47.3