From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2755381AE5 for ; Thu, 8 Oct 2026 02:29:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791426544; cv=none; b=o0CybyUB0sqWNQ4yuMQkCxP8XRjLBrbPSGbcb6B37Edy/GflxYIpbWy+WqRRe5UcIHEPY2uiac+JxFk8CCEvF7fHHCYcVnx9y2Jv2/cG4zh9okRGF7tRu1sRIjePftEWUE4v1SK4/YhTNoOLP+wk1tOlATL94jBQky5kGP3jeFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791426544; c=relaxed/simple; bh=4dfg5Q0rKQdILfU9u2v+axCjBWUm6KwVuVNePORcz64=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S4N6QDvWzc3ik7uMOoogcY0hcxnjsueuwROqqsp89aChNBxoSL5SxjRdp81R+pLpKoXmUjVAcOj1jTJL2P8ec2YDH2NVdfdmo5Sd5azu5ToPto8JZmpLFMQrG/J3r9UTqJ/lt09k948typAk5t4rURhqpR+HVjFJSOBKWcttmz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hp6/e2+G; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hp6/e2+G" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2e61ac64ec3so8703935ad.2 for ; Wed, 07 Oct 2026 19:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791426542; x=1792031342; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Szl/KezNtI9Hsgxs7YZnv8YwFDL8usJvMfWhCZHBjlE=; b=Hp6/e2+GTxoty8E4Yau7C/tjNvmvntgzluXuAnnD4KHMA+GOp2GJC7CzHNOKwx6xFO vexZGY8VtCd9TluVWJ6YfkizBoTgkbWAr+xW7RemCsmmCd+MRutUtPavZ2t97V67kg5r uvmA4SXq7JCY4wUxvkxVbPrZ+hile5ClFfweQy2x6SoFZ9qkk1EZSVAuG+AYJY6pKGJ7 HQPFp7335u5Jce2isT3bW/5740TalktQIaxfP/kYsKSEwOWOnzMcMNgOY2TMJgYmbVq3 NcfXqMEgABpFnsFmpqAuIynflPw57J+MT0myzYjf5miMfu+bpI3IRiW3/PMtJUvabARb RQVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791426542; x=1792031342; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Szl/KezNtI9Hsgxs7YZnv8YwFDL8usJvMfWhCZHBjlE=; b=E30S49jXlth4NAaxP38Nxm3g120BiNS/qdlRMmU5d7yLWJZaIJ3dI91VQpy+KH7mGg j+XJOXK2kkYdL0bNDYE4SBSaEZ91d9+EeBOstILmM8pVm0iXVczl6KGSoA3pO2t6Fhta M6Vw8uIBPc5AEkL8OCvph2XrVbseD8vzzc7ekAx4vxtCYM1/nVoUFxPVU2g1HJt3Jnhy ToDo7kt1Vz/+n8IIxL8WarardQT0qxGtu15hc/H/W3/6BVVxNbDfRmja56dvF9NMXuTi Rdwn8KxA/Alb7EItd/xJimfevdZ3PMH3A2QOwJ2hgmd+877I/epPaKLmSqryrcVYGMid RrBg== X-Gm-Message-State: AFq9FYIuCAu9nIULgt+q0TZe0LPYMedN3wuW4X8vW6HFdpLFc5YpDjOg 7qynYGmg7YRHDVpPhPmdFnA8jNb6jq+bpr46uIcDCPYtL+3/3yLq9fknJsa/Ew== X-Gm-Gg: AYBFou13GnEgDxuzcEc0d8/61Z6AK3ntxdmMOceVivENY7eCvxGlfdBTGn3zVpmU47j nPaV3UjzprKCPkIQy1O8v1HbgoOoEaR9apErW80VcpAn0B1ucF/Ixahye4AArv96P9oFs4YDH2V f+qsFsPr0jS7V9PDPegXwenAZ0E2djrPlz8/ybe3wWEeCoZ0SFwPHWCXuFv8qIRrwEhvnAwRKx1 f/AnJS5YwCUCAnftMQSxhbMImNIwAhxpDFnpiVJaeFaJXoTRy7UZWhTdP7e8rJbSTszK8u7+kGE vPQy+4Y4zPYClPXqUb2TAGqFBOs5Tt/JF2QTjlKjavJWm//XmrEzMa0QxdzeOmls74iXTVFGFlZ yyhgWMxCXggQudmimExlNmBpqDIZw/rYggrHz465uOQzXkXT6Upvpes6mVM0MrLre8LJK9kZ84C qVQXt/VNUaivg+DI0KODDQjw2umH5a2ZkB/PAo4wsRa4B39SVCApM67SzQxr5g2f8V0A61ZcZBh o1xfYjRg10aJmxgKk0nbmBUEA== X-Received: by 2002:a17:902:d987:b0:2dd:68a4:16f1 with SMTP id d9443c01a7336-2e600388d12mr37379625ad.11.1791426541913; Wed, 07 Oct 2026 19:29:01 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac5:661c:1246::1d2:d1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e60482cab0sm18045865ad.50.2026.10.07.19.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 19:29:01 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Sebastian Hesselbarth , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Stanislav Fomichev , Nicolai Buchwitz , Jacob Keller , linux-kernel@vger.kernel.org Subject: [PATCH net 05/10] net: mv643xx: move setting of netops to fix crash Date: Thu, 8 Oct 2026 10:26:47 +0800 Message-ID: <20261008022656.3592191-6-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261008022656.3592191-1-mmyangfl@gmail.com> References: <20261008022656.3592191-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mv643xx_eth_probe() connects the PHY before dev->netdev_ops is assigned. phy_attach_direct() -> phy_link_topo_add_phy() reads dev->netdev_ops through netdev_need_ops_lock() since the commit in question, so probing crashes with a NULL pointer dereference when CONFIG_NET_SHAPER is enabled. Assign netdev_ops before the PHY attach, as was done for emac in commit 7c9f391ec89c ("net: emac: move setting of netops to fix crash"). Fixes: ded86da4bbb7 ("net: ethtool: relax ethnl_req_get_phydev() locking assertion") Signed-off-by: David Yang --- drivers/net/ethernet/marvell/mv643xx_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c index 9caa1e47c174..38b4d65f58a5 100644 --- a/drivers/net/ethernet/marvell/mv643xx_eth.c +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c @@ -3171,6 +3171,8 @@ static int mv643xx_eth_probe(struct platform_device *pdev) netif_set_real_num_tx_queues(dev, mp->txq_count); netif_set_real_num_rx_queues(dev, mp->rxq_count); + dev->netdev_ops = &mv643xx_eth_netdev_ops; + err = 0; if (pd->phy_node) { phydev = of_phy_connect(mp->dev, pd->phy_node, @@ -3221,8 +3223,6 @@ static int mv643xx_eth_probe(struct platform_device *pdev) } dev->irq = irq; - dev->netdev_ops = &mv643xx_eth_netdev_ops; - dev->watchdog_timeo = 2 * HZ; dev->base_addr = 0; -- 2.53.0