From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A63B3A4F33 for ; Thu, 8 Oct 2026 02:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791426549; cv=none; b=Lxi9YkPXoTui/6TqEKvdJ6bvJmxbK53qNU2ZPRAgehldVDImrkbuDHzMn5qkLl7jHkWt+Vs+Gafl9lI5hFGN5+GriDqYWmu/7XYM0pQxkOFLdfW5RbP6Mr4TenD9WlNFjf6iion0pslnZHO4buWhIphDLIPt009yxV4Bz/1LQHA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791426549; c=relaxed/simple; bh=ztKTT4JAcEoax2iY+PtSE7h4q8MRZduhYVOG131ubtQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LNutPM/WlTdEYllulKAmCfOpdZhJxJqjp+GTnEVv5BY/dpWkQSWMIfyTv666sWwQY5rbdrf4TkpysvtAKanpyersdNhXXAK8LQc/zQ/kbijNAq1WV4X584FbM1zY7U2piZezjEay3sFHgpudI1Qi6INT84INgIh+SYzVXSbbMac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YqdZ3f1/; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YqdZ3f1/" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2db710396ffso1241475ad.1 for ; Wed, 07 Oct 2026 19:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791426547; x=1792031347; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B0Fg0kvLuqZeUZslFiV+07zDYOZ3aqmA+U8LAhXNczw=; b=YqdZ3f1/b+HCq/dj1YqgSfafhI/W3FzU2ifg9w4mrPMJxKFlKF5BmwFW23Ri4i+S+N d5E93RwSeiXX3OJ/oFfe5p+goqRRo/iI2UtdzzfU+Wl496hTdKNP1FaLp39av5CbXb9h 5scq0v2AX+fLSqklxRXKAlnQ74jFUC6+itNSLNEHT4rhorCdfxbYt4MAoQ+HaxT26VDB Xllercn59zvgQe4/nA2mXfVsgmWL92tKl8oeiH9JM7REmLFXQuKGftd1SwvFXJartSep OER2Ns6KsotXOIZhSF8omXPZAJD+98v0eTC1cF3HY709kGK4xJpKAHMeU74K+3Ys+0tB 94RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791426547; x=1792031347; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=B0Fg0kvLuqZeUZslFiV+07zDYOZ3aqmA+U8LAhXNczw=; b=EpTOcEumcId7llRBfrCyZvxSPQdHcBPrBmeWRF7N1qMAWjUnhgGwKE2gZils7ldPso 83AZ7Aga5yFI5NStbGIuqDcnAcrQPoqONlark68TGINwBh+UglD3t22o+j/bzEgrYUqM Ldb5YRNV37AIBUIqVvzDTfsbabMRyYD4cLJQBbbH51hxy6uJTRXexBOgvLddj0eDvnSR vJrSeNpKqsfltSR5SVtd+OcpcbGYtH3hhXabN5K75J+EMct9YYAQM6jyMsFyRJ6Ct2/0 SmoWSvQNLqHtTHOVDakzD6ne6x5l6qzwIHapqa68QO3hmw2cxOdCBafUm8blJBAvXlWo EiBA== X-Gm-Message-State: AFq9FYKkbAZXyVoCzQATZf5X5zDzZzbCX6tGKWJFhmt/9cjSPos/hJ29 Ski3J4uRUHSQ/CKE7aYP2gcK+SKkUhmuJhbiUt0znIx7Kn9dPg7g7/joF3dSCUgH X-Gm-Gg: AYBFou21CN5KgLYzIvhIM7bYdLa6LGPntTx5bInUYm+tn4ydpkr2RcDjAuZMJEYLz1y yMU6Gty3vsKRN/wi8Uh8zX4lL+lVE1doItNf7Ol5Fv4dDkKnntoc/zdiQ14GVIleQ1qsSrQzos2 AwO6I3+srVCiCxN9+fGmYiBGYXsAI8pRkEhZ/ehPL4Lc+rDa5cUOjqSF2toMMD7dSw8Ak1Zrwtu e6w8y1ZT/H6g1pwDcMVjpHT2VHOMYzD0lTEw4CnaHXp7Fx+KGRPpUVPQUbb2uFHnQ79Q2bQeFHM lA7buX67SJt5FgfyppOLZCFNnSvYs6tFXwOZ3wX4lI2kNNPDEzHo8Stu0DQyXy15YtqpnSI+WwA x/S6tg7Ra37BD0IgCtCKdgMMOt6s/sj4UTXo0fK9486loNE0LJW9ecX3qVDIBsx9i+tdo71MYDx zA6pWOVHsg4ZsFFK6Pw2ZUuFawW2Kh7mjXF6i56hTEH6qSDAgWVsgRx/KAOwTe9famCv+EbTK4A dLtMnaULZpOUEy2FK6ABK4rnQ== X-Received: by 2002:a17:903:3807:b0:2df:8c4d:a2be with SMTP id d9443c01a7336-2e7ffe981aamr5886625ad.39.1791426547277; Wed, 07 Oct 2026 19:29:07 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac5:661c:1246::1d2:d1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e60482cab0sm18045865ad.50.2026.10.07.19.29.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 19:29:05 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Runyu Xiao , Simon Horman , Jacob Keller , Nicolai Buchwitz , Maxime Chevallier , linux-kernel@vger.kernel.org Subject: [PATCH net 06/10] net: au1000: move setting of netops to fix crash Date: Thu, 8 Oct 2026 10:26:48 +0800 Message-ID: <20261008022656.3592191-7-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261008022656.3592191-1-mmyangfl@gmail.com> References: <20261008022656.3592191-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit au1000_probe() calls au1000_mii_probe(), which connects the PHY, before dev->netdev_ops is assigned. phy_attach_direct() -> phy_link_topo_add_phy() reads dev->netdev_ops through netdev_need_ops_lock() since the commit in question, so probing crashes with a NULL pointer dereference when CONFIG_NET_SHAPER is enabled. Assign netdev_ops before the PHY attach, as was done for emac in commit 7c9f391ec89c ("net: emac: move setting of netops to fix crash"). Fixes: ded86da4bbb7 ("net: ethtool: relax ethnl_req_get_phydev() locking assertion") Signed-off-by: David Yang --- drivers/net/ethernet/amd/au1000_eth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c index 5a04056e38fa..8682323d693f 100644 --- a/drivers/net/ethernet/amd/au1000_eth.c +++ b/drivers/net/ethernet/amd/au1000_eth.c @@ -1225,6 +1225,8 @@ static int au1000_probe(struct platform_device *pdev) goto err_mdiobus_reg; } + dev->netdev_ops = &au1000_netdev_ops; + err = au1000_mii_probe(dev); if (err != 0) goto err_out; @@ -1263,7 +1265,6 @@ static int au1000_probe(struct platform_device *pdev) dev->base_addr = base->start; dev->irq = irq; - dev->netdev_ops = &au1000_netdev_ops; dev->ethtool_ops = &au1000_ethtool_ops; dev->watchdog_timeo = ETH_TX_TIMEOUT; -- 2.53.0