From: Stephen Hemminger <stephen@networkplumber.org>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
netdev@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Victor Nogueira <victor@mojatatu.com>,
moeller0@gmx.de, cake@lists.bufferbloat.net,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH net-next v5] net/sched: cap the accounted backlog before it can wrap
Date: Thu, 8 Oct 2026 08:23:45 -0700 [thread overview]
Message-ID: <20261008082345.5e16ca44@phoenix.local> (raw)
In-Reply-To: <87pkxks68f.fsf@toke.dk>
On Thu, 08 Oct 2026 14:54:08 +0200
Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> >>
> >> > +/* Compute the flow/host hash keys from the packet as received. Must run
> >> > + * before skb_gso_segment(), which rewrites an encapsulated GSO packet's
> >> > + * headers to the inner ones and would change the keys. Reads only the skb
> >> > + * and commits no qdisc state, so it may run before admission is known.
> >> > + */
> >>
> >> And drop the weird LLM comments, please. If you split the series
> >> properly they are not needed.
> >>
> >
> > Like I said, it's a dilemma.
>
> See above.
As heavy LLM user, I often have to tell it.
"Thats good, now rewrite the commit and comments for humans. Make the result
conform to the style of other places in the same code"
next prev parent reply other threads:[~2026-10-08 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 7:42 [PATCH net-next v5] net/sched: cap the accounted backlog before it can wrap Jamal Hadi Salim
2026-10-08 9:49 ` Toke Høiland-Jørgensen
2026-10-08 12:17 ` Jamal Hadi Salim
2026-10-08 12:54 ` Toke Høiland-Jørgensen
2026-10-08 15:23 ` Stephen Hemminger [this message]
2026-10-09 9:20 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008082345.5e16ca44@phoenix.local \
--to=stephen@networkplumber.org \
--cc=cake@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=moeller0@gmx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashiko-bot@kernel.org \
--cc=toke@toke.dk \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox