Re: [PATCH net] ptp: ocp: fix PCIe delay estimation calculation

[Daniel Machon <daniel.machon@microchip.com>]

> The commit in fixes introduced a high cap for delayas U64_MAX value

nit: I think delayas should be "delay as", probably not worth respining for.

> while ktime_t is actually s64. This is wrong cap as it becomes negative
> value and any comparison to a real delay will fail to update delay
> value. Use KTIME_MAX constant as correct max cap for PCIe delay.
> 
> Fixes: aa05fe67bcd64 ("ptp: ocp: Improve PCIe delay estimation")
> Signed-off-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
> ---
>  drivers/ptp/ptp_ocp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 3d26ec1f7b9e..a8cba2f64b98 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -1825,7 +1825,7 @@ ptp_ocp_watchdog(struct timer_list *t)
>  static void
>  ptp_ocp_estimate_pci_timing(struct ptp_ocp *bp)
>  {
> -       ktime_t start, end, delay = U64_MAX;
> +       ktime_t start, end, delay = KTIME_MAX;
>         u32 ctrl;
>         int i;
> 
> --
> 2.47.3
> 
> 

Reviewed-by: Daniel Machon <daniel.machon@microchip.com>