From: mheib@redhat.com
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, horms@kernel.org,
Mohammad Heib <mheib@redhat.com>
Subject: [PATCH iwl-next v5 0/2] i40e: add runtime-tunable ATR sample rate
Date: Thu, 8 Oct 2026 16:18:22 +0300 [thread overview]
Message-ID: <20261008131824.248508-1-mheib@redhat.com> (raw)
From: Mohammad Heib <mheib@redhat.com>
This series makes the Flow Director ATR sample rate configurable at
runtime through a devlink parameter.
On systems with many queues and high-rate TCP workloads, the fixed
default sampling interval can cause frequent Flow Director
reprogramming and TCP packet reordering. The optimal interval depends
on the workload and system configuration.
Patch 1 moves atr_sample_rate from per-ring to PF level, since it is
a global policy. It also triggers a PF reset when re-enabling ATR via
ethtool private flags so that fd_ena is reprogrammed in the TX queue
HW context.
Patch 2 exposes atr_sample_rate as a devlink runtime parameter so
administrators can tune it without rebuilding the driver.
Testing with iperf3 -t 60 showed ~7k TCP reordering events at the
default sample rate (20). Setting atr_sample_rate to 10000 reduced
reordering to ~769 (~90% reduction).
Changes since v4:
- Folded the PF reset patch into patch 1 for bisect cleanliness
(was patch 3/3 in v4)
- Skip PF reset when FD_SB (ntuple) already holds fd_ena high,
avoiding unnecessary traffic disruption
- Fix LLDP EEXIST path to not drop unrelated reset requests
(reset_needed &= ~REBUILD_FLAG instead of = 0)
- Flush existing ATR entries when setting atr_sample_rate to 0 via
devlink, so stale filters do not persist on devices without HW
ATR eviction
- Documentation: clarify that the sampling interval is per Tx queue
and counts TCP packets only; fix formatting
Mohammad Heib (2):
i40e: move ATR sample rate from ring to PF level
i40e: add devlink parameter for Flow Director ATR sample rate
Documentation/networking/devlink/i40e.rst | 21 +++++++++
drivers/net/ethernet/intel/i40e/i40e.h | 1 +
.../net/ethernet/intel/i40e/i40e_devlink.c | 46 +++++++++++++++++++
.../net/ethernet/intel/i40e/i40e_ethtool.c | 12 ++++-
drivers/net/ethernet/intel/i40e/i40e_main.c | 9 ++--
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 6 ++-
drivers/net/ethernet/intel/i40e/i40e_txrx.h | 3 +-
7 files changed, 87 insertions(+), 11 deletions(-)
--
2.56.0
next reply other threads:[~2026-10-08 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 13:18 mheib [this message]
2026-10-08 13:18 ` [PATCH iwl-next v5 1/2] i40e: move ATR sample rate from ring to PF level mheib
2026-10-08 13:18 ` [PATCH iwl-next v5 2/2] i40e: add devlink parameter for Flow Director ATR sample rate mheib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008131824.248508-1-mheib@redhat.com \
--to=mheib@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox