From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4734D4252A0 for ; Fri, 9 Oct 2026 06:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791525999; cv=none; b=ZXxJm6jVI84nmZLW9w4uZu8RPCGOf5I5Y4KtMOpaljJ6Jje2rmPy+1vdY6WvN+QZGBRyX/QNASTnEQno4AfGp3yRwOW+e+jhwJWIwIWqL4uN99PwTU9n2aL2kYS4+Qp/u2UBE9tW+3dC4kKBq6k2Otlcc5Us5mQdf/wEMfyG6uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791525999; c=relaxed/simple; bh=3OTy30U9zaA/EoJrB2LEVikw7T9erylLWW9kg7srSqA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cqkT9K19YrXaCRRQuMJog/MvP/evRGW3ACyG8YB8MZI8t/QxfCN9WqxGKPfmTUHONHz25tRmoLs04mD/2iuUgC9234H7i5N8LZtD556naxP/T9ddQINmSPcvsmp+a882i7l2ydHVuca17EV959JGNilRJWfmxjFtk38hzWDxsds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D4MX8mbC; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D4MX8mbC" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-3535bf8b3e0so1106359eec.0 for ; Thu, 08 Oct 2026 23:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791525996; x=1792130796; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uV/uHpIyvSDg1rMqWOrJjW5nbbNl8aiS8yrcLtotir0=; b=D4MX8mbC497vZEToxnEYBOpmZodZBfPnn9155EiMp+HLkzHkzg8BBdBrbFfM4z8Hmy QX+GU9JXQVDYTupdzxtyVp5BasbGUdppet9alRHAzTMNJIzpGaW4cdTO33KJxk1sqFxe 1vccgtRQtUoUW7MwgXntBP4YszFCKi/bxO3puxQZh02/XpeVR409SI8cIvm19oRSnKP6 Ws8M3hJBaPqPwI12h2pIKnAC8d31Ut5/ncyc4xQbfxX4jBwVQKfVsLDv007jNYlzzOdO 6UDhxdFmEbuDr4kg1GwOlPgmlwmZIlXO0QCS+oBe8j73Dd1W06K/19HX3ij7pgtWM2de ysIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791525996; x=1792130796; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=uV/uHpIyvSDg1rMqWOrJjW5nbbNl8aiS8yrcLtotir0=; b=CYM+f/bRekLRqWzqGMlOalJzr036cbzf4dbwdAlZ12R3pqw7zyJQv1Pgga/Mo1+El+ jAX/8eVo28MGXCWZ9fUZITx+oea+4OLjR3lgVfoJYEaygAUIeueLmsVES0H3J0hU45/X loGvSQnm1KqbweWXcO7xK5Htxr8Gm2kkW+cbPzwxMruK9OUxiuvQbol9eVO2QWCXMI8b 7Lj+LRXfiUvyf7kscLyjAGDVzjAYBnbKqKnAAxmHCzakqeQYYKA3GvDjy6bndhvGF2qy nl6SMJyOiWFfHsv0xPVnKLzIYwuS/BYUTQAmmz3LzPCnhKA71HFua18DC7xmQ47VhunM qFOg== X-Forwarded-Encrypted: i=1; AKwUvBypTuSyF8ZPPh5C6Z1NIzkC0bx5QEmNNpAiBdYYTBpFgWlRiqAF5YxeumWISwFcKAuERWdBBVQ=@vger.kernel.org X-Gm-Message-State: AFq9FYJFSHqZVtCepcPKT5ft+HY5zAiI+QtEuZ/xKOx4glEPrXvjl/No U8eCvb4JTD6fXS/PH0dScuexcjwIcZDcNYXi321lMBRPn0R2hKz3ByVU X-Gm-Gg: AYBFou0HlYLz9dkhwoV2wWB7IMh7+MmNSzwECNBWD5nlFK5X8EHFTyNilCKuf4PzUka cUWDxzZsrNLvJ+KtA+bjwQUyL2fJQei0g2Hiqk9FDRcJLJ04sP2gZ45N8r53lDiIKu+mqSbrXML lx8xUrsNUClZEqqNcSdRpqWN2MlwyjUKTIr1dDXrS99/jkU2Y/nWbFeZe6BMyLXsDjgJLhJs25w 8zVsyHrjSjFMDsGYcVfZ3PrvRjr7DZz9DLJU/+7hP37JO5MqGgMHZ5ZPGEVHUHffv8tBo5b0h1m 2Hzt43V6iq6FUhuwv11dgeEHOrlgvTUEoMk4bSWNyIFLDbO1xKcGfqvqVvQVe5xppUyFdjdFOt2 FfWwu8spOMiBSbhRW4N3hwh1yduY31xqZ9y0MBS58z5+C11ezdhB3LIG4SPrWf38JdhjT1ddfQu /g2WSvLDJBM01JbQ/zTghzPAYnry/m1nPsnw6vjfPyGvPg+MHko6dtGeBmhMLbuPkfpFf6LiTUB eUNpBD6aofI6X58f7xATCOOmTwdke1lPUDMq/V5LOvyT3rDGZGCXWHmIvEK2nij6exi68dRM5gT RsiYtWyVwHbPQ+lRVREdAHIubf3PbPUcCNsk+wBRmw4= X-Received: by 2002:a05:693c:4090:b0:351:1230:e379 with SMTP id 5a478bee46e88-3537df59719mr1717655eec.6.1791525996087; Thu, 08 Oct 2026 23:06:36 -0700 (PDT) Received: from ramen-dev-security-2.asia-south1-c.c.ramen-dev-345017.internal (90.156.200.35.bc.googleusercontent.com. [35.200.156.90]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3537cb6a2afsm4185544eec.31.2026.10.08.23.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 23:06:35 -0700 (PDT) From: Anil Kaushik To: Pablo Neira Ayuso , Harald Welte , Donald Hunter , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , Shuah Khan Cc: osmocom-net-gprs@lists.osmocom.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH net-next v3 1/3] gtp: set a valid genl command in PDP context get and dump replies Date: Fri, 9 Oct 2026 06:06:13 +0000 Message-Id: <20261009060615.4177402-2-anilkaushikwireless@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20261009060615.4177402-1-anilkaushikwireless@gmail.com> References: <20261009060615.4177402-1-anilkaushikwireless@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit gtp_genl_fill_info() stamps the reply with the command its callers pass in. gtp_genl_get_pdp() and gtp_genl_dump_pdp() pass nlmsg_type, which in a genl message is the dynamically assigned family id rather than a GTP_CMD_* value, so replies to a PDP context get or dump carry a meaningless command number. libgtpnl ignores the command and is unaffected, but parsers that check it (for example the ynl tooling) treat the reply as an unknown command and discard it. Pass GTP_CMD_GETPDP, as gtp_tunnel_notify() already passes a real command on the notification path. No uapi change. Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)") Signed-off-by: Anil Kaushik --- drivers/net/gtp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 4aff23bcfdd1..99836b773e5c 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -2279,7 +2279,7 @@ static int gtp_genl_get_pdp(struct sk_buff *skb, struct genl_info *info) } err = gtp_genl_fill_info(skb2, NETLINK_CB(skb).portid, info->snd_seq, - 0, info->nlhdr->nlmsg_type, pctx); + 0, GTP_CMD_GETPDP, pctx); if (err < 0) goto err_unlock_free; @@ -2326,7 +2326,7 @@ static int gtp_genl_dump_pdp(struct sk_buff *skb, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_seq, NLM_F_MULTI, - cb->nlh->nlmsg_type, pctx)) { + GTP_CMD_GETPDP, pctx)) { cb->args[0] = i; cb->args[1] = j; cb->args[2] = (unsigned long)gtp; -- 2.25.1