From: kernel test robot <lkp@intel.com>
To: Subash Abhinov Kasiviswanathan
<subash.a.kasiviswanathan@oss.qualcomm.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, corbet@lwn.net
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
horms@kernel.org, skhan@linuxfoundation.org,
rdunlap@infradead.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Subash Abhinov Kasiviswanathan
<subash.a.kasiviswanathan@oss.qualcomm.com>,
Sean Tranchetti <sean.tranchetti@oss.qualcomm.com>
Subject: Re: [PATCH net-next v2 7/8] net: qualcomm: rmnet: Add DL coalescing statistics
Date: Fri, 9 Oct 2026 07:59:34 +0800 [thread overview]
Message-ID: <202610090707.TY5x2Oyd-lkp@intel.com> (raw)
In-Reply-To: <20261008005543.2630828-8-subash.a.kasiviswanathan@oss.qualcomm.com>
Hi Subash,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
[also build test WARNING on next-20261008]
[cannot apply to linux-review/Subash-Abhinov-Kasiviswanathan/uapi-if_link-Add-RMNET_FLAGS_INGRESS_COALESCE/20260929-221339 net/main lwn/docs-next linus/master v7.3-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Subash-Abhinov-Kasiviswanathan/net-qualcomm-rmnet-Update-MTU-handling-during-format-changes/20261007-175538
base: net-next/main
patch link: https://lore.kernel.org/r/20261008005543.2630828-8-subash.a.kasiviswanathan%40oss.qualcomm.com
patch subject: [PATCH net-next v2 7/8] net: qualcomm: rmnet: Add DL coalescing statistics
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20261009/202610090707.TY5x2Oyd-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 242243a5814307de825db3428662d67b064e2cbc)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261009/202610090707.TY5x2Oyd-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610090707.TY5x2Oyd-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c:286:13: warning: stack frame size (1392) exceeds limit (1280) in 'rmnet_get_ethtool_stats' [-Wframe-larger-than]
286 | static void rmnet_get_ethtool_stats(struct net_device *dev,
| ^
1 warning generated.
vim +/rmnet_get_ethtool_stats +286 drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
bbde32d38bfbbc4 Subash Abhinov Kasiviswanathan 2018-05-15 285
bbde32d38bfbbc4 Subash Abhinov Kasiviswanathan 2018-05-15 @286 static void rmnet_get_ethtool_stats(struct net_device *dev,
bbde32d38bfbbc4 Subash Abhinov Kasiviswanathan 2018-05-15 287 struct ethtool_stats *stats, u64 *data)
bbde32d38bfbbc4 Subash Abhinov Kasiviswanathan 2018-05-15 288 {
bbde32d38bfbbc4 Subash Abhinov Kasiviswanathan 2018-05-15 289 struct rmnet_priv *priv = netdev_priv(dev);
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 290 struct rmnet_priv_stats total_stats = { };
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 291 struct rmnet_pcpu_stats *pcpu_ptr;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 292 struct rmnet_priv_stats snapshot;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 293 unsigned int cpu, start;
bbde32d38bfbbc4 Subash Abhinov Kasiviswanathan 2018-05-15 294
bbde32d38bfbbc4 Subash Abhinov Kasiviswanathan 2018-05-15 295 if (!data)
bbde32d38bfbbc4 Subash Abhinov Kasiviswanathan 2018-05-15 296 return;
bbde32d38bfbbc4 Subash Abhinov Kasiviswanathan 2018-05-15 297
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 298 for_each_possible_cpu(cpu) {
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 299 pcpu_ptr = per_cpu_ptr(priv->pcpu_stats, cpu);
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 300
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 301 do {
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 302 start = u64_stats_fetch_begin(&pcpu_ptr->syncp);
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 303 u64_stats_copy(&snapshot, &pcpu_ptr->priv_stats,
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 304 sizeof(snapshot));
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 305 } while (u64_stats_fetch_retry(&pcpu_ptr->syncp, start));
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 306
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 307 total_stats.csum_ok += snapshot.csum_ok;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 308 total_stats.csum_ip4_header_bad += snapshot.csum_ip4_header_bad;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 309 total_stats.csum_valid_unset += snapshot.csum_valid_unset;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 310 total_stats.csum_validation_failed += snapshot.csum_validation_failed;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 311 total_stats.csum_err_bad_buffer += snapshot.csum_err_bad_buffer;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 312 total_stats.csum_err_invalid_ip_version +=
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 313 snapshot.csum_err_invalid_ip_version;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 314 total_stats.csum_err_invalid_transport +=
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 315 snapshot.csum_err_invalid_transport;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 316 total_stats.csum_fragmented_pkt += snapshot.csum_fragmented_pkt;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 317 total_stats.csum_skipped += snapshot.csum_skipped;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 318 total_stats.csum_sw += snapshot.csum_sw;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 319 total_stats.csum_hw += snapshot.csum_hw;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 320 /* Custom rmnet coalescing diagnostics follow. */
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 321 total_stats.coal_alloc_fail += snapshot.coal_alloc_fail;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 322 total_stats.coal_rx += snapshot.coal_rx;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 323 total_stats.coal_pkts += snapshot.coal_pkts;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 324 total_stats.coal_hdr_err += snapshot.coal_hdr_err;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 325 total_stats.coal_hdr_pkt_err += snapshot.coal_hdr_pkt_err;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 326 total_stats.coal_bounds_err += snapshot.coal_bounds_err;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 327 total_stats.coal_csum_err += snapshot.coal_csum_err;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 328 total_stats.coal_csum_drop += snapshot.coal_csum_drop;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 329 total_stats.coal_reconstruct += snapshot.coal_reconstruct;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 330 total_stats.coal_ip_invalid += snapshot.coal_ip_invalid;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 331 total_stats.coal_trans_invalid += snapshot.coal_trans_invalid;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 332 total_stats.coal_close_non_coal += snapshot.coal_close_non_coal;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 333 total_stats.coal_close_ip_miss += snapshot.coal_close_ip_miss;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 334 total_stats.coal_close_trans_miss += snapshot.coal_close_trans_miss;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 335 total_stats.coal_close_hw_nl += snapshot.coal_close_hw_nl;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 336 total_stats.coal_close_hw_pkt += snapshot.coal_close_hw_pkt;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 337 total_stats.coal_close_hw_byte += snapshot.coal_close_hw_byte;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 338 total_stats.coal_close_hw_time += snapshot.coal_close_hw_time;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 339 total_stats.coal_close_hw_evict += snapshot.coal_close_hw_evict;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 340 total_stats.coal_close_coal += snapshot.coal_close_coal;
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 341 }
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 342
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 343 /* The first four fields are reported through netdev queue statistics. */
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 344 memcpy(data, &total_stats.csum_ok,
2a458504868286e Subash Abhinov Kasiviswanathan 2026-10-07 345 sizeof(total_stats) - offsetof(struct rmnet_priv_stats, csum_ok));
bbde32d38bfbbc4 Subash Abhinov Kasiviswanathan 2018-05-15 346 }
bbde32d38bfbbc4 Subash Abhinov Kasiviswanathan 2018-05-15 347
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-10-08 23:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 0:55 [PATCH net-next v2 0/8] Add HW GRO handling in rmnet Subash Abhinov Kasiviswanathan
2026-10-08 0:55 ` [PATCH net-next v2 1/8] net: qualcomm: rmnet: Update MTU handling during format changes Subash Abhinov Kasiviswanathan
2026-10-08 0:55 ` [PATCH net-next v2 2/8] uapi: if_link: Add RMNET_FLAGS_INGRESS_COALESCE Subash Abhinov Kasiviswanathan
2026-10-08 0:55 ` [PATCH net-next v2 3/8] net: qualcomm: rmnet: Process MAPv5 frames as a list Subash Abhinov Kasiviswanathan
2026-10-08 0:55 ` [PATCH net-next v2 4/8] net: qualcomm: rmnet: Restrict supported MAP checksum configurations Subash Abhinov Kasiviswanathan
2026-10-08 0:55 ` [PATCH net-next v2 5/8] net: qualcomm: rmnet: Add DL packet coalescing support Subash Abhinov Kasiviswanathan
2026-10-08 0:55 ` [PATCH net-next v2 6/8] net: qualcomm: rmnet: Work around coalescing hardware quirks Subash Abhinov Kasiviswanathan
2026-10-08 0:55 ` [PATCH net-next v2 7/8] net: qualcomm: rmnet: Add DL coalescing statistics Subash Abhinov Kasiviswanathan
2026-10-08 23:59 ` kernel test robot [this message]
2026-10-08 0:55 ` [PATCH net-next v2 8/8] docs: networking: Add documentation for the coalescing support in rmnet Subash Abhinov Kasiviswanathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202610090707.TY5x2Oyd-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=sean.tranchetti@oss.qualcomm.com \
--cc=skhan@linuxfoundation.org \
--cc=subash.a.kasiviswanathan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox