From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3158B391E55 for ; Fri, 9 Oct 2026 17:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791568098; cv=none; b=JZnT3V31LDAySnGJGoFazdI/hBOYa0mblM1h+E2tGpalV4bka7QBnU+HF0/3KaAp3PrZQ37h6GQ2PFxxvhbFXxvn9h4yo7zkP+LQC7yNYATN2hPoghMeJdGYwmSnTLRVkehAdgzIgm+Hsrk37rnfSv5SyCa7+SwToRU5xrMqZ5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791568098; c=relaxed/simple; bh=JgPaicxCucfdMkRINMIAPBjQlAb0HOrhvBZzO59T1bw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=m7FyFkcTKlvIWPD2Zo/1QO2kgwunZbyCB3lSKDHwiJ9ZrR7kYVnWMc/+oaFh6trM0cSkabGRLpDer9ep0OKSoYi8t/aZQjjzEgfAPv4E7KNfruovWpaHRnkWQyPHnbN4u4I9kPmhUh+yw8AYCYltuuF4Fy1GL+ufoIWLONAVu9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YAuOrsvz; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YAuOrsvz" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5ba3adf78f5so5243594e87.3 for ; Fri, 09 Oct 2026 10:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791568094; x=1792172894; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=pA8E/ThbMiBTOoyIyD/1D76SZ7hCfLkGZWv68NB0mJs=; b=YAuOrsvzMD0e/VL0IBVH9fLziRwJqN1laynw2JFcVT/5CkA88bLIMuKnHiBxE5m6Zn +s/ZzLHaBWSNKrsXM7wp8o/eI2N1nOTlFB5V4Ty/Yq2N/Xf3/PW68IehFvokUbm08oAt DSFtzUMwZh1/Rj6XDF4QG4cjoTjptWv47hjgRCe5UbXmM01UbZePvAOXVrIHIlRDGKew x0cW9sGD0iLDP8SzcS/jhemyrn90Z6YKr0Wym/VSAPIZq7SeseqEwfoE9eOJxOHSYLIa UUKdYKVJo2ORtsBUhaIvGnIpNi7vfns0m+TbQDbkUHo4fKZO2m1gGxj6EolQNwAYARru E7QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791568094; x=1792172894; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pA8E/ThbMiBTOoyIyD/1D76SZ7hCfLkGZWv68NB0mJs=; b=Jwx1XvRPavT5tNBZI4+yFweNyycQP/+mcKSHgHxImhy+O1TWGXBn3LP9YFhlPHD2RS IB7ezbJkrWJ/2XEIJPKYuBsSYYsfqu9RgqxwcCNK75QmklKB2JGfhfHWZqdBxcdvWwfx SRwDuOEsVJ2UfOWQ6f6ZOkrCNTUeq3WZ3H5ZdwO9gVqSqz1hAHwmK454VaBPSEBwNWwP ncdl5pKHoLRMirBxiqNOsoUaDQi1U/Bjdm2fiERsPpZbCRsAWjLNppt5rGwnT1hOxeej Q87WX0eenr7Jl5p/ddoZyzQrZrX1gLz8JXV4Gs3YvbjXaa/Cb5TljzKakhkCIpi/O6IC 7hGw== X-Forwarded-Encrypted: i=1; AKwUvBwNWx7STRwQcLOs7ewmiGQHfw0kHuNDB+heNeJZsndW8mud8KHeBUz38a9KYgdktZLm5MRGsQc=@vger.kernel.org X-Gm-Message-State: AFq9FYIALg7WKFTyjg+H1YB3+HzAGiLuKnHFwPAJmPdKdtKQQ0mTh2vs yydE50RHjm2XMcZIbqKOd6K+qmTqdjLAUA1nAObnrwE9PoWFM+Yyi7Ov X-Gm-Gg: AYBFou27naHrtOLwN3SveTGRTTcDSmTbYmxYfL90gRwFyIGWRMq/9T4T2ogQkzLOr6H DRM1w/RQG9dFCS07zew+F+iuIUpNzxqM8sR9CYzHHIkbswSb5AJTydV5eCivP40ZMEhjsOYYWp6 ECKILjtdGEOGA7l1Q5E4PZkUA3V4fzZ4mv/o1jQGI/j7UaYy5XxEs7VSfVxHbZdw6w3oFEDmLbp oLqnv2Ijs6SBn6b6yYwbZIV/lvIWi2sJTnaf1sEARA5t2Y4DxbMb2vkttXf9tiSILVL7dDgzo0j SRK9PJZ4J2/PwTE3p6e/5Ksu+tXdlhPxbtNQB3sMcVgOvOxgwGAJhujAx6AZ9seXBW/GRrVWywf SEkvQK0Z0cdmKy07nY1dORwoAYv+EMUPat2JCuzVI3610NKDE/7ddHoy+p+VMq1Q2EdVVhfzQMf 1iQHg2xss4j/875dF2e4OMUH9WIwSvnYJAt19SakOFIv8TJS5+UlJoB3Fyv1hyIL8YFIl+Uo52x ax7fYdexkqD2tsLlYApyfJ8x++WQj3+SlwpZc63/AK09L96rUld X-Received: by 2002:a05:6512:3f24:b0:5b8:f533:d439 with SMTP id 2adb3069b0e04-5bcde8c1acdmr1016443e87.38.1791568093888; Fri, 09 Oct 2026 10:48:13 -0700 (PDT) Received: from localhost.localdomain (95-24-167-79.broadband.corbina.ru. [95.24.167.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5bcddeb5604sm852635e87.63.2026.10.09.10.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2026 10:48:12 -0700 (PDT) From: Maxim Skokov To: bpf@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, memxor@gmail.com, emil@etsalapatis.com, ihor.solodrai@linux.dev, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, vadim.fedorenko@linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Maxim Skokov Subject: [PATCH bpf v2 0/2] bpf: test_run: Fix false -EBADMSG with BPF_F_TEST_SKB_CHECKSUM_COMPLETE Date: Fri, 9 Oct 2026 20:47:46 +0300 Message-ID: <20261009174755.22026-1-skokovmaksimevg@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit BPF_PROG_TEST_RUN with BPF_F_TEST_SKB_CHECKSUM_COMPLETE returns -EBADMSG for correct tc programs that call bpf_skb_change_tail(). The helper moves the skb to CHECKSUM_NONE and leaves skb->csum stale, but the post-run check added by commit a3cfe84cca28 ("bpf: Add CHECKSUM_COMPLETE to bpf test progs") still compares against it. Patch 1 only does the check while the skb is still CHECKSUM_COMPLETE. Patch 2 adds selftests for a trim, a grow followed by a write, and a negative case that keeps the skb CHECKSUM_COMPLETE with a stale skb->csum. Tested in a VM on bpf, with two kernels that differ only by patch 1 (subtest results): without patch 1 with patch 1 change_tail_trim FAIL (-EBADMSG) OK change_tail_grow_write FAIL (-EBADMSG) OK store_no_recompute OK OK test_skb_pkt_end OK OK Changes in v2: - Put the opening /* of multi-line comments on its own line (bpf-ci, Sashiko). v1: https://lore.kernel.org/bpf/20261007181249.352831-1-skokovmaksimevg@gmail.com/ Maxim Skokov (2): bpf: test_run: Fix false -EBADMSG after skb leaves CHECKSUM_COMPLETE selftests/bpf: Cover test_run csum validation after bpf_skb_change_tail() net/bpf/test_run.c | 8 +++- .../bpf/prog_tests/skb_csum_complete.c | 39 ++++++++++++++++ .../selftests/bpf/progs/skb_csum_complete.c | 46 +++++++++++++++++++ 3 files changed, 92 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/skb_csum_complete.c create mode 100644 tools/testing/selftests/bpf/progs/skb_csum_complete.c base-commit: ff47652a4b66c067c765a7ad464d930b5a9367cc -- 2.47.3