From: Anton Danilov <littlesmilingcloud@gmail.com>
To: Rachel Menge <rachelmenge@linux.microsoft.com>
Cc: stable@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Request backport of bf5a54bc0e3d to 6.18.y
Date: Sat, 10 Oct 2026 06:59:27 +0300 [thread overview]
Message-ID: <20261010035930.579535-1-littlesmilingcloud@gmail.com> (raw)
In-Reply-To: <899bd843-fd19-418e-8913-91bfb6e760a2@linux.microsoft.com>
On Fri, Oct 09, 2026 at 03:36:42PM -0700, Rachel Menge wrote:
> Please consider applying the following upstream commit to 6.18.y:
>
> bf5a54bc0e3d8962474fcd611f1266eba036232f
> doc/netlink: netlink-raw: Add max check
I see the same on v6.18.55: rt-link-user.h fails since 6.18.53 and
rt-neigh-user.h since 6.18.54, and the in-tree cli.py fails the same
way for both families. With bf5a54bc0e3d on top, make -C tools/net/ynl
passes, and the generated rt-link and rt-neigh code is byte-identical
to a build of the same tree with the two checks hunks dropped.
> I also checked 6.1.y, 6.6.y, 6.12.y, and 6.19.y. Those branches do not
> contain the rt-link.yaml and rt-neigh.yaml checks.max additions that create
> this mismatch, so this request is limited to 6.18.y.
6.12.y is affected too. Since 6.12.111 it carries 45ca9f59b6c7 ("net:
reject oversized tx_queue_len at netlink parse time"), which adds
checks.max to rt_link.yaml (the file name has an underscore there).
6.12.y does not generate C code for netlink-raw specs, so the build is
not affected by this one, but cli.py --spec rt_link.yaml fails with
the same ValidationError.
bf5a54bc0e3d applies to 6.12.y as well. The 6.12.y YNL build has been
broken since 6.12.93 by handshake.yaml, so I sent a 6.12.y series that
fixes that and includes bf5a54bc0e3d:
https://lore.kernel.org/netdev/20261010035116.578385-1-littlesmilingcloud@gmail.com/
One more thing for 6.18.y, not a regression: conntrack.yaml and
nftables.yaml fail the schema check since v6.18 itself ('labels mask'
and 'set id' do not match the attribute name pattern), so cli.py fails
for these two families. Upstream fixed that in 1adc241f3940 ("ynl: fix
schema check errors"), which renames the two attributes to labels-mask
and set-id. It applies cleanly to 6.18.55, and with it and bf5a54bc0e3d
all specs in 6.18.55 pass the schema check. The C build is not affected,
these two families are not generated there.
Tested-by: Anton Danilov <littlesmilingcloud@gmail.com> # v6.18.55
---
Anton Danilov
next prev parent reply other threads:[~2026-10-10 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 22:36 Request backport of bf5a54bc0e3d to 6.18.y Rachel Menge
2026-10-10 3:59 ` Anton Danilov [this message]
2026-10-11 16:48 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261010035930.579535-1-littlesmilingcloud@gmail.com \
--to=littlesmilingcloud@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rachelmenge@linux.microsoft.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox