Re: [PATCH net 0/2] r8169: fix checksum eligibility and failed TX batch progress

[Geert Uytterhoeven <geert@linux-m68k.org>]

	Hi iugfdin,

Thanks for your series!

> This series fixes two TX-path issues found while investigating a report
> of loss with an RTL8125D 2.5GbE controller (PCI revision 0c, XID 688).

Do you have a link to that report?

> The first patch preserves hardware checksum eligibility when a packet is
> already at least as long as the padding target. The second ensures that
> a failed skb does not leave previously committed xmit_more packets
> without a transmit poll request.
>
> Neither patch is claimed to resolve the reported physical packet loss.
> The reporter observed 10-20% loss, particularly at 2.5 Gb/s, while a
> vendor Realtek driver/firmware combination worked. No affected NIC was
> available in the development environment. The reporter identified the
> loaded firmware as rtl8125d-1_0.0.7 10/15/24. A possible firmware-related
> cause of the reported loss remains under separate investigation.

I haven't tested your series, but without it, I see 40% packet loss at
2.5Gbps on the same controller revision, when rtl8125d-1.fw from
linux-firmware is loaded[1].  Forcing a lower speed of 1 Gbps work fine.

With that firmware file moved out of the way, i.e. using the built-in
firmware, 2.5 Gbps works fine for me, too...

[1] "RTL8125D breaks at 2.5Gbps"
    https://lore.kernel.org/CAMuHMdXPAeHoeaQbM9rXbXukoMbFV+0k28n6sRMw8XF8720WUA@mail.gmail.com/

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds