From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAF1C3CB55F for ; Mon, 12 Oct 2026 09:55:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791798922; cv=none; b=dh2Zvye4hnRd3h2QkAloz60kZTlFqwZr8Spl/GhkSybDkLCbDRP3w/vCnWd9d+Kh7/c97youpK2V1RmkGlOfXlUYgfyESqWJwoNobn5hSZw9Hk4jhMfyvSuj/wpS7HR2hZYoTGyiYF6y1zzeDka3eQimsJbkgm+lGPiUn0DJizI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791798922; c=relaxed/simple; bh=sLZ8j+4e09ehCDAv46JbKrWsd4lbBbirQ0NIo/TsacA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GRH5fYlz/bfuWEGp+Ug73ovAdrbkx3X0toORF7VmVxKSZEna9yhCOs2aOUwdt4jNsSmS3PE35KGgOF/OGGzkFsrigNo4FI+yr8KRIH6jMSjPdBYcKhWL48JXgUnB/zw4MfdyUC3xwtc8c2cyHVD/pPRB/zyg2aF2FyyDzVXxO+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=LnhHlmkW; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="LnhHlmkW" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-48b02a2359aso1558485f8f.0 for ; Mon, 12 Oct 2026 02:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1791798915; x=1792403715; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QX8lSFW7S3WysnbG31BxJSIjyuhVgxUvAyesKtj3CLs=; b=LnhHlmkW+o0fkb9PwZonZuPyO2hQNLnTXP+JFZPMme2tecwBmwdbUsq1eSifJPIjbG wxtpjMZP02izprMuo6f24uM2viR1udoJ+Tos1NS7uqQsnd62D+OawFg2jBLRPn37BROe +1vm3BzOp9N8Ksx11So/b3xX6wFkKL3He6RV8lmZPP5q8d5O7JkSPPG+QCSyniL9HhvM s0r8JAHWyXdUG7rd+/B9B6791pf+6uWROtO6d5Rte4AW+iY4AXGnxTbNDzc2HSMFa1Dy YzMi5MpY2figisnWA5CDACsAzYSvvb5N+TaRSKcVUilsjg8LEnhLgoFlGlHiufBg6Etx plkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791798915; x=1792403715; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QX8lSFW7S3WysnbG31BxJSIjyuhVgxUvAyesKtj3CLs=; b=GTnneuNh4m2T9UD6Ks/xOovuBOQ6d4I9lXRGvZVaCy9gTOiWn7NEQ+6PI+/103xV/I J7Bf/8ZWN8IctfCFXBKLTM6SOkjhTRb5zb6zRE5LF3iALDLvWi/BWmFsoh7c6x6T3MVX rmEEz01hao6dbMymgLRbuaw3KNsClSom1s5KRsx2zNPAHUFwN6z05AggHeJ2nWU72IUP p+bTr+UFEbOOimlR7DP/ept6IN6TmLymzrvaW3l23FknPIn1hW+kCjaBh4yqCNjDtl/C IWLKseCuwNJEye/K4ZbGwZHozYq24C6el0Tjkci07GSTJfkaIA6TghHHYTvn0G7VKDyN Cn0w== X-Forwarded-Encrypted: i=1; AKwUvBxIvmizDFSSr0EsbvnHVt5kb9BUxSejR8stiYP0tcfFsRar05bYbeGYwWz70V50KVa3FmXFXeY=@vger.kernel.org X-Gm-Message-State: AFq9FYLcl49EEmG9W8btHAgDYI+uMjQGpgFUZACcwT9dkJIz46oxeZxk fXPlNnMksSD9c5l+JWzRO0TEvIb0zuzS8KBCrLiVDX8MIqJVdGgZPNqH/ZYcmccIF4g= X-Gm-Gg: AYBFou1l0cq37uEch0w+xkwAkZkbmcKmMnMGqWDEy/p0fKiRcOqoAa3SustEQaF05Yl BoL1QHYSV2Rhd2InsfKD2gzHPGGVZK6u8Ed6SAVF9r9ji9ou0hBmep30ESMOIAlEXlbJwKpzyRG qEKgP+ew5wRWDMS7mGKuyAtG1YmTLPURblxkbtFRHxtEiXKhuz2t8TqP1HMaOMxrsOvHOrxRArL 7d5mIgOZ/k13860stkgtZnM6KvRmhIWooYnwfVnfsek+dpbV0kUq+XVbTycPSkAZhIdVRZTc37K lcAFXARpNRUfZAVp8vz7O9UtRr/dD2r0EPYSU6+Z8Gb5eNtInCiZRRRenqzaiTSl/FMY+Ew+QcY aOGzgDJ+93nYviXhDTIH9qmBeWdMI/7BqDurFCzjEflU2tEDB59FiTd8+jz+ChEeKzUe8Xyile9 G8pVL8KbR/zDMJoOMyGyQtrECEWzHS3dJHFddXRs/ARi8GwxOgkDmzekLIOTr6dkG7RubQrK7NT Fd8W+oT2Mfd0ZGHdbxCPA== X-Received: by 2002:a5d:588b:0:b0:48d:deb0:f1a7 with SMTP id ffacd0b85a97d-48ddeb0f1c5mr222734f8f.10.1791798914652; Mon, 12 Oct 2026 02:55:14 -0700 (PDT) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48db98c2800sm18539103f8f.26.2026.10.12.02.55.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2026 02:55:12 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Petko Manolov , linux-usb@vger.kernel.org Subject: [PATCH net-next v4 5/6] net: usb: pegasus: Move long delayed work on system_dfl_long_wq Date: Mon, 12 Oct 2026 11:54:44 +0200 Message-ID: <20261012095452.135828-6-marco.crivellari@suse.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261012095452.135828-1-marco.crivellari@suse.com> References: <20261012095452.135828-1-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently the code enqueue work items using {queue|mod}_delayed_work(), using system_long_wq. This workqueue should be used when long works are expected and it is a per-cpu workqueue. The function(s) end up calling __queue_delayed_work(), which set a global timer that could fire anywhere, enqueuing the work where the timer fired. Unbound works could benefit from scheduler task placement, to optimize performance and power consumption. Long work shouldn't stick to a single CPU. Recently, a new unbound workqueue specific for long running work has been added:     c116737e972e ("workqueue: Add system_dfl_long_wq for long unbound works") Since the workqueue work doesn't rely on per-cpu variables, there is no obvious reason that justify the use of a per-cpu workqueue. So change system_long_wq with system_dfl_long_wq so that the work may benefit from scheduler task placement. Cc: Petko Manolov Cc: linux-usb@vger.kernel.org Signed-off-by: Marco Crivellari Reviewed-by: Sebastian Andrzej Siewior --- drivers/net/usb/pegasus.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index aba1a640fc26..ed3f8d555c2a 100644 --- a/drivers/net/usb/pegasus.c +++ b/drivers/net/usb/pegasus.c @@ -1118,8 +1118,9 @@ static void check_carrier(struct work_struct *work) pegasus_t *pegasus = container_of(work, pegasus_t, carrier_check.work); set_carrier(pegasus->net); if (!(pegasus->flags & PEGASUS_UNPLUG)) { - queue_delayed_work(system_long_wq, &pegasus->carrier_check, - CARRIER_CHECK_DELAY); + queue_delayed_work(system_dfl_long_wq, + &pegasus->carrier_check, + CARRIER_CHECK_DELAY); } } @@ -1223,7 +1224,7 @@ static int pegasus_probe(struct usb_interface *intf, res = register_netdev(net); if (res) goto out3; - queue_delayed_work(system_long_wq, &pegasus->carrier_check, + queue_delayed_work(system_dfl_long_wq, &pegasus->carrier_check, CARRIER_CHECK_DELAY); dev_info(&intf->dev, "%s, %s, %pM\n", net->name, info ? info->name : "(unknown)", net->dev_addr); @@ -1288,7 +1289,7 @@ static int pegasus_resume(struct usb_interface *intf) pegasus->intr_urb->actual_length = 0; intr_callback(pegasus->intr_urb); } - queue_delayed_work(system_long_wq, &pegasus->carrier_check, + queue_delayed_work(system_dfl_long_wq, &pegasus->carrier_check, CARRIER_CHECK_DELAY); return 0; } -- 2.55.0