From: Ido Schimmel <idosch@nvidia.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
edumazet@kernel.org, dsahern@kernel.org, horms@kernel.org,
rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, daniel@iogearbox.net,
petrm@nvidia.com, ferenc@fejes.dev
Subject: Re: [PATCH net-next v2 0/3] Report netns cookie in FIB lookup tracepoints
Date: Tue, 13 Oct 2026 20:45:33 +0300 [thread overview]
Message-ID: <20261013174533.GA1114705@shredder> (raw)
In-Reply-To: <43857d08-c4f4-44ce-a0b3-0e7fcc56bf90@redhat.com>
On Tue, Oct 13, 2026 at 12:25:56PM +0200, Paolo Abeni wrote:
> Not intended to block the above (could be eventually a follow-up), but
> I'm wondering if you have considered adding a `net` (or net_cookie) field
> to the fib_table struct instead of passing the net as an additional argument
> to the lookup functions - AFAICS the latter are also called in critical
> path and the additional arg could be unneeded (very small) overhead.
Makes sense.
I tried to be consistent with IPv6, but fib6_table_lookup() needs the
netns argument regardless of the tracepoint. The fib_table struct still
fits in a single cache line with the new field. Will send the patches
tomorrow.
next prev parent reply other threads:[~2026-10-13 17:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 13:31 [PATCH net-next v2 0/3] Report netns cookie in FIB lookup tracepoints Ido Schimmel
2026-10-08 13:31 ` [PATCH net-next v2 1/3] ipv6: Report netns cookie in fib6_table_lookup tracepoint Ido Schimmel
2026-10-10 13:33 ` David Ahern
2026-10-08 13:31 ` [PATCH net-next v2 2/3] ipv4: Pass netns to fib_table_lookup() Ido Schimmel
2026-10-10 13:34 ` David Ahern
2026-10-08 13:31 ` [PATCH net-next v2 3/3] ipv4: Report netns cookie in fib_table_lookup tracepoint Ido Schimmel
2026-10-10 13:34 ` David Ahern
2026-10-13 10:25 ` [PATCH net-next v2 0/3] Report netns cookie in FIB lookup tracepoints Paolo Abeni
2026-10-13 17:45 ` Ido Schimmel [this message]
2026-10-13 10:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013174533.GA1114705@shredder \
--to=idosch@nvidia.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=ferenc@fejes.dev \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox