From: Alex Elder <elder@riscstar.com>
To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com
Cc: Daniel Thompson <daniel@riscstar.com>,
donggeunyoo.kernel@gmail.com, ansuelsmth@gmail.com,
mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com,
danielt@kernel.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next] net: phy: qcom: qca808x: Add regulator management
Date: Wed, 14 Oct 2026 12:22:59 -0500 [thread overview]
Message-ID: <20261014172300.292324-1-elder@riscstar.com> (raw)
From: Daniel Thompson <daniel@riscstar.com>
QCA8081 appears in embedded board designs paired with GPIO controlled
regulators for its power rails. Add logic to allow these regulators to
be turned on during a probe.
In order to avoid the complexity of tracking state for suspend with and
without WoL we take a tremendously simple "always-on" approach to
regulator management, essentially relying on BMCR_PDOWN to conserve
power when the phy device exists.
Signed-off-by: Daniel Thompson <daniel@riscstar.com>
Co-developed-by: Alex Elder <elder@riscstar.com>
Signed-off-by: Alex Elder <elder@riscstar.com>
---
drivers/net/phy/qcom/qca808x.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/drivers/net/phy/qcom/qca808x.c b/drivers/net/phy/qcom/qca808x.c
index bab26e4c61408..6e2bd753257d9 100644
--- a/drivers/net/phy/qcom/qca808x.c
+++ b/drivers/net/phy/qcom/qca808x.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0+
#include <linux/phy.h>
+#include <linux/regulator/consumer.h>
#include <linux/module.h>
#include "qcom.h"
@@ -181,15 +182,44 @@ static void qca808x_fill_possible_interfaces(struct phy_device *phydev)
__set_bit(PHY_INTERFACE_MODE_2500BASEX, possible);
}
+static int qca808x_power_on(struct phy_device *phydev)
+{
+#ifdef CONFIG_OF
+ static const char * const regulator_names[] = {
+ "avdd18", "vdd", "vdd18", "vdd125"
+ };
+ struct device *dev = &phydev->mdio.dev;
+ u32 count = 0;
+ int i, ret;
+
+ for (i = 0; i < ARRAY_SIZE(regulator_names); i++) {
+ ret = devm_regulator_get_enable_optional(dev, regulator_names[i]);
+ if (!ret)
+ count++;
+ else if (ret != -ENODEV)
+ return ret;
+ }
+
+ if (count)
+ fsleep(phydev->mdio.reset_assert_delay);
+#endif
+ return 0;
+}
+
static int qca808x_probe(struct phy_device *phydev)
{
struct device *dev = &phydev->mdio.dev;
struct qca808x_priv *priv;
+ int ret;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
+ ret = qca808x_power_on(phydev);
+ if (ret)
+ return ret;
+
priv->led_polarity_mode = QCA808X_PHY_LED_UNSET;
phydev->priv = priv;
--
2.53.0
next reply other threads:[~2026-10-14 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 17:22 Alex Elder [this message]
2026-10-14 17:36 ` [PATCH net-next] net: phy: qcom: qca808x: Add regulator management Andrew Lunn
2026-10-14 20:41 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014172300.292324-1-elder@riscstar.com \
--to=elder@riscstar.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=daniel@riscstar.com \
--cc=danielt@kernel.org \
--cc=davem@davemloft.net \
--cc=donggeunyoo.kernel@gmail.com \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=mohd.anwar@oss.qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox