Re: [PATCH net v3] net/smc: fix abort_work termination in smc_conn_free()

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

On 2026-10-06 09:35:50 [+0200], Hidayath Khan wrote:
> --- a/net/smc/smc_core.c
> +++ b/net/smc/smc_core.c
> @@ -1251,9 +1251,13 @@ static void smc_buf_unuse(struct smc_connection *conn,
>  	}
>  }
>  
> -/* remove a finished connection from its link group */
> +/* remove a finished connection from its link group.
> + * Must be called with the socket lock held: conn->freed is what disarms
> + * a pending or running abort_work, and both are set and tested under it.
> + */

If so, sock_owned_by_me(conn->sk) would verify it at runtime, right?

>  void smc_conn_free(struct smc_connection *conn)
>  {
> +	struct smc_sock *smc = container_of(conn, struct smc_sock, conn);
>  	struct smc_link_group *lgr = conn->lgr;
>  
>  	if (!lgr || conn->freed)

This change looks reasonable. sashiko complains that smc_conn_create()
will reset conn->freed. Does this make sense to you?
I *think* the connection is cleaned up and it shouldn't happen but then
I just started looking at this a while ago.

Sebastian