From: Ido Schimmel <idosch@nvidia.com>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: Til Kaiser <mail@tk154.de>,
netdev@vger.kernel.org, stable@vger.kernel.org,
Petr Machata <petrm@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jiri Pirko <jiri@resnulli.us>,
Vadim Pasternak <vadimp@mellanox.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] mlxsw: Initialize register query payloads
Date: Thu, 15 Oct 2026 18:59:44 +0300 [thread overview]
Message-ID: <20261015155944.GA1836432@shredder> (raw)
In-Reply-To: <87a4of8kw1.fsf@all.your.base.are.belong.to.us>
On Thu, Oct 15, 2026 at 09:48:14AM +0200, Björn Töpel wrote:
> Hmm, isn't this pointing to that the query should be more robust,
> instead of relying on zeroing receive buffers pre-call? Maybe just fixup
> query instead?
Most registers require an index, so the common pattern is:
mlxsw_reg_*_pack(...);
mlxsw_reg_query(...);
Where the pack function zeroes the payload. We can't zero in the core
because then we would overwrite the indexes.
next prev parent reply other threads:[~2026-10-15 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 17:31 [PATCH net] mlxsw: Initialize register query payloads Til Kaiser
2026-10-15 7:48 ` Björn Töpel
2026-10-15 15:59 ` Ido Schimmel [this message]
2026-10-15 16:00 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015155944.GA1836432@shredder \
--to=idosch@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=bjorn@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@tk154.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox