From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Ömer Mete Kaya" <omermetekaya0@gmail.com>,
oneukum@suse.com, netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
david.laight.linux@gmail.com,
syzbot+04cd90bb99c6ef81a65d@syzkaller.appspotmail.com
Subject: Re: [PATCH] USB: Documentation: Update description of completion callback context
Date: Thu, 15 Oct 2026 20:26:43 +0200 [thread overview]
Message-ID: <20261015182643.MIjjSTAr@linutronix.de> (raw)
In-Reply-To: <de582feb-a0aa-4fc8-9818-890014de32a9@rowland.harvard.edu>
On 2026-10-15 12:00:46 [-0400], Alan Stern wrote:
> The existing kerneldoc documentation for URB completion callbacks is
> incorrect about the context in which the callbacks occur; it is not
> always in_interrupt. State explicitly that a callback may occur in
> any context with no guarantees, and likewise for the status of
> CPU-local interrupts.
>
> Documentation update only; no code changes.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
usb_hcd_giveback_urb() kernel doc says:
| * Context: atomic. The completion callback is invoked either in a work queue
| * (BH) context or in the caller's context, depending on whether the HCD_BH
| * flag is set in the @hcd structure, except that URBs submitted to the
| * root hub always complete in BH context.
Do you think this deserves an update?
Sebastian
next prev parent reply other threads:[~2026-10-15 18:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 21:59 [PATCH net v6] usbnet: fix smp_processor_id() use in preemptible context Ömer Mete Kaya
2026-10-08 3:00 ` Jakub Kicinski
2026-10-08 14:16 ` Alan Stern
2026-10-08 16:43 ` Jakub Kicinski
2026-10-08 18:03 ` Alan Stern
2026-10-09 11:31 ` Greg Kroah-Hartman
2026-10-12 19:49 ` Sebastian Andrzej Siewior
2026-10-12 20:26 ` Alan Stern
2026-10-12 21:25 ` Sebastian Andrzej Siewior
2026-10-13 2:09 ` Alan Stern
2026-10-13 9:11 ` Paolo Abeni
2026-10-13 9:22 ` Sebastian Andrzej Siewior
2026-10-14 19:11 ` Sebastian Andrzej Siewior
2026-10-14 19:22 ` Alan Stern
2026-10-14 22:04 ` Sebastian Andrzej Siewior
2026-10-15 16:00 ` [PATCH] USB: Documentation: Update description of completion callback context Alan Stern
2026-10-15 18:26 ` Sebastian Andrzej Siewior [this message]
2026-10-15 18:35 ` Alan Stern
2026-10-13 8:54 ` [PATCH net v6] usbnet: fix smp_processor_id() use in preemptible context Oliver Neukum
2026-10-13 9:20 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261015182643.MIjjSTAr@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=omermetekaya0@gmail.com \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+04cd90bb99c6ef81a65d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox