From: Anil Kaushik <anilkaushikwireless@gmail.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>,
Harald Welte <laforge@gnumonks.org>,
Donald Hunter <donald.hunter@gmail.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <sdf.kernel@gmail.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
osmocom-net-gprs@lists.osmocom.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Anil Kaushik <anilkaushikwireless@gmail.com>
Subject: [PATCH net-next v7 0/4] gtp: ynl spec for the GTP netlink family, two fixes, and a selftest
Date: Fri, 16 Oct 2026 09:32:21 +0000 [thread overview]
Message-ID: <20261016093225.1036375-1-anilkaushikwireless@gmail.com> (raw)
This adds a ynl spec for the gtp genetlink family, two small driver
fixes, and a selftest.
Patch 1: the GET and dump replies carried the family id in the command
field, so ynl dropped them. Use GTP_CMD_GETPDP instead.
Patch 2: new in v7. On the netdev CI debug kernel, the selftest hit an
RCU warning: adding a PDP context looks up the device without the RCU
read lock. Hold it around the lookup.
Patch 3: the spec (NEWPDP/DELPDP/GETPDP/ECHOREQ), no uapi change.
Patch 4: a selftest that adds, dumps and deletes PDP contexts.
The multicast notifications are not in the spec: they reuse the request
command values, which the ynl C generator can't express with the
current uapi header.
v7:
- new patch 2: fix the RCU warning the selftest found on debug kernels
- selftest: add a docstring to GtpFamily (pylint)
- Cc Stanislav for lib/py
v6:
- spec: use the gtp_version uapi enum for the version attribute
- spec: family only applies to the MS address, fix its doc
- selftest: also skip on "Unknown device type", printed by iproute2
with extack support when the kernel has no gtp
v5:
- ynl: add CFLAGS_gtp so the generated code builds with older headers
- spec: doc fixes, min-len for the IPv6 attributes
- selftest: only skip when GTP is unavailable, close the ynl handle
v4:
- spec: request/reply attributes now match the handlers
- selftest: fix the gtp.ko autoload crash, check ENOENT, delete by
TEI and by MS address
v6: https://lore.kernel.org/netdev/20261013031000.528393-1-anilkaushikwireless@gmail.com/
v5: https://lore.kernel.org/netdev/20261012024800.400616-1-anilkaushikwireless@gmail.com/
v4: https://lore.kernel.org/netdev/20261010105740.223992-1-anilkaushikwireless@gmail.com/
v3: https://lore.kernel.org/netdev/20261009060615.4177402-1-anilkaushikwireless@gmail.com/
v2: https://lore.kernel.org/netdev/20261008181031.4129029-1-anilkaushikwireless@gmail.com/
Anil Kaushik (4):
gtp: set a valid genl command in PDP context get and dump replies
gtp: hold RCU for the device lookup when adding a PDP context
netlink: specs: add genetlink-legacy spec for GTP
selftests: net: add a test for the gtp netlink family
Documentation/netlink/specs/gtp.yaml | 196 ++++++++++++++++++
MAINTAINERS | 2 +
drivers/net/gtp.c | 7 +-
tools/net/ynl/Makefile.deps | 1 +
tools/testing/selftests/net/Makefile | 1 +
tools/testing/selftests/net/config | 1 +
tools/testing/selftests/net/gtp.py | 123 +++++++++++
.../testing/selftests/net/lib/py/__init__.py | 5 +-
tools/testing/selftests/net/lib/py/ynl.py | 9 +-
9 files changed, 340 insertions(+), 5 deletions(-)
create mode 100644 Documentation/netlink/specs/gtp.yaml
create mode 100755 tools/testing/selftests/net/gtp.py
--
2.25.1
next reply other threads:[~2026-10-16 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 9:32 Anil Kaushik [this message]
2026-10-16 9:32 ` [PATCH net-next v7 1/4] gtp: set a valid genl command in PDP context get and dump replies Anil Kaushik
2026-10-16 9:32 ` [PATCH net-next v7 2/4] gtp: hold RCU for the device lookup when adding a PDP context Anil Kaushik
2026-10-16 9:32 ` [PATCH net-next v7 3/4] netlink: specs: add genetlink-legacy spec for GTP Anil Kaushik
2026-10-16 9:32 ` [PATCH net-next v7 4/4] selftests: net: add a test for the gtp netlink family Anil Kaushik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016093225.1036375-1-anilkaushikwireless@gmail.com \
--to=anilkaushikwireless@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=sdf.kernel@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox