Re: [PATCH net-next v9 6/8] hsr: Assign a socket for cloned skbs

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

On 2026-10-16 11:34:44 [+0200], Daniel Machon wrote:
> > The cloned skb does not have a socket information recorded of
> > the original skb. The original skb is never submitted. This means the
> > requested timestamp information gets lost.
> > 
> > This does not consider PRP part of the stack. The specification says
> > that PTP-PRP packets do not have the RCT therefore these packages can be
> > sent directly from userland skipping the stack.
> > 
> > Assign the socket of the original skb to the clone so the timestamp is
> > forwarded to the user.
> 
> The commit description seems right, but is maybe a little vague. Could go a
> little more into detail about the effect: skb_clone() clears skb->sk, and
> skb_tstamp_tx() drops the timestamp when there is no socket, so without this
> ptp4l never gets its TX timestamp.
> 
> nits:
> 
> s/a socket information/the socket/
> s/these packages/these packets/

Okay, will do.

Sebastian