From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91A264446FA for ; Fri, 16 Oct 2026 21:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792186949; cv=none; b=h9YzWEdxidWi+rCEtV8SW6xvhEfLUfisSti9ETYeFsvDaFzspA8xXZDSkGzXRQTDTxJhHxK7s/DSf2jeMORgv3BeKGz1DE9CNeslO1AJJWUYEzQKQXSRporrsFN/K37pLFkyRr+cKdoV0ap1yKX85T+7IBuyWOFsvO/grWJ6qjc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792186949; c=relaxed/simple; bh=cRk62IXda5uswUNfWyJKtpQk+IUO0CMGpvz/RtOq/48=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UNd3tK4tHn5xU9gp0BVzrDHhygEUXTppcZxIdeD6w2LIgQItptBMb6QpET55WO5EzPcI3U22RilxuOzMbjrrdOBjQt9LPZqDhx4SUWsKpWnoxJWR1/yAMxMh5RnmLeAevx3+c2a8aUXihJqp7BScm54vP1qMQ9fc+JahVTkKzyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=TI9pjIOO; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="TI9pjIOO" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-48c4be28b82so265120f8f.2 for ; Fri, 16 Oct 2026 14:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1792186946; x=1792791746; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UPEvAm5BD4qdGQ/byj1NqbzTLMKiUg8kVp/CFRsEQdc=; b=TI9pjIOOH8D/xZcai98/MNaAB4CkNadbDB4xQg8ITwsWOr2A8CXjUzH98u3fyInJ0W ZWhmMSQXhQlQ96RGeg7o189PHPKUDwWiZUxvZn+MdgX97GMLsM+TcWOiG58KmMeWOhW1 KhKKOaJP5c3ywXBwimsZrJXuPHahIJX8fvmOdluLxRizyRKzdC5Yoc4t0GQN/IwOyybk VdXbN+umruHzAFVTQ532+G7FpClgaDLYmWJoXXQJA3kFd1UtNEIO9P+ouKueJpRAx/oV g16RDLoAFwJ2xpU47kUwFLKhuZBA+ecWwmlIa8dUooRGuTsW7J/HjmNqPLil6rjvlJYm 5OFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792186946; x=1792791746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=UPEvAm5BD4qdGQ/byj1NqbzTLMKiUg8kVp/CFRsEQdc=; b=mpW65trOGaWjxpsCxR5XJpEARRANGSVfuvCQEUeTKL+KDn/x7HQZGEucf5KT3ps3cV 2nLUQof6oT0PnwEkv2P7KjpIzUxtfTV3l6fBB3GAWEY2U1Mr1rMnnqqhGMNCcvAeOg5B siPptBBWTW2iMs4uZ1mK44PIYLRXKjDO7zaoBCvGGT37GzqIRN2po7jIFyubsnLKVnGo QisLy4dPUS2mhRRacYFW+sqRDGOTE4vYg2/JtvSuB8hh6XGo/wVYn9dx5TIp77RxSjBM tJj9CfKMH5niDAF+1IOVUcA/w8AEdF3CV+wBEPGOLi34buRVBldw27yw5V851qUo+qU3 uowg== X-Gm-Message-State: AFq9FYJ87fDj8fNvnh3yPxTTqu9XgUuJOtLVNJS2Y6dKpCPf7q45Pmbo qPfUksnHx1mYV0uVGVDUBRIF6gUxhPuRzoAXc46y8F1USZulo6nR2ZfmPZk9WQMZWAuafGBJnIj HnOPmLFo= X-Gm-Gg: AYBFou0PXFyOnxaOu4h2QiL2wtYw0I9C57+3PPQudekpJDFHQ9PsJ/wss/bU1NovxnX sL3tDMFSRrllrdra98q34azXus21WL11UsrPL9ED5KesHB7Nqx9xdIDXPbp1wB7g3+JzNF8RiFO DNBubF4izgibJrLGWibevArepx7YKM51fznGEvm4f+L2o0ZzQoHokpLE/HnbZEmUaStrCpOugiY u02o+jNmn4wFXqrq8YdkJo1pSLF/aYBeB/0fBHK8o1PpeW4AMzQVzfzGK7Mpk61sMUr6SmmlsmQ kHM66r4RWpQW6E//a9PqRRZqEYz0B0LxqZK3AE9SxjdgZmsl9OXsYhPbD0NZrHxUmb1dK+XrA6f XS9MDHsN/641EMBL+0NRdMqhmHA+Uo3D+xdWDn1lZX/4oyRiUJC9Ua1wkJX7iSaehrHfKOyZVol fqykQ210VaPmDZmxnlXLVA3vK1cBsAJvdUj5IQNfb5kRqhkkWTxfIjV6NQNndnP4IOQyjdOZHNL oKFZlwcvT/y72JcAA== X-Received: by 2002:a5d:53c6:0:b0:48e:37e:470f with SMTP id ffacd0b85a97d-48e07fbbe8cmr1143983f8f.51.1792186945722; Fri, 16 Oct 2026 14:42:25 -0700 (PDT) Received: from D90XRJJJNQ ([2a09:bac6:37af:ec8::179:190]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd4f8bb6sm7975417f8f.34.2026.10.16.14.42.22 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 16 Oct 2026 14:42:24 -0700 (PDT) From: Tianyi Gao To: netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, toke@redhat.com, horms@kernel.org, bpf@vger.kernel.org, shuah@kernel.org, hawk@kernel.org, kernel-team@cloudflare.com, ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, sdf@fomichev.me, linux-kselftest@vger.kernel.org, bochaolucky@gmail.com, toshiaki.makita1@gmail.com, lorenzo@kernel.org, Tianyi Gao Subject: [PATCH net 1/2] veth: schedule the peer's NAPI after XDP_TX when only GRO is enabled Date: Fri, 16 Oct 2026 22:42:16 +0100 Message-ID: <20261016214217.16942-2-tianyi@cloudflare.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261016214217.16942-1-tianyi@cloudflare.com> References: <20261016214217.16942-1-tianyi@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit veth_xdp_xmit() queues XDP_TX frames on the peer's ring if the peer has NAPI. A peer with GRO enabled and no XDP program also has NAPI. veth_xdp_flush() then schedules the peer's NAPI, but only if the peer's xdp_prog is set, so for such a peer the frames are never processed. Nothing else schedules that NAPI by default. Once the ring is full, every XDP_TX frame is dropped, and so are the skbs that veth_xmit() queues on the same ring. Commit 0e672f306a28 ("veth: check for NAPI instead of xdp_prog before xmit of XDP frame") changed the check in veth_xdp_xmit() but not the one in veth_xdp_flush(). Make veth_xdp_flush() check the napi pointer instead of xdp_prog, as veth_xdp_xmit() does. Fixes: 0e672f306a28 ("veth: check for NAPI instead of xdp_prog before xmit of XDP frame") Signed-off-by: Tianyi Gao --- drivers/net/veth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 643b97dc5245..9405ffac598a 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -612,7 +612,7 @@ static void veth_xdp_flush(struct veth_rq *rq, struct veth_xdp_tx_bq *bq) rcv_priv = netdev_priv(rcv); rcv_rq = &rcv_priv->rq[veth_select_rxq(rcv)]; /* xdp_ring is initialized on receive side? */ - if (unlikely(!rcu_access_pointer(rcv_rq->xdp_prog))) + if (unlikely(!rcu_access_pointer(rcv_rq->napi))) goto out; __veth_xdp_flush(rcv_rq); -- 2.55.0