From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta0.migadu.com (out-251.mta0.migadu.com [91.218.175.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 682B7470429 for ; Sat, 17 Oct 2026 14:27:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.251 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792247247; cv=none; b=fJqFAoBSKh35jjeypLSq2VcxQIVpJ0GWtNtcZcE3nE1R2x1dV3brFpw4EoAsmtnY7eYjnrq5nKp3QPVIQb1VZT7F8MJDkW4MyVVINIpKb2TefJ5h/ifXPRysXtfAYDAUYchFaPY3cddMNe4rvoFh5xxfTQ7oKH1XbjOXbYUZKXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792247247; c=relaxed/simple; bh=63eqARLsksZYc2+ytOPz3Z5mI0xqZyCUpe7oiMRM4z4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VZu3VLwDafsEPZnRA06nw8GsIkOgUWvCZwcLlzcqXYQhYjFzAxLJBVRNYrvzPfebg+SGDFUEhHvu3heIbosoSSY2y8BYQU8GIXgIXuObFLJY8i6gfvhojbg5tkFge8xQatoRpKeOEaGRGWOPJHt/GDVhjUNze7T93WMlv3Sul/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=TJCqglc+; arc=none smtp.client-ip=91.218.175.251 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="TJCqglc+" X-Envelope-To: netdev@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=63eqARLsksZYc2+ytOPz3Z5mI0xqZyCUpe7oiMRM4z4=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1792247244; v=1; x=1792852044; b=TJCqglc+m9TpealZohsvHe/GTlYIjwUBfx4LOmthN51Ubm+NKKLogrKxMHWkn4Gk+zxcRKyY Y7R0SZe8XSIWUgeOj2wPK8oVmJoTz3ZQwzcW8Ws/G1y5LGuLBGSnnuCPZQz/XI98oYHRa0IWZn9 XOwBPfKTWCfVHQbIJreSeUsM= X-Envelope-To: netdev@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 0157b11fd9d11a67; Sat, 17 Oct 2026 14:27:23 +0000 X-Mizu-Trace-ID: 0157b11fd9d11a67 X-Migadu-Flow: FLOW_OUT From: Leon Hwang To: bpf@vger.kernel.org Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Shuah Khan , Kuniyuki Iwashima , Hangbin Liu , Martin Karsten , Masashi Honma , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Leon Hwang Subject: [PATCH bpf-next 2/6] bpf: Add syscall common attrs support for xdp link_create Date: Sat, 17 Oct 2026 22:26:45 +0800 Message-ID: <20261017142649.51047-3-leon.hwang@linux.dev> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261017142649.51047-1-leon.hwang@linux.dev> References: <20261017142649.51047-1-leon.hwang@linux.dev> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With the syscall common attrs support for link_create, add syscall common attrs support for xdp link_create in order to report the invalid target ifindex error and the underlying driver's error. Signed-off-by: Leon Hwang --- include/linux/netdevice.h | 3 ++- kernel/bpf/syscall.c | 2 +- net/core/dev.c | 6 +++++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 3cff2174dc03..4548b0fd824d 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -4417,7 +4417,8 @@ struct sk_buff *validate_xmit_skb_list(struct sk_buff *skb, struct net_device *d struct sk_buff *dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev, struct netdev_queue *txq, int *ret); -int bpf_xdp_link_attach(const union bpf_attr *attr, struct bpf_prog *prog); +int bpf_xdp_link_attach(const union bpf_attr *attr, struct bpf_prog *prog, + struct bpf_verifier_log *log); u8 dev_xdp_prog_count(struct net_device *dev); int netif_xdp_propagate(struct net_device *dev, struct netdev_bpf *bpf); int dev_xdp_propagate(struct net_device *dev, struct netdev_bpf *bpf); diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 252b479937a4..e96d5f09486f 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c @@ -5921,7 +5921,7 @@ static int link_create(union bpf_attr *attr, bpfptr_t uattr, struct bpf_common_a break; #ifdef CONFIG_NET case BPF_PROG_TYPE_XDP: - ret = bpf_xdp_link_attach(attr, prog); + ret = bpf_xdp_link_attach(attr, prog, log); break; case BPF_PROG_TYPE_SCHED_CLS: if (attr->link_create.attach_type == BPF_TCX_INGRESS || diff --git a/net/core/dev.c b/net/core/dev.c index 18dc88990510..fdc1de21f358 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -97,6 +97,7 @@ #include #include #include +#include #include #include #include @@ -10771,7 +10772,8 @@ static const struct bpf_link_ops bpf_xdp_link_lops = { .update_prog = bpf_xdp_link_update, }; -int bpf_xdp_link_attach(const union bpf_attr *attr, struct bpf_prog *prog) +int bpf_xdp_link_attach(const union bpf_attr *attr, struct bpf_prog *prog, + struct bpf_verifier_log *log) { struct net *net = current->nsproxy->net_ns; struct bpf_link_primer link_primer; @@ -10784,6 +10786,7 @@ int bpf_xdp_link_attach(const union bpf_attr *attr, struct bpf_prog *prog) dev = dev_get_by_index(net, attr->link_create.target_ifindex); if (!dev) { rtnl_unlock(); + bpf_log(log, "Invalid target_ifindex.\n"); return -EINVAL; } @@ -10812,6 +10815,7 @@ int bpf_xdp_link_attach(const union bpf_attr *attr, struct bpf_prog *prog) if (err) { link->dev = NULL; bpf_link_cleanup(&link_primer); + bpf_log(log, extack._msg); trace_bpf_xdp_link_attach_failed(extack._msg); goto out_put_dev; } -- 2.55.0