From: Stephen Hemminger <stephen@networkplumber.org>
To: Dave Seddon <dave.seddon.ca@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 3/3] testsuite: add bond slave LACP port state test
Date: Mon, 19 Oct 2026 10:19:06 -0700 [thread overview]
Message-ID: <20261019101906.6933fc2c@phoenix.local> (raw)
In-Reply-To: <20261011032906.1398174-4-dave.seddon.ca@gmail.com>
On Sat, 10 Oct 2026 20:29:06 -0700
Dave Seddon <dave.seddon.ca@gmail.com> wrote:
> diff --git a/.gitignore b/.gitignore
> index e5234a3d..a16f6362 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -39,3 +39,4 @@ testsuite/results
> testsuite/iproute2/iproute2-this
> testsuite/tools/generate_nlmsg
> testsuite/tests/ip/link/dev_wo_vf_rate.nl
> +testsuite/tests/ip/link/bond_slave_partner_*.nl
Just skip all .nl files there
testsuite/tests/ip/link/*.nl
> +
> +# IFLA_BOND_SLAVE_AD_PARTNER_OPER_PORT_STATE is a u16 on the wire; the
> +# actor state next to it is a u8. Each row decodes one blob written by
> +# tools/generate_nlmsg and checks the printed value.
> +#
> +# The synthetic 0x0100 state checks the full attribute width on either
> +# endian: a u8 reader returns 0 on little-endian and 1 on big-endian.
> +#
> +# row: file suffix | description | expected regex (!regex: must be absent)
> +while IFS='|' read -r suffix desc expect; do
That comment reads like it was AI generated. Wordy, awkward phrasing
and unnecessary.
next prev parent reply other threads:[~2026-10-19 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 3:29 [PATCH iproute2 0/3] iplink: bond: fix partner LACP state decoding Dave Seddon
2026-10-11 3:29 ` [PATCH iproute2 1/3] iplink_bond_slave: read ad_partner_oper_port_state as u16 Dave Seddon
2026-10-11 3:29 ` [PATCH iproute2 2/3] testsuite: fix test_on_not on multi-line output Dave Seddon
2026-10-11 3:29 ` [PATCH iproute2 3/3] testsuite: add bond slave LACP port state test Dave Seddon
2026-10-19 17:19 ` Stephen Hemminger [this message]
2026-10-20 19:28 ` dave seddon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261019101906.6933fc2c@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dave.seddon.ca@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox