From: Grische <opensource@grische.xyz>
To: netdev@vger.kernel.org
Cc: maxime.chevallier@bootlin.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, Oleksij Rempel <o.rempel@pengutronix.de>,
Grische <opensource@grische.xyz>
Subject: [PATCH net 0/3] net: stmmac: deliver frames with Rx checksum errors to the stack
Date: Tue, 20 Oct 2026 21:03:15 +0200 [thread overview]
Message-ID: <20261020190319.884375-1-opensource@grische.xyz> (raw)
On dwmac1000 the MAC drops every frame that fails Rx checksum validation
before the driver sees it. The enhanced descriptor parser would discard
such a frame even if the MAC delivered it. As a result, a VXLAN tunnel
over IPv6 with zero UDP checksums receives nothing while Rx checksum
offload is on, and neither rx_dropped nor rx_errors shows the loss.
Patches 2 and 3 deliver these frames with CHECKSUM_NONE instead, as
commit fe4042797651 ("net: stmmac: dwmac4: stop hardware from dropping
checksum-error packets") did for dwmac4.
Patch 1 makes the AF_XDP zero-copy Rx path honour the checksum error
status. That path already receives such frames on dwmac4, and patches
2 and 3 make them reach it on dwmac1000 as well.
Tested on an Aruba AP-325 (ipq806x-gmac-dwmac) on the net tree, with
and without the series.
Not tested:
- Patch 1 was only compile-tested, as an AF_XDP zero-copy setup was not
available.
- dwmac-loongson, which also uses dwmac1000_dma_ops.
Grische (3):
net: stmmac: honour Rx checksum errors in the AF_XDP zero-copy path
net: stmmac: dwmac1000: don't discard frames with only a checksum
error
net: stmmac: dwmac1000: stop hardware from dropping checksum-error
packets
drivers/net/ethernet/stmicro/stmmac/dwmac1000.h | 1 +
drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c | 2 ++
drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 9 +++++----
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 +++++---
4 files changed, 13 insertions(+), 7 deletions(-)
base-commit: 6dc989ea46b96ce170840174b4a38c4a387fb005
--
2.54.0
next reply other threads:[~2026-10-20 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 19:03 Grische [this message]
2026-10-20 19:03 ` [PATCH net 1/3] net: stmmac: honour Rx checksum errors in the AF_XDP zero-copy path Grische
2026-10-20 19:03 ` [PATCH net 2/3] net: stmmac: dwmac1000: don't discard frames with only a checksum error Grische
2026-10-20 19:03 ` [PATCH net 3/3] net: stmmac: dwmac1000: stop hardware from dropping checksum-error packets Grische
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020190319.884375-1-opensource@grische.xyz \
--to=opensource@grische.xyz \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox