From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792527202; b=oISDEsO1HL+zsLX+rrtbHebDuVW/UOCEKgWfAxAOFDFjDZdOyDql+qiEX9k+Aqc1NYM9 sFleYBf9cZ653p2Gjp3jB7n25sCBpzUDUKe100szvBB9lo0zA4vzl2gnb+fikdMWRmLT2 lKoHDDZHHHayglueqc6qn/uozp3wxGxFguMtrC4kc1tIWC1sRNJhLyivZ6fFeROZUZ0gy tDbrS7wFydP709RUksSxkxqgNTGUyu1fDU0EC6vARNIKknaHL6XPc7LooVxxo8JaWdElt ftHWnivaHXqp85Ppwo0OvTsM8NurfnApML5KQhv3keEaewvaREkpuMw80GqPTR7FRGQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792527202; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:From:To:Cc:Subject:Date: Message-ID:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Scanned-By; bh=Qo9Ppo5q3VnHIO8t+aXj5yvwX/4F+oOdxjtXzdWzdMc=; b=sAN5a/vSo8Qp3+k2dFpjg/97IiIQWRAsTlhjCWfcQKdSceWnZnxWWUrG8VKfDnernwqD y01ByYJYBV71Wmjjoz8FS5FxAmVnDM3UYmvJnRYWZaP4Lgmx3A5epUKiwObU6rCytRXxG j9H4lwpMCoMcnYorTNaS6iSGffKIPeXEnLC4tPrkx6BxLTXOTEoPoN/HebZ3SVxIGg504 vqLN8q5BGdrP3So9Wv/fm/QncIcPypl8c3PdTomPE+2EPbYjWQ7TySB3dL/QVpRsdI2cs /MVzdm4eV875EIYVHS8uIlZD9oXTu3WjYeTGq9O9/ZczM7zDn5JBjy3EOgjg/DFwDjQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RxPdzXWE; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBB14606A323 for ; Tue, 20 Oct 2026 20:13:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BBB14606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RxPdzXWE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792527200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qo9Ppo5q3VnHIO8t+aXj5yvwX/4F+oOdxjtXzdWzdMc=; b=RxPdzXWEFC19DxIBk0u9ob6K83bvN8UxA0iW0crOw020KreUQlTyr4Y4pbaxSlIvJY64TI kYy55u5AH7Qbj0RKbiRQI8LekUk3isUlnpMEsozs0g2tmdtWbzZFBvYHLLXg8f69lyrc4z QlDX8IrdKnt9kLzef0o2+LhKgqF6FBU= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-GzR7d1bVMoONPaFrF8I47A-1; Tue, 20 Oct 2026 20:13:15 +0000 X-MC-Unique: GzR7d1bVMoONPaFrF8I47A-1 X-Mimecast-MFC-AGG-ID: GzR7d1bVMoONPaFrF8I47A_1792527193 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5A4B0194510D; Tue, 20 Oct 2026 20:13:13 +0000 (UTC) Received: from warthog.com (unknown [10.44.48.29]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 948B5195608B; Tue, 20 Oct 2026 20:13:09 +0000 (UTC) From: David Howells To: netdev@vger.kernel.org Cc: David Howells , Marc Dionne , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, Jeffrey Altman Subject: [PATCH net v2 1/3] rxrpc: Fix the comments saying RFC8958 to be RFC8985 Date: Tue, 20 Oct 2026 21:12:52 +0100 Message-ID: <20261020201258.290827-2-dhowells@redhat.com> In-Reply-To: <20261020201258.290827-1-dhowells@redhat.com> References: <20261020201258.290827-1-dhowells@redhat.com> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Fix the comments saying RFC8958 to be RFC8985 - ie. The RACK-TLP Loss Detection Algorithm for TCP. Fixes: 7c482665931b ("rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985]") Signed-off-by: David Howells cc: Marc Dionne cc: Jeffrey Altman cc: Eric Dumazet cc: "David S. Miller" cc: Jakub Kicinski cc: Paolo Abeni cc: Simon Horman cc: linux-afs@lists.infradead.org --- net/rxrpc/ar-internal.h | 2 +- net/rxrpc/input_rack.c | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h index 865f05fe37ab..f0c8cbcc5dd5 100644 --- a/net/rxrpc/ar-internal.h +++ b/net/rxrpc/ar-internal.h @@ -1264,7 +1264,7 @@ void rxrpc_tlp_send_probe(struct rxrpc_call *call); void rxrpc_tlp_process_ack(struct rxrpc_call *call, struct rxrpc_ack_summary *summary); void rxrpc_rack_timer_expired(struct rxrpc_call *call, ktime_t overran_by); -/* Initialise TLP state [RFC8958 7.1]. */ +/* Initialise TLP state [RFC8985 7.1]. */ static inline void rxrpc_tlp_init(struct rxrpc_call *call) { call->tlp_serial = 0; diff --git a/net/rxrpc/input_rack.c b/net/rxrpc/input_rack.c index 9eb109ffba56..072e1d9ecb2e 100644 --- a/net/rxrpc/input_rack.c +++ b/net/rxrpc/input_rack.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-or-later -/* RACK-TLP [RFC8958] Implementation +/* RACK-TLP [RFC8985] Implementation * * Copyright (C) 2024 Red Hat, Inc. All Rights Reserved. * Written by David Howells (dhowells@redhat.com) @@ -57,7 +57,7 @@ static unsigned long rxrpc_tq_nacks(const struct rxrpc_txqueue *tq) /* * Update the RACK state for the most recently sent packet that has been - * delivered [RFC8958 6.2 Step 2]. + * delivered [RFC8985 6.2 Step 2]. */ static void rxrpc_rack_update(struct rxrpc_call *call, struct rxrpc_ack_summary *summary, @@ -98,7 +98,7 @@ static void rxrpc_rack_update(struct rxrpc_call *call, } /* - * Detect data segment reordering [RFC8958 6.2 Step 3]. + * Detect data segment reordering [RFC8985 6.2 Step 3]. */ static void rxrpc_rack_detect_reordering(struct rxrpc_call *call, struct rxrpc_ack_summary *summary, @@ -143,7 +143,7 @@ void rxrpc_input_rack(struct rxrpc_call *call, } /* - * Update the reordering window [RFC8958 6.2 Step 4]. Returns the updated + * Update the reordering window [RFC8985 6.2 Step 4]. Returns the updated * duration of the reordering window. * * Note that the Rx protocol doesn't have a 'DSACK option' per se, but ACKs can @@ -192,7 +192,7 @@ static ktime_t rxrpc_rack_update_reo_wnd(struct rxrpc_call *call, } /* - * Detect losses [RFC8958 6.2 Step 5]. + * Detect losses [RFC8985 6.2 Step 5]. */ static ktime_t rxrpc_rack_detect_loss(struct rxrpc_call *call, struct rxrpc_ack_summary *summary) @@ -239,7 +239,7 @@ static ktime_t rxrpc_rack_detect_loss(struct rxrpc_call *call, } /* - * Detect losses and set a timer to retry the detection [RFC8958 6.2 Step 5]. + * Detect losses and set a timer to retry the detection [RFC8985 6.2 Step 5]. */ void rxrpc_rack_detect_loss_and_arm_timer(struct rxrpc_call *call, struct rxrpc_ack_summary *summary) @@ -255,7 +255,7 @@ void rxrpc_rack_detect_loss_and_arm_timer(struct rxrpc_call *call, } /* - * Handle RACK-TLP RTO expiration [RFC8958 6.3]. + * Handle RACK-TLP RTO expiration [RFC8985 6.3]. */ static void rxrpc_rack_mark_losses_on_rto(struct rxrpc_call *call) { @@ -285,7 +285,7 @@ static void rxrpc_rack_mark_losses_on_rto(struct rxrpc_call *call) } /* - * Calculate the TLP loss probe timeout (PTO) [RFC8958 7.2]. + * Calculate the TLP loss probe timeout (PTO) [RFC8985 7.2]. */ ktime_t rxrpc_tlp_calc_pto(struct rxrpc_call *call, ktime_t now) { @@ -309,7 +309,7 @@ ktime_t rxrpc_tlp_calc_pto(struct rxrpc_call *call, ktime_t now) } /* - * Send a TLP loss probe on PTO expiration [RFC8958 7.3]. + * Send a TLP loss probe on PTO expiration [RFC8985 7.3]. */ void rxrpc_tlp_send_probe(struct rxrpc_call *call) { @@ -356,7 +356,7 @@ void rxrpc_tlp_send_probe(struct rxrpc_call *call) } /* - * Detect losses using the ACK of a TLP loss probe [RFC8958 7.4]. + * Detect losses using the ACK of a TLP loss probe [RFC8985 7.4]. */ void rxrpc_tlp_process_ack(struct rxrpc_call *call, struct rxrpc_ack_summary *summary) {