From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.227.135 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792550879; b=EWiXt89o0nHqzoSnA1YIYFBaWZnnw00oXVOO0FwG64A1c7QKB8kkDtnoMR6u1bjfkEN9 aJPb9lbPXQ6OPyVZa35CSN2HLexRjpyfN9/yBGjZfFzq/e5lCNz03+xjnjQrPXkaZr0h7 eLEywxitXg3pqgZfh0u8ey8whXAhTEiEQu2XXuU/ewQ2kW5jsvn7tu8tjX5elD5SratZx 4FdUd5YXb1xNjhEztCYG3N5US0vj6iQ3fjW91PEKojTgD5AM7dbTs0MueUgOqdlY/++0Z DTfYkPXHVIJa1sgLrFO9GwjcmCCHhJJlkHv3JbIhkWCKCMFEqDcC2FsPeIn7dxWQbUA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792550879; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:From:To:Cc:Subject: Date:Message-ID:X-Mailer:MIME-Version:Content-Transfer-Encoding; bh=fJiseS4iluYQLnz/LCLSPHnCYq4WmvzCwyXvRqIPruk=; b=XMt3VHNwlwzX9jdgzdIDeYkLxs5lHvVUMAPXbY/im8t6UYadTQpMNq8KYv0EFBJ8DspI THREdtTBJf6z7zZoWRU+fQJjdUaC//C6QQB7SvF85GcGvUEJZVFy/8q4kzhCjwxBa0E5m 4UALbZEwBs/Tqb5QNhkew0z+Kq/UK/gqf0LazGluSO+LnOULQfW2TUF8rxYtLY8oObrD+ AZH8FIzxr/TBYH9KlXS5T8XAmdIilzbN64PtykKwQ6EUiqsOHcAZ47QxvhQ8S2nKFFWeJ JPzrVL52rPJ1p7jlbUONLHwWiL8GtWS395OgT4KrnBaRmMCH68e+ZG1+c6s8+6MlScw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=aixKShim; arc=none smtp.remote-ip=74.125.227.135 Received: from mail-pj2-f7.google.com (mail-pj2-f7.google.com [74.125.227.135]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A213606A319 for ; Wed, 21 Oct 2026 02:47:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8A213606A319 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=aixKShim Received: by mail-pj2-f7.google.com with SMTP id 98e67ed59e1d1-3ac5f801d7cso64194a91.0 for ; Tue, 20 Oct 2026 19:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792550879; x=1793155679; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fJiseS4iluYQLnz/LCLSPHnCYq4WmvzCwyXvRqIPruk=; b=aixKShimpTDGxGTRfhefbj+7AhmdO6TKqIjIH+lAHyLujVDwOdjmJoydzSrpf0+NUg PE0vbFzRZOmwus3Lt3hdddXBokS/pcSx8xumMyWyfMNfHdXN8CVg3Cd/S7p1lKx4fQMh fWcqeJox7ssuCLe8rtYwaDsKejPRW9vKEt5lBFTRnTTZDWMdDiwYfDPML32tn3rteGX8 PIEiHeBi+j35RylsGmyXmf8huRPJPaDlEjid8oezQd7NuwVq5E5uq+1vb+8qDEV1Rh9T 8QWS6MCp2sDayINWu/YcZE9wXpFvJdHWmuiULlCN16RHpFNTj4kwsxcvvDThr7obPBPB 9cvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792550879; x=1793155679; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fJiseS4iluYQLnz/LCLSPHnCYq4WmvzCwyXvRqIPruk=; b=msTuJb60No6XKM0RLDwfdfNJapi2NKuWd++Q37j2iqLlV6+58M6e8h8QZMzZEFP2YC zefgQiv9+1x1hCQk8dHAku9hbuZbMRXkgau7gzCjkhiASIm1LFtc/EgynobaY82ks/8z 29QJPW7uzGXzEve7C+HXZ8UfJYiOWBxWdxBC+Dokle65jp4xyyo/q8OXMCkmZuvifNIz SWb2SMLhycNmqPJ0RzvdU2cvScjkKR9WLMC/u9V/8JRANmKCtgCX2cIL3QyDwcx+Zjc6 eZimfnNYzqdx5FNA1d0KSM9wPdFSq/x6f7LwnXP94S840ZJHyPF4ahUbJIAIwEf/x7Ua ztdQ== X-Gm-Message-State: AFq9FYLOZeiGd5twvYiRz5/ePoQ+t4KtPPyErMbCgqYeOugn3ka5HLTI 6CLse0mOnfm7Py7pPAgRPVXfmiiEvSHfRhUI46GdV4f90Wy+ssP1/aWd X-Gm-Gg: AYBFou2fz+oPj/8sPWNL3+ypzpYKa+t/QQi0P+mLV9qYu3tYvc9CGveAqqtfpiQ4/xm 8umn4Vb9z2/JNQZHqCp+ZxB7u9CM3q/xptC6n3tRk7+e4l/equNc9/pBlBDCaFdAmqAoxJi18ak P6HZP7BZfUH5O9b142EwLIDYgT41eRhUQRW9qBvkrN+LaJOtS6C6MjmF+mYk6Pl1sOKgs9ttuWA BjjlsiWTWzdhbHxkMbPWbuQkjFQ1epGWCuHP5uXP+zlB+8U/OVkchsQAwZVutEcLxz8dtZraR7W jvs9FKGtrPK6zDHX8zHEmUQWdROJfFal9jQYzsmPMeeW1XGTQmKgNqQ7NT6nJmA2wjIelOeUx90 Wo1/nYi1/ETNa+C5HpJjSPt2FoG/Ayp+cBatnRuD4KAQABrWQzaSFoxdSt4xkauzyX1Fa44q594 1Hxi4OEVHwJyEiUfYDilezMBUK2zZ86YGigQUMe2x/9uSPJD4wkoiDyKENfRA21+PeakgH540nX BWllMSBRiBvQerRuBXl6PpuUy6gLgM85pFfJRuMbNU0K49rKYGK3eVaLhVPcJR+ASw7XUClfi4e X-Received: by 2002:a17:90b:1a91:b0:3a8:e1e:3390 with SMTP id 98e67ed59e1d1-3ad86d645f5mr753520a91.56.1792550878273; Tue, 20 Oct 2026 19:47:58 -0700 (PDT) Received: from LAPTOP-QJLDGQ2L.localdomain ([112.224.225.97]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ad813ee970sm1796473a91.16.2026.10.20.19.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Oct 2026 19:47:57 -0700 (PDT) From: Boyan Liu To: Andrea Mayer , David Ahern , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Willem de Bruijn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, co+98d7de09cd94fec5@bugs.sh Subject: [PATCH net v3] seg6: Fix unset mac header in SRv6 End.DT VRF decapsulation Date: Wed, 21 Oct 2026 10:47:38 +0800 Message-ID: <20261021024738.17266-1-yymhvert@gmail.com> X-Mailer: git-send-email 2.43.0 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SRv6 End.DT4/End.DT6 VRF decapsulation unsets the mac header in end_dt_vrf_rcv() so that the VRF device can rebuild it for packet sniffers. The VRF rx handler only performs the rebuild when a sniffer is actually attached to the VRF device (ptype_all non-empty); otherwise the packet continues up the stack with mac_header == 0xffff. Every other receive path delivers packets with a valid mac header: NIC drivers set it in eth_type_trans(), and tunnels without an L2 header (ipip, sit, gre, tun) reset it to the network header after decapsulation. skb_mac_header() even warns on the unset state with DEBUG_NET_WARN_ON_ONCE(). If the decapsulated packet is an unexpected UDP GSO packet, udp_queue_rcv_skb() re-segments it after restoring skb->data to the mac header with __skb_push(skb, -skb_mac_offset(skb)). With the mac header unset, skb_mac_offset() returns a large positive value, which the unsigned __skb_push() argument turns into a huge length: skb->data moves far outside the buffer and skb->len is corrupted, so segmentation reads out of bounds: BUG: KASAN: slab-out-of-bounds in inet_gso_segment (net/ipv4/af_inet.c:1383) Read of size 1 at addr ffff88800da7ffff by task exploit/149 Call Trace: inet_gso_segment (net/ipv4/af_inet.c:1383) skb_mac_gso_segment (net/core/gso.c:53) __skb_gso_segment (net/core/gso.c:124) udp_queue_rcv_skb (net/ipv4/udp.c:2476 net/ipv4/udp.c:2466) udp_unicast_rcv_skb (net/ipv4/udp.c:2620) ip_local_deliver (net/ipv4/ip_input.c:262) seg6_local_input_core (net/ipv6/seg6_local.c:1640) lwtunnel_input (net/core/lwtunnel.c:465) ipv6_rcv (net/ipv6/ip6_input.c:351) Restore a valid mac header once the VRF rx handler returns: point it at the network header, and reset mac_len, which still holds the ingress frame's L2 header length. The sniffer rebuild happens inside the handler while the header is still unset, so tap behavior is unchanged; when no rebuild happened, the packet now carries the same mac header state as any packet received on an L3 device. Fixes: 664d6f86868b ("seg6: add support for the SRv6 End.DT4 behavior") Cc: stable@vger.kernel.org Reported-by: co+98d7de09cd94fec5@bugs.sh Signed-off-by: Boyan Liu --- v3: - Also reset skb->mac_len with skb_reset_mac_len(), as suggested by Andrea Mayer: it still held the ingress frame's L2 header length. v2: https://lore.kernel.org/netdev/20261017120144.3059-1-yymhvert@gmail.com/ - Move the fix from the UDP GSO path to seg6local. - Restore the mac header after the VRF rx handler returns, preserving the VRF sniffer behavior. - Verify the original reproducer, datagram delivery, and VRF sniffer output under QEMU. v1: https://lore.kernel.org/netdev/20261010073015.7665-1-yymhvert@gmail.com/ net/ipv6/seg6_local.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/net/ipv6/seg6_local.c b/net/ipv6/seg6_local.c index 7b5212220185..4ef9d32907e5 100644 --- a/net/ipv6/seg6_local.c +++ b/net/ipv6/seg6_local.c @@ -1113,6 +1113,16 @@ static struct sk_buff *end_dt_vrf_rcv(struct sk_buff *skb, u16 family, /* the skb buffer was consumed by the handler */ return NULL; + /* the VRF device had its chance to rebuild the mac header for + * sniffers; restore a valid one pointing at the network header, + * like any L3 device without an L2 header, before the packet + * continues up the stack. + */ + if (!skb_mac_header_was_set(skb)) { + skb_reset_mac_header(skb); + skb_reset_mac_len(skb); + } + /* when a packet is received by a VRF or by one of its slaves, the * master device reference is set into the skb. */ -- 2.43.0