Netdev List
 help / color / mirror / Atom feed
From: Wei Tao <taowei@kylinos.cn>
To: kuba@kernel.org
Cc: netdev-bot+sinfo@kernel.org, jhs@mojatatu.com, jiri@resnulli.us,
	davem@davemloft.net, edumazet@kernel.org, pabeni@redhat.com,
	horms@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net/sched: cls_fw: allow filter replace without re-specifying mask
Date: Wed, 21 Oct 2026 20:28:46 +0800	[thread overview]
Message-ID: <20261021122846.358290-1-taowei@kylinos.cn> (raw)
In-Reply-To: <20261020135321.21517b1d@kernel.org>

Hi Jakub,

> You are expected to reply to these questions. If this is an LLM-based
> report please be more considerate of maintainer's time. If you actually
> use this feature please include the response to the question above in
> the commit message and repost. The repost should not carry a Fixes
> tag, it's not a real bug.

This was found during an LLM-assisted review of the classifier
->change() replace paths, then verified manually and reproduced in a
QEMU VM.  The hint came from the cls_route in-place replace fixes
(41e85e54e564 and b72e025ac556); auditing other classifiers showed that
cls_fw has the opposite problem: fnew->id is inherited correctly, but
fw_set_parms() treats a replace like a create and rejects it when
TCA_FW_MASK is omitted.

I will drop the Fixes tag and post the v2 once net-next reopens.

Thanks,
Wei Tao


      reply	other threads:[~2026-10-21 12:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14  2:45 [PATCH net] net/sched: cls_fw: allow filter replace without re-specifying mask Wei Tao
2026-10-14  2:50 ` netdev-bot+sinfo
2026-10-20 20:53   ` Jakub Kicinski
2026-10-21 12:28     ` Wei Tao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261021122846.358290-1-taowei@kylinos.cn \
    --to=taowei@kylinos.cn \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev-bot+sinfo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox