From: Simon Horman <horms@kernel.org>
To: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
Cc: dhowells@redhat.com, marc.dionne@auristor.com,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net/rxrpc: Simplify rxrpcpeerseq_next()
Date: Wed, 21 Oct 2026 15:48:30 +0100 [thread overview]
Message-ID: <20261021144830.GA708417@horms.kernel.org> (raw)
In-Reply-To: <20261016065011.105764-1-chelsyratnawat2001@gmail.com>
On Thu, Oct 15, 2026 at 11:50:11PM -0700, Chelsy Ratnawat wrote:
> Remove the redundant initialization and conditional handling of n,
> as it is always set to 1. Use the constant directly when updating
> *_pos and starting the hlist iteration.
>
> Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
It might be nice to use some #define rather than the magic values 0 and 1.
But as a clean-up I think there is value in this as makes the logic clearer.
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-10-21 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 6:50 [PATCH v2] net/rxrpc: Simplify rxrpcpeerseq_next() Chelsy Ratnawat
2026-10-21 14:48 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261021144830.GA708417@horms.kernel.org \
--to=horms@kernel.org \
--cc=chelsyratnawat2001@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox