Re: [PATCH v4 net-next 09/15] selftests: xsk: run one test case per xskxceiver invocation

[Jakub Kicinski <kuba@kernel.org>]

On Fri, 16 Oct 2026 19:43:32 +0200 Maciej Fijalkowski wrote:
> Replace test_xsk.sh and xsk_prereqs.sh with test_xsk.py, which runs
> xskxceiver once per mode and case, so that every case starts from a
> fresh process and a crash fails only its own case. A single case is
> also the unit that the next patch splits into RX and TX processes.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1fc9eaedd744..6985a42bc09c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -29784,6 +29784,7 @@ F:	include/uapi/linux/if_xdp.h
>  F:	include/uapi/linux/xdp_diag.h
>  F:	net/xdp/
>  F:	tools/testing/selftests/net/*xsk*
> +F:	tools/testing/selftests/net/lib/py/xsk.py
>  F:	tools/testing/selftests/net/lib/xsk/

pylint has some complaints, about main(), I think?
Could you make it clean?

> +++ b/tools/testing/selftests/net/lib/py/xsk.py

Really not loving the amount of "library" code added here.
Do you need this just to run it over veth in net/ and over
real HW in drivers/net/ ? Are the test cases very different?

I wonder if we could solve this by parameterizing the env
class to use veth instead of netdevsim and then have unified tests?


> +def xsk_wait_endpoint_exit(endpoint, label, timeout):

odd, the existing cmd() / bkg() stuff doesn't work for you?
It works for many other tests...
-- 
pw-bot: cr