From: Jakub Kicinski <kuba@kernel.org>
To: Bhargava Chenna Marreddy <bhargava.marreddy@broadcom.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, michael.chan@broadcom.com,
pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com,
vikas.gupta@broadcom.com,
Dharmender Garg <dharmender.garg@broadcom.com>,
Rajashekar Hudumula <rajashekar.hudumula@broadcom.com>,
Ramakrishna Koduri <ramakrishna.koduri@broadcom.com>
Subject: Re: [PATCH net-next v3 5/5] bnge: make NQ0 persistent across open/stop cycles
Date: Thu, 22 Oct 2026 18:16:39 -0700 [thread overview]
Message-ID: <20261022181639.1815c338@kernel.org> (raw)
In-Reply-To: <CANXQDtYjxskxm11cGVV4QbnTjwStwJ5ot-5Kg+P+z5L0pOL5Cw@mail.gmail.com>
On Thu, 22 Oct 2026 16:27:42 +0530 Bhargava Chenna Marreddy wrote:
> What I propose for v4:
>
> 1. NAPI for NQ0 is added in ndo_open and deleted in ndo_stop, like
> every other NQ.
> 2. NQ0's IRQ stays requested across open/stop:
> - When netdev is UP: The IRQ handler schedules NAPI, which handles
> Rx/Tx, async (including link), and HWRM events.
> - When netdev is DOWN: There is no NAPI instance. The IRQ handler
> queues a work item that handles async and HWRM events.
> 3. Mode switches happen only in open/stop, so only one context
> consumes NQ0 at a time:
> - open: quiesce the IRQ, flush the work item, then enable NAPI.
> - stop: disable NAPI, then allow the work item again.
Sounds reasonable (please note that net-next is closed now)
prev parent reply other threads:[~2026-10-23 1:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 20:06 [PATCH net-next v3 0/5] bnge: Make NQ0 persistent across open/close Bhargava Marreddy
2026-10-13 20:06 ` [PATCH net-next v3 1/5] bnge: factor out per-NQ alloc/free helpers Bhargava Marreddy
2026-10-13 20:06 ` [PATCH net-next v3 2/5] bnge: add bnge_err()/bnge_warn()/bnge_dbg() logging helpers Bhargava Marreddy
2026-10-13 20:06 ` [PATCH net-next v3 3/5] bnge: add bnge_for_each_open_nq() iterator Bhargava Marreddy
2026-10-13 20:06 ` [PATCH net-next v3 4/5] bnge: make irq_tbl layout depend on BNGE_FIRST_OPEN_NQ Bhargava Marreddy
2026-10-13 20:06 ` [PATCH net-next v3 5/5] bnge: make NQ0 persistent across open/stop cycles Bhargava Marreddy
2026-10-18 15:32 ` Bhargava Chenna Marreddy
2026-10-18 17:20 ` Bhargava Chenna Marreddy
2026-10-20 20:34 ` Jakub Kicinski
2026-10-22 10:57 ` Bhargava Chenna Marreddy
2026-10-23 1:16 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261022181639.1815c338@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=dharmender.garg@broadcom.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=ramakrishna.koduri@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox