From: Jakub Kicinski <kuba@kernel.org>
To: Dudu Lu <phx0fer@gmail.com>
Cc: hawk@kernel.org, ilias.apalodimas@linaro.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: page_pool: bound queue_idx before indexing dev->_rx[]
Date: Fri, 23 Oct 2026 08:23:08 -0700 [thread overview]
Message-ID: <20261023082308.23080670@kernel.org> (raw)
In-Reply-To: <20261021155611.68473-1-phx0fer@gmail.com>
On Wed, 21 Oct 2026 23:56:11 +0800 Dudu Lu wrote:
> queue_idx is supplied by the driver alongside PP_FLAG_ALLOW_UNREADABLE_NETMEM
> (the gve, bnxt, bnge, fbnic and mlx5 rx paths all set both); it is the
> driver's own rx queue index, so an in-tree driver passes a valid value.
> page_pool_init() still indexes dev->_rx[] with it while only asserting that
> the netdev lock is held, never checking it against real_num_rx_queues, so
> the exported API trusts the caller for the bound. This is a sink-side
> hardening fix for page_pool_create_percpu(); the QEMU guest used for the
> reproducer has no such NIC, so the pool was created through a small module.
If all consumer (obviously!) pass the right index - why are you
bothering us with this patch?
Please do not send any patches to linux networking for next 2 months,
and until you learn basic coding skills.
--
pv-ban: 2mo
next prev parent reply other threads:[~2026-10-23 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 15:56 [PATCH net] net: page_pool: bound queue_idx before indexing dev->_rx[] Dudu Lu
2026-10-21 16:00 ` netdev-bot+sinfo
2026-10-22 5:00 ` phx
2026-10-23 13:42 ` Paolo Abeni
2026-10-23 15:23 ` Jakub Kicinski [this message]
2026-10-25 17:59 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023082308.23080670@kernel.org \
--to=kuba@kernel.org \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=phx0fer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox