Netdev List
 help / color / mirror / Atom feed
From: Ting-Han Hou <ue081723@gmail.com>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Chris J Arges <carges@cloudflare.com>,
	Eric Dumazet <edumazet@kernel.org>,
	Weiming Shi <bestswngs@gmail.com>,
	netdev@vger.kernel.org
Subject: Request: follow-up fixes for "net: add xmit recursion limit to tunnel xmit functions" in 6.6.y and 6.1.y
Date: Sat, 24 Oct 2026 17:30:10 +0800	[thread overview]
Message-ID: <20261024093010.485-1-ue081723@gmail.com> (raw)

Hi Greg, Sasha,

6f1a9140ecda ("net: add xmit recursion limit to tunnel xmit
functions") was backported to 6.6.y in 6.6.160 and is currently in
queue-6.1, but two upstream follow-up fixes for it were not. Please
consider queueing:

For 6.6.y:

  c38b8f5f791e ("net: prevent NULL deref in ip[6]tunnel_xmit()")
  77facb35227c ("net: increase IP_TUNNEL_RECURSION_LIMIT to 5")

For 6.1.y (on top of the queued 6f1a9140ecda backport):

  77facb35227c ("net: increase IP_TUNNEL_RECURSION_LIMIT to 5")

The queued 6.1 backport of 6f1a9140ecda already includes the
"if (dev)" check from c38b8f5f791e, so only the limit change is
missing there.

Why:

- 77facb35227c: with a limit of 4, setups with multiple tunnel
  layers and MPLS lwtunnel routing drop legitimate packets with
  "Dead loop on virtual device ..." even though there is no loop.
  6.6.160 now has this regression, and 6.1 will get it with the
  queued backport. Upstream raised the limit to 5; it is in 6.12.83,
  6.18.24 and 6.19.14.

- c38b8f5f791e: iptunnel_xmit() and ip6tunnel_xmit() can be called
  with dev == NULL (e.g. SCTP and TIPC over UDP), and the new
  recursion check dereferences dev when the limit is hit. It is in
  6.12.78, 6.18.19 and 6.19.9.

Both commits cherry-pick cleanly onto v6.6.160, and 77facb35227c
cherry-picks cleanly onto v6.1.190 plus queue-6.1 (stable-queue
fa04d3db75). I build-tested the affected objects (ip_tunnel_core,
ip_tunnel, ip6_tunnel, ip6_udp_tunnel, the GRE/IPIP/SIT, VXLAN,
Geneve, bareudp and GTP drivers, SCTP and TIPC UDP media) with W=1
on both trees, with no new warnings. I did not do runtime testing.

I noticed the gap while checking which stable trees carry
77facb35227c.

Thanks,
Ting-Han Hou

             reply	other threads:[~2026-10-24  9:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24  9:30 Ting-Han Hou [this message]
2026-10-24 14:26 ` Request: follow-up fixes for "net: add xmit recursion limit to tunnel xmit functions" in 6.6.y and 6.1.y Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261024093010.485-1-ue081723@gmail.com \
    --to=ue081723@gmail.com \
    --cc=bestswngs@gmail.com \
    --cc=carges@cloudflare.com \
    --cc=edumazet@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox