From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792858819; b=sEqBaajAoppMHUPHX2xanzJNsadhItfoY1glWkeTm2s4OBXOmsM/PLeNgehz/n5YNwys uyjiaXexx4Ez+6hphmSEHKcJ83Nr7bh9okFmeBqgm1QhPVc0EiJWqGFj5JGtmgsYRQgH5 gBmZbHdXM9nX8NCwZ5lMCKjJEP0qeMJmKqJevNhZ0AT7PCtfBHXuz5nNb6O7okF7e+JZL 8IoAUJL71LHHRWXr02ec6WpAP3jP+EaQdBsdOJ1FW8MGpnr1T9me5WEe20n8Sv7Ud/pXK z09HPxSjqwBiajkh/GdyCkfnGPal3/SUtn8KxQdCDJLGIhUTD+RZy6zfXZUSzk6RcWA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792858819; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=JnidHUsBQArt33vLjV0kqnv/bWxmzPm4EkJn55+rvF0=; b=a7nRNV5pytThvhRUFVz8sQmOjEdcm4lI+fqdpXhwUJX+skh+G4CLeQozKT9ud5tSCSnJ SmMoSKDhyX9FwOIWNjDQSvCRWp9RMMUrs4friGHb1wgrBCt/oJJD+hp7tg6eetGewGYxP ak2O2ry0HowSboKuPzmcIFPKj7o2ByKZ1kaTWvMV4k1S9xL+iNqT6MnZTNJtFeveT2PEK sYoNW7c5oHhIBOKfaN0RUvXjmgTxzS426bN/woxj0p5AkwmR7Aa4qfImR5VxXcjT3brbI sZIZ8/OqBazVPLvOyhbuiWlMjeg64t2p4cI8YFJIKEmL+Cpwna/e79hP4a4rotZhOeQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LYjbY+Ni; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=mY4M9eO5; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85A3B606A31E for ; Sat, 24 Oct 2026 16:20:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 85A3B606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LYjbY+Ni; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=mY4M9eO5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792858817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JnidHUsBQArt33vLjV0kqnv/bWxmzPm4EkJn55+rvF0=; b=LYjbY+NiuAzlv1S0TktrcP/XaFUeM7qeCFX6aOm0YNJMr00LCp7a8SxFM9dLxDs4XOc4lI 4DuvNn0Gp+0vKZkIadnmEtlUNXRXPkdNbb4spTumNa1dsCL8QcOeN+FfyEiTX5jSGVepSy npmCeYTjczzO0S2TagjkCbN4SvT5IbA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-vqKQPQ6EPNGfsd2__ixlHA-1; Sat, 24 Oct 2026 12:20:15 -0400 X-MC-Unique: vqKQPQ6EPNGfsd2__ixlHA-1 X-Mimecast-MFC-AGG-ID: vqKQPQ6EPNGfsd2__ixlHA_1792858815 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48e0c896d05so1572656f8f.1 for ; Sat, 24 Oct 2026 09:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1792858815; x=1793463615; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JnidHUsBQArt33vLjV0kqnv/bWxmzPm4EkJn55+rvF0=; b=mY4M9eO5GoXoeQyWRaP5V1FLbHOvq2Lj35+r1IR/P3fYmebBhOb2SfSthoxC/2nOPX Rw+N+nG2WHUFTjcyCokasuaWOxs5aLgfsiG9mYhPtd7HMDdK4M5Vuut9EewmuyodhkK3 1/7Wigtr01thpHmX/WhiSMT6s7YdVeCyNfctJYNd8zdJTV1JI3etdZ3UiWWhgPAEUwnX HEAYiyNEegm5xFt9csnNtRkcWghfqMA2j2c0KLKBOOAKRMByRPKlvSr4wRQQu9SAvO+K M4nWZoepyXQzT/ksLVh17matGeN0b9boYZa97Y/rBztVWE1XJOGWtPBiZsi+Qk0cqlkP AJXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792858815; x=1793463615; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JnidHUsBQArt33vLjV0kqnv/bWxmzPm4EkJn55+rvF0=; b=KgTlzVFmV6aXp/7yZctM2MWkkeamJkH8m5CsKpONhSCrwxpFTwa80LHGEEHOOKV/rm BmFlMS+cfAZgmyyvRJoZUVphQJzFBV0hQ70hyDzSCyxY5pKZGHM30od5NNcBdI0tjhna IA6mKW6lYHt0n1+DdYiQiC5jGuh1Xu3nzH7+mVkGz7RsyBIHBdShnapN/9scMDqnlSIN yPwMgIXxcpi7QKhBGfeQSIe/akaZ27o5ZHhhkxa63Wi5DI5dnCZaBK25KrkNz+XYJrp6 X3iVMhybXS3/MhZeqtvKuIUugaAYyjM40McpT/izLuvC6RgNIZJQVN3nuAmwnAK0D/7k 89xQ== X-Forwarded-Encrypted: i=1; AKwUvBwoLrae55dNPIwB4NriBHjLIL9/r4j1t8Eyf94Pek3Z2V6DVsPewIvKb2RSOJRZ3dfNCaJAk+0=@vger.kernel.org X-Gm-Message-State: AFq9FYJqAdMC8qYH1DOYP4DNuYhl/jsOWb9Twkg5eeARQDmCDhfpoXto YIZiyNiEBrhURDmdvCv1za7s3N+4l4/wjxUcfrRS2loYTo82og4CDdtkd0R3OYzUAt5FkQM3mOM qWoraP3WALwn2HoI8ntofnXkDsKoYBe4mQp1pFZIWWuIYIQQJc9VsQH3msQ== X-Gm-Gg: AYBFou01WxNSGTRXc7Sq4KXQE7tnJgB9/SPifL0xkieoW1CyfGCnN97f81lo38H3H4M TnYjLSfTlebzBIGjk2EJrDpBSLORDr3N5lXxrabFce+QR5b9rp24HVhQY+AiwQ9uIFm/zQ2zSW7 ewUzfDHO7OarhmKIhhxCEPz9l/fj1hm6Y2Gi7fU7sJsT2gbMtV+pHQaQ9aenaHRediPXaAimgTz FihzOGxNrb5Yknyajlbbd9W6XMGtHMBBe1QW2J3xNcCVaCzXNqcuDVdB+vIVxLi/fNkJyqqBKZ6 WSjB1Rp/0BjLf9u1lPz1RZKQ6GOiAK/U8dD7xkPL9pSpCFLbz3M3FnQrZliasHDOLBdO59Y= X-Received: by 2002:a05:6000:4b1e:b0:48d:df08:307c with SMTP id ffacd0b85a97d-48e3eb94526mr3420677f8f.44.1792858814494; Sat, 24 Oct 2026 09:20:14 -0700 (PDT) X-Received: by 2002:a05:6000:4b1e:b0:48d:df08:307c with SMTP id ffacd0b85a97d-48e3eb94526mr3420647f8f.44.1792858813925; Sat, 24 Oct 2026 09:20:13 -0700 (PDT) Received: from redhat.com ([2a06:c701:73f6:2400:30a8:9e33:7d82:c035]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e3ece5e4asm4812439f8f.59.2026.10.24.09.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Oct 2026 09:20:12 -0700 (PDT) Date: Sat, 24 Oct 2026 12:20:09 -0400 From: "Michael S. Tsirkin" To: Willem de Bruijn Cc: linux-kernel@vger.kernel.org, Chris Arges , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Phil Sutter , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, virtualization@lists.linux.dev, Max Krasnyansky , Rusty Russell Subject: Re: [PATCH net v6 0/5] more virtio-net csum hardening Message-ID: <20261024121852-mutt-send-email-mst@kernel.org> References: <20261024113809-mutt-send-email-mst@kernel.org> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Oct 24, 2026 at 12:08:55PM -0400, Willem de Bruijn wrote: > Michael S. Tsirkin wrote: > > On Fri, Oct 23, 2026 at 11:09:17AM -0400, Michael S. Tsirkin wrote: > > > > > > Okay this seems to be converging.... But sashiko did find some issues I > > > thought are best fixed. Specifically I thought of a better way to handle > > > short gso in a tunnel - just clear tunnel gso! As a side effect we now > > > fix up the checksum for these dodgy packets like we did before, instead > > > of a drop. Good. And more false positives that prompted me to write a > > > bit more comments. So here goes. > > > > > > Apologies for reposting so frequently, I know netdev bot will be unhappy > > > with that. But Paulos's report made a lot of publicity, there is a lot > > > of people looking into this, so I feel there's value in defending > > > against all this class of issues sooner rather than later. > > > > > > The issues were mostly found by code inspection, but all reproduced by > > > me in a VM. > > > > Ugh. I found another wrinkle( Firewalls that shape the payload. > > They are currently seem to simply be hoping most traffic is CHECKSUM_PARTIAL and > > only looking at that, and that will break. > > > > I am not sure what to do yet. Extending the sysctl knob to control what > > happens if validation fails: pass/drop/complete - is the best I could > > come up with. Or ignore the issue. Or just forget the complete at input hack > > and drop if we can't figure it out. > > Sounds like such users will just have to disable the sysctl for now: pass. > > And update their firewall, then reenable the sysctl? > > Does adding a third drop option help in any way? The sysctl is the safety > valve to go back to old behavior. Yes, maybe that's enough. I was just hopeful there's no known broken valid setup, now not only we found it, is is actually unfixable ( Still trying to decide what to do. -- MST