From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.197 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792984941; b=PF6PYA4j6WyY+ol5sH5RveTRAA2lrVML7TJp6Wil/dAYweQOsf/sjexPHtwYnO7jGIp7 NCMgyd9A8sDiq7jLO+1H0ud7UBywFCFpP0zb1ItkYaxX33RQTC3UI4iCrVkr2HtH6FX8R TWvbUrUNN/YbCAgAy36AHhNWy6fWvQDtEJlTqyaW92Pmh4xIkZlbKkIGdG8FZZKcjfAc5 6dwp3zGloxA9ZdZkPPHM0xkfdE38prIwVW78qvqk00SzEOYF245AfJ4vxOrp8Pq+oF+eL oA9Sn9b0pAuoYjxY/E8bhURi6Wlx/fvI5p+lBqkE7lpE6qYHFY60QvMJ934iO5kv0ww== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792984941; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=uJyYymouqBQHX6BWujXvWQ1rvhU5zBX4eBfxY6iRb/I=; b=3/jO18PQVs4SrbXREYddCCxhd/aSIIWzKZmbzTCRSQ66U8ZYFEmtS7z6oJMrSJUDINyb 1oe/q5d7LuMiczAdLoKqaK+XpZ5y4OlAIQiAr79fwh/W6G/Arpo33fGlXUW7MhYWIW7/+ 4qkmd3hHF2pUDrXHNPchJG9O1ZmWLvRdn1MYhg/yAY+aR+diehH6PN1vcQtABUbEAoNR5 exy0dvO2bDfuUfn9MzzewvX4SZp+M1oBR6g2/Lj11Zr66hGy2ALPO6PJ/ZsTJTgCo19dH KjnrMTRvOR5qt1r+Ki+s3lCpaMI05L0WAquW8yrSqUtYQwPmAdGIMlRx8ikNH8LFC6g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--tavip.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=ERs79FtN; arc=none smtp.remote-ip=209.85.214.197 Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1000606A32A for ; Mon, 26 Oct 2026 03:22:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D1000606A32A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tavip.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=ERs79FtN Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2d02df2bf09so18966235ad.0 for ; Sun, 25 Oct 2026 20:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792984940; x=1793589740; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uJyYymouqBQHX6BWujXvWQ1rvhU5zBX4eBfxY6iRb/I=; b=ERs79FtNO9thnP1VqmFeDHRIDl9UWzwYvyzAuD/2OStrEBGF4w/JdXfASRhKW4kJLF OMk9tIq9NT9OxTB4iBe9Z2Wu2rL/t8uKLjurVf0IoUc5iINwLcRiXFC1TBO7vvRytsPm MHN3OgLyhI7EHz6mndJTFXYZFTPhD5LoVgSKbmq4HBaHdFIvmo4rZObBy6tKm/PLPc7N nY32zo7vkfa5s5qGZtbOzyh6pDwUioLwAH7RpJJuL2bJQr7j/OwWw17hQF5vTMuvFiYQ 1/qqep5uuwJQEy3DhrO2T5oaByHxLDgRYCyDl1EvUarCjVpNQsfgUoLgr3d1yD4WBjo4 Hx9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792984940; x=1793589740; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uJyYymouqBQHX6BWujXvWQ1rvhU5zBX4eBfxY6iRb/I=; b=qAf5QePkZiEfoWiGr30Q3OQj7xcaVfsLDDVpyfVWxI5L4niXXs4NHoxXFRyEck60Qi eCdiN0Xn2FAsDO+mhhnA28nBjRARXG6vqvxM/eeEPH24K60WxJnGpl0h6M6pcNN+fY0G KeOkMgD04eFwGrzJXaJUHved1lKZ5BhIcPJphiNeKL8pYO3ggeF92GSBkgNJVYp0JJa8 VXxTRhYOgr9md6EMrJ8pPm2sadYv6K8hk97xwcOAEcEbdTUcoA49up/y8CZMNrKi4hzs cjlsASQGC0okOraIRccOji8nn5PcR0uMRrAxHH+YJK0XvVzHQV4ZV98TuIk9unpeM7/N Ez7A== X-Forwarded-Encrypted: i=1; AKwUvBxWN8scGyZ6OXJj/6sYoaPMSlleTcJFJg58r0Ik0sAsqLsQHESIUXiL/GIpZzDjdkKmSyP/nFY=@vger.kernel.org X-Gm-Message-State: AFq9FYJrXehi5d6gCuE+iarMk3SIaqP1csYLAwMK7VHowU/DlfG4nw2T fi0UH57fIM9H3or1PiIywRjLRDca4szJBk02tZYq4InqB2lEPsXF8u9tYkN/pu2cBA5AeSeE4Rz Hqw== X-Received: from plbbi9.prod.google.com ([2002:a17:902:bf09:b0:2e8:43aa:1e5e]) (user=tavip job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:1968:b0:2e9:95c0:7c50 with SMTP id d9443c01a7336-2ea9c95ba36mr40443685ad.71.1792984940101; Sun, 25 Oct 2026 20:22:20 -0700 (PDT) Date: Mon, 26 Oct 2026 03:22:15 +0000 In-Reply-To: <20261026032216.1145201-1-tavip@google.com> X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261026032216.1145201-1-tavip@google.com> X-Mailer: git-send-email 2.56.0.257.gf7497c7d27-goog Message-ID: <20261026032216.1145201-2-tavip@google.com> Subject: [PATCH net v4 1/2] tcp: clamp return value of tcp_wmem_schedule() to non-negative From: Octavian Purdila To: Eric Dumazet , Neal Cardwell , Kuniyuki Iwashima , "David S . Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Shuah Khan Cc: Simon Horman , Willem de Bruijn , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Octavian Purdila , Eric Dumazet Content-Type: text/plain; charset="UTF-8" When sk_wmem_schedule(sk, copy) fails under TCP memory pressure and sk->sk_wmem_queued already reaches or exceeds sysctl_tcp_wmem[0], tcp_wmem_schedule() returns min(copy, sk->sk_forward_alloc). However, sk->sk_forward_alloc is a signed int that can transiently become negative when tcp_collapse() re-packs partially read or high payload-to-truesize SKBs in the receive queue and charges newly allocated SKBs via sk_mem_charge() before freeing the original SKB. If tcp_wmem_schedule() returns a negative value, tcp_sendmsg_locked() passes that negative copy length to skb_copy_to_page_nocache() -> copy_from_iter_full() -> check_copy_size(), where it is converted to an unsigned size_t > INT_MAX, triggering a WARN_ON_ONCE(bytes > INT_MAX) in production and returning -EFAULT instead of waiting for memory or returning -EAGAIN: WARNING: CPU: 1 PID: 939331 at include/linux/thread_info.h:249 tcp_sendmsg+0x10c1/0x1530 Call Trace: __sys_sendmsg+0x292/0x490 do_syscall_64+0x88/0x340 entry_SYSCALL_64_after_hwframe+0x76/0x7e Clamp the return value of tcp_wmem_schedule() to [0, copy] so callers treat negative sk_forward_alloc as 0 available bytes. Fixes: 849b425cd091 ("tcp: fix possible freeze in tx path under memory pressure") Assisted-by: LLM Reviewed-by: Kuniyuki Iwashima Reviewed-by: Eric Dumazet Signed-off-by: Octavian Purdila --- net/ipv4/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 87ef6d5cbfeba..0e062fcd94a6c 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -1037,7 +1037,7 @@ int tcp_wmem_schedule(struct sock *sk, int copy) left = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_wmem[0]) - sk->sk_wmem_queued; if (left > 0) sk_forced_mem_schedule(sk, min(left, copy)); - return min(copy, sk->sk_forward_alloc); + return clamp(sk->sk_forward_alloc, 0, copy); } void tcp_free_fastopen_req(struct tcp_sock *tp) -- 2.56.0.257.gf7497c7d27-goog