Netdev List
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, victor@mojatatu.com, jiri@resnulli.us,
	davem@davemloft.net, edumazet@kernel.org, pabeni@redhat.com,
	stable@vger.kernel.org, sashiko-bot@kernel.org
Subject: Re: [PATCH net 2/2 repost2] net/sched: sch_teql: keep skb->dev consistent on the arp-queue path
Date: Tue, 27 Oct 2026 18:29:05 +0000	[thread overview]
Message-ID: <20261027182905.GQ257209@horms.kernel.org> (raw)
In-Reply-To: <CAM0EoMkf_ewuY4bx=MFNc0ybR66pLP3F8nZSCZBMW6bbXWoFOA@mail.gmail.com>

On Tue, Oct 27, 2026 at 04:04:34AM -0400, Jamal Hadi Salim wrote:
> On Tue, Oct 27, 2026 at 3:44 AM Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> >
> > On Tue, Oct 27, 2026 at 3:25 AM Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> > >
> > > On Mon, Oct 26, 2026 at 8:46 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > > >
> > > > On Mon, 26 Oct 2026 19:51:33 -0400 Jamal Hadi Salim wrote:
> > > > > > This is an AI-generated review of your patch. The human sending this
> > > > > > email says "Hi Jamal, passing this on for your consideration as it
> > > > > > seems to have got stuck somewhere."
> > > > >
> > > > > There was nothing wrong with the headers this time - so not sure what
> > > > > is going on. A bit frustrating.
> > > >
> > > > It is frustrating, you are the only one with these issues.
> > > > Patch 2 is posted in reply to patch 1. IDK what else is wrong.
> > > >
> > >
> > > Let me send a repost3 - will take the opportunity to pedantically fix
> > > the commit message (no code change).
> >
> > BTW, checking i see the threading was:
> >      0/2 cover  (root)
> >        1/2      (reply to 0/2)
> >          2/2    (reply to 1/2)
> >
> > I checked other postings that didnt have issues and it was fine. I
> > also found the approach
> >    0/2 cover  (root)
> >        1/2      (reply to 0/2)
> >         2/2    (reply to 0/2)
> >
> 
> And for repost3:
> - 0/2 (root)
>      1/2  In-Reply-To/References: 0/2
>      2/2  In-Reply-To: 1/2; References: 0/2 + 1/2
> 
> I am sticking to this approach going forward.

Hi Jamal,

It's unclear to me if the threading relates to why the NIPA-Sashiko review
of this patch-set didn't propagate to the ML.  But I would suggest that
however b4 handles threading would be a good approach top copy.

  reply	other threads:[~2026-10-27 18:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 10:38 [PATCH net 0/2 repost2] net/sched: sch_teql: fix shared headroom and header strip Jamal Hadi Salim
2026-10-20 10:38 ` [PATCH net 1/2 repost2] net/sched: sch_teql: fix shared headroom and header strip on slave retry Jamal Hadi Salim
2026-10-20 10:38   ` [PATCH net 2/2 repost2] net/sched: sch_teql: keep skb->dev consistent on the arp-queue path Jamal Hadi Salim
2026-10-26 16:07     ` Simon Horman
2026-10-26 23:51       ` Jamal Hadi Salim
2026-10-27  0:46         ` Jakub Kicinski
2026-10-27  7:25           ` Jamal Hadi Salim
2026-10-27  7:44             ` Jamal Hadi Salim
2026-10-27  8:04               ` Jamal Hadi Salim
2026-10-27 18:29                 ` Simon Horman [this message]
2026-10-27 19:45                   ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027182905.GQ257209@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sashiko-bot@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=victor@mojatatu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox