From: "Cen Zhang (Microsoft)" <cenzhang@linux.microsoft.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev-bot+sashiko@kernel.org, dsahern@kernel.org,
idosch@nvidia.com, davem@davemloft.net, edumazet@kernel.org,
pabeni@redhat.com, horms@kernel.org, mazziesaccount@gmail.com,
greearb@candelatech.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
AutonomousCodeSecurity@microsoft.com,
tgopinath@linux.microsoft.com,
Cen Zhang <cenzhang@linux.microsoft.com>
Subject: Re: [PATCH net] ipv6: fix fib6 walker UAF on NLM_F_REPLACE
Date: Wed, 28 Oct 2026 11:34:44 -0400 [thread overview]
Message-ID: <20261028153444.67719-1-cenzhang@linux.microsoft.com> (raw)
In-Reply-To: <20261019170909.7b065b7d@kernel.org>
Hi Jakub,
Sorry for the delayed reply. I'll send v2 shortly.
On Mon, 19 Oct 2026 17:09:09 -0700 Jakub Kicinski wrote:
> On Sat, 10 Oct 2026 22:55:27 +0000 netdev-bot+sashiko@kernel.org wrote:
> > Should w->skip_in_node be reset here too?
>
> Sounds legit on the surface
Agreed. I'll address this in v2.
Regarding the other points in Sashiko's review:
> Can a resumed dump skip the replacement route rt here?
> [...] It moves walkers on iter to iter->fib6_next, which comes after
> rt [...] The dump then contains neither the old route nor its
> replacement for that prefix and metric
Yes, I reproduced this behavior with v1 applied. I'll address it in v2.
> can this store race with the lockless walker reset in
> fib6_dump_table()? [...] The same race already existed with
> fib6_del_route() as the writer.
I agree this is a pre-existing issue. I'll leave it out of v2 to keep
this change focused.
Thanks,
Cen
prev parent reply other threads:[~2026-10-28 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 22:51 [PATCH net] ipv6: fix fib6 walker UAF on NLM_F_REPLACE Cen Zhang (Microsoft)
2026-10-10 22:55 ` netdev-bot+sashiko
2026-10-20 0:09 ` Jakub Kicinski
2026-10-28 15:34 ` Cen Zhang (Microsoft) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028153444.67719-1-cenzhang@linux.microsoft.com \
--to=cenzhang@linux.microsoft.com \
--cc=AutonomousCodeSecurity@microsoft.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@kernel.org \
--cc=greearb@candelatech.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tgopinath@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox