Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: dhowells@redhat.com
Cc: Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, marc.dionne@auristor.com,
	davem@davemloft.net, edumazet@google.com, horms@kernel.org,
	linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
	jaltman@auristor.com, stable@vger.kernel.org,
	netdev-bot+sashiko@kernel.org
Subject: Re: [PATCH net v2 2/3] rxrpc: Fix counting of in-flight transmitted packets
Date: Wed, 28 Oct 2026 15:35:10 -0700	[thread overview]
Message-ID: <20261028153510.2c0b0f23@kernel.org> (raw)
In-Reply-To: <0f7f68bf-d02e-4bc5-accf-5f89a599d37f@redhat.com>

On Tue, 27 Oct 2026 10:07:14 +0100 Paolo Abeni wrote:
> On 10/22/26 02:00, netdev-bot+sashiko@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider.
> > 
> > Critical: 0 · High: 0 · Medium: 2 · Low: 0 (1)
> > 
> > If you believe none of the issues are legitimate, please reply to each
> > issue of Medium severity or higher and explain why the AI is wrong.
> > If any of them are legitimate and you plan to respin, please let patchwork
> > know by including "pw-bot: cr" as a separate line at the end of your reply
> > (one such reply per series is enough).
> > 
> > - [Medium] Incomplete in-flight accounting: if a segment that is already
> >    soft-ACKed gets retransmitted, its tq->in_flight bit is set again and…
> > - [Medium] Behaviour change on soft-ACK reneging (ACK->NAK flip).  
> Basically sashiko says that the accounting looks still not perfect. Is not
> clear to me the new status is good enough.
> 
> Side notes: sashiko comments on patch 3/3 are not blockers, but you should
> revisit the commit message in case of a repost (and do not include patch 1/3,
> postponed to net-next).

David, this posting is almost 9 days old (which is a cut off point for
some of our trackers). Could you please respond?

  reply	other threads:[~2026-10-28 22:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 20:12 [PATCH net v2 0/3] rxrpc: RACK-TLP fixes David Howells
2026-10-20 20:12 ` [PATCH net v2 1/3] rxrpc: Fix the comments saying RFC8958 to be RFC8985 David Howells
2026-10-20 20:12 ` [PATCH net v2 2/3] rxrpc: Fix counting of in-flight transmitted packets David Howells
2026-10-22  0:00   ` netdev-bot+sashiko
2026-10-27  9:07     ` Paolo Abeni
2026-10-28 22:35       ` Jakub Kicinski [this message]
2026-10-29 14:39         ` Jeffrey E Altman
2026-10-20 20:12 ` [PATCH net v2 3/3] rxrpc: Fix RACK-TLP implementation David Howells
2026-10-22  0:00   ` netdev-bot+sashiko
2026-10-20 20:19 ` [PATCH net v2 0/3] rxrpc: RACK-TLP fixes netdev-bot+sinfo
2026-10-21  6:10 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261028153510.2c0b0f23@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jaltman@auristor.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.dionne@auristor.com \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox