Netdev List
 help / color / mirror / Atom feed
From: "Cen Zhang (Microsoft)" <cenzhang@linux.microsoft.com>
To: netdev-bot+sinfo@kernel.org
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Florian Westphal <fw@strlen.de>, Phil Sutter <phil@nwl.cc>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, "Vitaly E. Lavrov" <lve@guap.ru>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, AutonomousCodeSecurity@microsoft.com,
	tgopinath@linux.microsoft.com,
	Cen Zhang <cenzhang@linux.microsoft.com>
Subject: Re: [PATCH net] netfilter: xt_recent: do not call remove_proc_entry() under recent_lock
Date: Wed, 28 Oct 2026 18:01:36 -0400	[thread overview]
Message-ID: <20261028220136.50921-1-cenzhang@linux.microsoft.com> (raw)
In-Reply-To: <179322419201.3327.14972314584790214914@kernel.org>

Hi,

This was found by LLM-assisted code review.

We confirmed it in QEMU on mainline f0100363d8c3 with a reproducer:

- With DEBUG_ATOMIC_SLEEP enabled, we see the "sleeping function
  called from invalid context" warning quoted in the commit message.
- On a non-debug build, we see "scheduling while atomic", followed by an
  RCU stall, and the netns workqueue remains stuck.
- After the patch, the same reproducer completes and reads
  return -EIO as expected.

We could not find a syzbot report or an earlier public report. The
reproducer is available on request.

Thanks,
Cen

      reply	other threads:[~2026-10-28 22:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 21:44 [PATCH net] netfilter: xt_recent: do not call remove_proc_entry() under recent_lock Cen Zhang (Microsoft)
2026-10-28 21:49 ` netdev-bot+sinfo
2026-10-28 22:01   ` Cen Zhang (Microsoft) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261028220136.50921-1-cenzhang@linux.microsoft.com \
    --to=cenzhang@linux.microsoft.com \
    --cc=AutonomousCodeSecurity@microsoft.com \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lve@guap.ru \
    --cc=netdev-bot+sinfo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    --cc=stable@vger.kernel.org \
    --cc=tgopinath@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox