From: Wang Zhan <wang.zhan@smartx.com>
To: netdev@vger.kernel.org, Eric Dumazet <edumazet@kernel.org>
Cc: Wang Zhan <wang.zhan@smartx.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
stable@vger.kernel.org, Kyle Zeng <kylebot@openai.com>,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH net] inet: frags: limit the truesize of a reassembly queue
Date: Thu, 29 Oct 2026 23:35:39 +0800 [thread overview]
Message-ID: <20261029153539.1224463-1-wang.zhan@smartx.com> (raw)
In-Reply-To: <20261028182934.2236310-1-edumazet@kernel.org>
Hi,
On Wed, 28 Oct 2026 19:29:34 +0100 Eric Dumazet wrote:
> @@ -510,6 +513,7 @@ int inet_frag_queue_insert(struct inet_frag_queue *q, struct sk_buff *skb,
> if (offset)
> nf_reset_ct(skb);
>
> + q->truesize += skb->truesize;
I am not sure whether q->truesize should be cleared in
inet_frag_queue_flush(). Was this intentional or an oversight?
Although this does not affect the fix, after reinit q->truesize includes
fragments that have already been freed.
The call path:
ip_frag_queue()
if (ip_frag_too_far())
ip_frag_reinit()
inet_frag_queue_flush()
inet_frag_queue_insert()
next prev parent reply other threads:[~2026-10-29 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 18:29 [PATCH net] inet: frags: limit the truesize of a reassembly queue Eric Dumazet
2026-10-29 15:35 ` Wang Zhan [this message]
2026-10-30 8:06 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029153539.1224463-1-wang.zhan@smartx.com \
--to=wang.zhan@smartx.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kylebot@openai.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox