From: Simon Horman <horms@kernel.org>
To: Naman Gulati <namangulati@google.com>
Cc: netdev-bot+sashiko@kernel.org, almasrymina@google.com,
aleksander.lobakin@intel.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH net] idpf: free the skb on TX DMA mapping errors
Date: Thu, 29 Oct 2026 16:07:12 +0000 [thread overview]
Message-ID: <20261029160712.GK257209@horms.kernel.org> (raw)
In-Reply-To: <CAMP57yUindVWCLV4O=Qki61VmZ2y8hjMPVJ51UnODz3D0LKwXw@mail.gmail.com>
On Mon, Oct 26, 2026 at 02:39:40PM -0700, Naman Gulati wrote:
> On Sat, Oct 24, 2026 at 8:04 PM <netdev-bot+sashiko@kernel.org> wrote:
> >
> > Thank you for your contribution! Sashiko AI review found 1 potential
> > issue(s) to consider.
> >
> > Critical: 0 · High: 1 · Medium: 0 (1) · Low: 0
> >
> > If you believe none of the issues are legitimate, please reply to each
> > issue of Medium severity or higher and explain why the AI is wrong.
> > If any of them are legitimate and you plan to respin, please let patchwork
> > know by including "pw-bot: cr" as a separate line at the end of your reply
> > (one such reply per series is enough).
> >
> > - [High] The fix leaves the skb leak in place for HW-timestamped packets,
> > and the Tx timestamp latch they hold is also never released.
>
> Both issues are pre-existing. This patch does not introduce any leaks
> and these should handled separately in the tx tstamp and FLOW_SCH_EN
> code paths.
Thanks, agreed.
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-10-29 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 3:04 [PATCH net] idpf: free the skb on TX DMA mapping errors Mina Almasry
2026-10-24 3:05 ` netdev-bot+sinfo
2026-10-24 3:09 ` Mina Almasry
2026-10-25 3:04 ` netdev-bot+sashiko
2026-10-26 21:39 ` Naman Gulati
2026-10-29 16:07 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261029160712.GK257209@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namangulati@google.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox